Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Bug] Wrong copy is seen when there are no synced tabs or devices #11499

Closed
jonalmeida opened this issue Jun 12, 2020 · 4 comments
Closed

[Bug] Wrong copy is seen when there are no synced tabs or devices #11499

jonalmeida opened this issue Jun 12, 2020 · 4 comments
Assignees
@mcarare
Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified eng:ready Ready for engineering Feature:SyncTabs Sync tabs help wanted Help wanted from a contributor. More complex than good first issue.
Projects
A-C: Meta: Sync Tabs Tabs Tray Fenix Sprint Kanban Hershey's 🍫

Comments

@jonalmeida
Copy link
Contributor

jonalmeida commented Jun 12, 2020 •
edited by data-sync-user
Loading

Steps to reproduce

  1. Sign-in to Sync.
  2. Do not have other Sync devices.
  3. Open Sync Tabs UI.

Expected behaviour

  • The copy to tell me to sign-in on other devices should be there (as per these designs).

Actual behaviour

  • We show the text, "Connect another device.".

Device information

  • Android device: Android 10, Pixel 4
  • Fenix version: Nightly, 10/06/20

┆Issue is synchronized with this Jira Task
@jonalmeida jonalmeida added 🐞 bug Crashes, Something isn't working, .. Feature:SyncTabs Sync tabs labels Jun 12, 2020
@github-actions github-actions bot added the needs:triage Issue needs triage label Jun 12, 2020
@ekager ekager added eng:ready Ready for engineering and removed needs:triage Issue needs triage labels Jun 12, 2020
@ekager ekager added this to Bugs before Release in Fenix Sprint Kanban Jun 12, 2020
ekager added a commit to ekager/fenix that referenced this issue Jun 12, 2020
@ekager
For mozilla-mobile#11498 mozilla-mobile#11499 - preland new synced ta…
7ae8283 
…bs strings
@ekager
Copy link
Contributor

ekager commented Jun 12, 2020

prelanding strings in #11503

@jonalmeida jonalmeida added this to Backlog in A-C: Meta: Sync Tabs Jun 12, 2020
ekager added a commit to ekager/fenix that referenced this issue Jun 12, 2020
@ekager
For mozilla-mobile#11498 mozilla-mobile#11499 - preland new synced ta…
b63e258 
…bs strings
ekager added a commit that referenced this issue Jun 12, 2020
@ekager
For #11498 #11499 - preland new synced tabs strings
e71ed31
@BranescuMihai BranescuMihai self-assigned this Jun 16, 2020
@BranescuMihai BranescuMihai moved this from Backlog to In progress in A-C: Meta: Sync Tabs Jun 16, 2020
@BranescuMihai BranescuMihai added this to In Review in Tabs Tray Jun 16, 2020
@BranescuMihai BranescuMihai moved this from Bugs before Release to In Dev Review in Fenix Sprint Kanban Jun 16, 2020
@BranescuMihai BranescuMihai added this to In Dev Review in Hershey's 🍫 Jun 16, 2020
BranescuMihai added a commit to BranescuMihai/fenix that referenced this issue Jun 16, 2020
@BranescuMihai
For mozilla-mobile#11499 - replaced string for no tabs available
8128aff
BranescuMihai added a commit to BranescuMihai/fenix that referenced this issue Jun 25, 2020
@BranescuMihai
For mozilla-mobile#11499 - replaced string for no tabs available
3625653
@BranescuMihai BranescuMihai moved this from In Dev Review to Waiting in Hershey's 🍫 Jul 20, 2020
@BranescuMihai BranescuMihai moved this from Waiting to In Progress in Hershey's 🍫 Jul 29, 2020
BranescuMihai added a commit to BranescuMihai/fenix that referenced this issue Jul 29, 2020
@BranescuMihai
For mozilla-mobile#11499 - replaced string for no tabs available
7a8c780
@BranescuMihai BranescuMihai moved this from In Progress to In Dev Review in Hershey's 🍫 Jul 30, 2020
BranescuMihai added a commit to BranescuMihai/fenix that referenced this issue Jul 31, 2020
@BranescuMihai
For mozilla-mobile#11498/mozilla-mobile#11499 - added/fixed unit tests
01a2465
BranescuMihai added a commit that referenced this issue Jul 31, 2020
@BranescuMihai
For #11499 - replaced string for no tabs available
5d1aeb5
BranescuMihai added a commit that referenced this issue Jul 31, 2020
@BranescuMihai
For #11498/#11499 - added/fixed unit tests
64072a1
@BranescuMihai BranescuMihai moved this from In Dev Review to QA Review in Hershey's 🍫 Jul 31, 2020
@BranescuMihai BranescuMihai added the eng:qa:needed QA Needed label Jul 31, 2020
@BranescuMihai BranescuMihai moved this from In Dev Review to Ready for QA in Fenix Sprint Kanban Jul 31, 2020
@BranescuMihai BranescuMihai moved this from In Review to Ready for QA in Tabs Tray Jul 31, 2020
@data-sync-user data-sync-user changed the title [Bug] Wrong copy is seen when there are no synced tabs or devices FNX-12444 ⁃ [Bug] Wrong copy is seen when there are no synced tabs or devices Aug 1, 2020
@sflorean
Copy link
Contributor

sflorean commented Aug 4, 2020

Tested on Nightly 8/4 and

  • for No tabs opened on other devices: "You don't have any tabs open in Firefox on your other devices" is displayed.
  • for No other devices connected: "Connect another device" message is displayed.

@BranescuMihai looking at the description seems that the issue is still reproducible. ref ##11499 (comment).

@sflorean sflorean removed the eng:qa:needed QA Needed label Aug 4, 2020
@data-sync-user data-sync-user changed the title FNX-12444 ⁃ [Bug] Wrong copy is seen when there are no synced tabs or devices FNX3-14683 ⁃ [Bug] Wrong copy is seen when there are no synced tabs or devices Aug 11, 2020
@data-sync-user data-sync-user added the eng:qa:needed QA Needed label Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX3-14683 ⁃ [Bug] Wrong copy is seen when there are no synced tabs or devices FNX-12444 ⁃ [Bug] Wrong copy is seen when there are no synced tabs or devices Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX-12444 ⁃ [Bug] Wrong copy is seen when there are no synced tabs or devices FNX2-13493 ⁃ [Bug] Wrong copy is seen when there are no synced tabs or devices Aug 11, 2020
@sflorean
Copy link
Contributor

Tested on Nightly 8/4 and

  • for No tabs opened on other devices: "You don't have any tabs open in Firefox on your other devices" is displayed.
  • for No other devices connected: "Connect another device" message is displayed.

@BranescuMihai looking at the description seems that the issue is still reproducible. ref ##11499 (comment).

@BranescuMihai could you please add your input regarding the above results?

@sflorean sflorean removed the eng:qa:needed QA Needed label Aug 12, 2020
@liuche liuche added the help wanted Help wanted from a contributor. More complex than good first issue. label Aug 28, 2020
@liuche liuche added this to Inbox in Engineering triage via automation Aug 28, 2020
@liuche liuche moved this from Inbox to Hershey Staging in Engineering triage Aug 28, 2020
@kbrosnan kbrosnan changed the title FNX2-13493 ⁃ [Bug] Wrong copy is seen when there are no synced tabs or devices [Bug] Wrong copy is seen when there are no synced tabs or devices Aug 29, 2020
@liuche liuche removed this from Hershey Staging in Engineering triage Sep 11, 2020
@sflorean
Copy link
Contributor

Closing this as verified, since if we don't have other sync devices, the "Connect another device" is correct from our point.

A-C: Meta: Sync Tabs automation moved this from In progress to Done Sep 16, 2020
Tabs Tray automation moved this from Ready for QA to Done Sep 16, 2020
Fenix Sprint Kanban automation moved this from Ready for QA to Sprint 20.11 Done Sep 16, 2020
@sflorean sflorean added the eng:qa:verified QA Verified label Sep 16, 2020
@mcarare mcarare moved this from QA Review to Done in Hershey's 🍫 Sep 18, 2020
@mcarare mcarare moved this from Done to Done Sprint 20.19 in Hershey's 🍫 Sep 18, 2020
@mcarare mcarare self-assigned this Sep 23, 2020
@mcarare mcarare moved this from Done Sprint 20.19 to Done in Hershey's 🍫 Sep 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mcarare mcarare

Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified eng:ready Ready for engineering Feature:SyncTabs Sync tabs help wanted Help wanted from a contributor. More complex than good first issue.
Projects
Fenix Sprint Kanban
  
Sprint 20.11 Done
A-C: Meta: Sync Tabs
  
Done
Hershey's 🍫
  
Done
Tabs Tray
  
Done
Milestone
No milestone
Development

No branches or pull requests
8 participants
@liuche @gabrielluong @jonalmeida @BranescuMihai @ekager @mcarare @data-sync-user @sflorean