Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Bug] Sign-in CTA for Sync Tabs is missing #11498

Closed
jonalmeida opened this issue Jun 12, 2020 · 4 comments
Closed

[Bug] Sign-in CTA for Sync Tabs is missing #11498

jonalmeida opened this issue Jun 12, 2020 · 4 comments
Assignees
@BranescuMihai
Labels
🐞 bug Crashes, Something isn't working, .. E3 Estimation Point: average, 2 - 3 days eng:qa:verified QA Verified eng:ready Ready for engineering Feature:SyncTabs Sync tabs
Projects
A-C: Meta: Sync Tabs Tabs Tray Fenix Sprint Kanban Hershey's 🍫

Comments

@jonalmeida
Copy link
Contributor

jonalmeida commented Jun 12, 2020 •
edited by data-sync-user
Loading

Steps to reproduce

  1. Do NOT have a Sync account setup.
  2. Open Sync Tabs menu.

Expected behavior

  • The CTA button to direct me to sign-in should be there (as per these designs).

Actual behavior

  • We show some text "Connect a Sync account".

Device information

  • Android device: Android 10, Pixel 4
  • Fenix version: Nightly, 10/06/20

┆Issue is synchronized with this Jira Task
@jonalmeida jonalmeida added 🐞 bug Crashes, Something isn't working, .. Feature:SyncTabs Sync tabs labels Jun 12, 2020
@github-actions github-actions bot added the needs:triage Issue needs triage label Jun 12, 2020
@ekager ekager added this to Bugs before Release in Fenix Sprint Kanban Jun 12, 2020
@ekager ekager added eng:ready Ready for engineering and removed needs:triage Issue needs triage labels Jun 12, 2020
ekager added a commit to ekager/fenix that referenced this issue Jun 12, 2020
@ekager
For mozilla-mobile#11498 mozilla-mobile#11499 - preland new synced ta…
7ae8283 
…bs strings
@ekager
Copy link
Contributor

ekager commented Jun 12, 2020

prelanding strings in #11503

@jonalmeida jonalmeida added this to Backlog in A-C: Meta: Sync Tabs Jun 12, 2020
ekager added a commit to ekager/fenix that referenced this issue Jun 12, 2020
@ekager
For mozilla-mobile#11498 mozilla-mobile#11499 - preland new synced ta…
b63e258 
…bs strings
ekager added a commit that referenced this issue Jun 12, 2020
@ekager
For #11498 #11499 - preland new synced tabs strings
e71ed31
@BranescuMihai BranescuMihai self-assigned this Jun 15, 2020
@BranescuMihai BranescuMihai added this to In Progress in Hershey's 🍫 Jun 15, 2020
@BranescuMihai BranescuMihai moved this from Bugs before Release to In Progress in Fenix Sprint Kanban Jun 15, 2020
@gabrielluong gabrielluong added this to In Progress in Tabs Tray Jun 16, 2020
BranescuMihai added a commit to BranescuMihai/fenix that referenced this issue Jun 16, 2020
@BranescuMihai
For mozilla-mobile#11498 - add Sync tabs error view (including sign-i…
38c58f4 
…n CTA)
@BranescuMihai BranescuMihai moved this from Backlog to In progress in A-C: Meta: Sync Tabs Jun 16, 2020
@BranescuMihai BranescuMihai moved this from In Progress to In Review in Tabs Tray Jun 16, 2020
@BranescuMihai BranescuMihai moved this from In Progress to In Dev Review in Fenix Sprint Kanban Jun 16, 2020
@BranescuMihai BranescuMihai moved this from In Progress to In Dev Review in Hershey's 🍫 Jun 16, 2020
BranescuMihai added a commit to BranescuMihai/fenix that referenced this issue Jun 25, 2020
@BranescuMihai
For mozilla-mobile#11498 - add Sync tabs error view (including sign-i…
4f5a2dd 
…n CTA)
BranescuMihai added a commit to BranescuMihai/fenix that referenced this issue Jun 25, 2020
@BranescuMihai
For mozilla-mobile#11498 - removed SignIn ViewHolder and unified with…
b257b6b 
… the Error one
@BranescuMihai BranescuMihai mentioned this issue Jul 6, 2020
Closed
@liuche
Copy link
Contributor

liuche commented Jul 16, 2020

Could we get this landed in this sprint so it makes it into the Sept release?

@ekager
Copy link
Contributor

ekager commented Jul 16, 2020

There are apparently some issues uncovered in the PR that need investigation: #11634 (comment)

@Mugurell Mugurell added hershey and removed Skittle labels Jul 20, 2020
@BranescuMihai BranescuMihai moved this from In Dev Review to Waiting in Hershey's 🍫 Jul 20, 2020
@BranescuMihai BranescuMihai moved this from Waiting to In Progress in Hershey's 🍫 Jul 29, 2020
@BranescuMihai BranescuMihai moved this from In Progress to In Dev Review in Hershey's 🍫 Jul 30, 2020
@Mugurell Mugurell added the E3 Estimation Point: average, 2 - 3 days label Jul 31, 2020
BranescuMihai added a commit to BranescuMihai/fenix that referenced this issue Jul 31, 2020
@BranescuMihai
For mozilla-mobile#11498/mozilla-mobile#11499 - added/fixed unit tests
01a2465
BranescuMihai added a commit that referenced this issue Jul 31, 2020
@BranescuMihai
For #11498 - add Sync tabs error view (including sign-in CTA)
bfc955c
BranescuMihai added a commit that referenced this issue Jul 31, 2020
@BranescuMihai
For #11498 - removed SignIn ViewHolder and unified with the Error one
ff50dae
BranescuMihai added a commit that referenced this issue Jul 31, 2020
@BranescuMihai
For #11498/#11499 - added/fixed unit tests
64072a1
@BranescuMihai BranescuMihai moved this from In Review to Ready for QA in Tabs Tray Jul 31, 2020
@BranescuMihai BranescuMihai moved this from In Dev Review to Ready for QA in Fenix Sprint Kanban Jul 31, 2020
@BranescuMihai BranescuMihai moved this from In Dev Review to QA Review in Hershey's 🍫 Jul 31, 2020
@BranescuMihai BranescuMihai added the eng:qa:needed QA Needed label Jul 31, 2020
@data-sync-user data-sync-user changed the title [Bug] Sign-in CTA for Sync Tabs is missing FNX3-14682 ⁃ [Bug] Sign-in CTA for Sync Tabs is missing Jul 31, 2020
@LaurentiuApahideanSV
Copy link

Verified as fixed on Firefox Preview Nightly 200803 (Build #22161810).

Devices used:

  • Huawei MediaPad M3 lite (Android 7)
  • OnePlus 6T (Android 9)

A-C: Meta: Sync Tabs automation moved this from In progress to Done Aug 4, 2020
Fenix Sprint Kanban automation moved this from Ready for QA to Sprint 20.11 Done Aug 4, 2020
Tabs Tray automation moved this from Ready for QA to Done Aug 4, 2020
@LaurentiuApahideanSV LaurentiuApahideanSV added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Aug 4, 2020
@data-sync-user data-sync-user added the eng:qa:needed QA Needed label Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX3-14682 ⁃ [Bug] Sign-in CTA for Sync Tabs is missing FNX-12443 ⁃ [Bug] Sign-in CTA for Sync Tabs is missing Aug 11, 2020
Fenix Sprint Kanban automation moved this from Sprint 20.11 Done to In Progress Aug 11, 2020
Tabs Tray automation moved this from Done to In Progress Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX-12443 ⁃ [Bug] Sign-in CTA for Sync Tabs is missing FNX2-13492 ⁃ [Bug] Sign-in CTA for Sync Tabs is missing Aug 11, 2020
@sflorean sflorean removed the eng:qa:needed QA Needed label Aug 12, 2020
Fenix Sprint Kanban automation moved this from In Progress to Sprint 20.11 Done Aug 12, 2020
Tabs Tray automation moved this from In Progress to Done Aug 12, 2020
@Mugurell Mugurell moved this from QA Review to Done in Hershey's 🍫 Aug 17, 2020
@data-sync-user data-sync-user changed the title FNX2-13492 ⁃ [Bug] Sign-in CTA for Sync Tabs is missing [Bug] Sign-in CTA for Sync Tabs is missing May 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@BranescuMihai BranescuMihai

Labels
🐞 bug Crashes, Something isn't working, .. E3 Estimation Point: average, 2 - 3 days eng:qa:verified QA Verified eng:ready Ready for engineering Feature:SyncTabs Sync tabs
Projects
Fenix Sprint Kanban
  
Sprint 20.11 Done
A-C: Meta: Sync Tabs
  
Done
Hershey's 🍫
  
Done
Tabs Tray
  
Done
Milestone
No milestone
Development

No branches or pull requests
9 participants
@liuche @gabrielluong @jonalmeida @BranescuMihai @Mugurell @ekager @LaurentiuApahideanSV @data-sync-user @sflorean