Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Bug] alignment issue in tabs tray #11562

Closed
cadeyrn opened this issue Jun 14, 2020 · 2 comments · Fixed by #11894
Closed

[Bug] alignment issue in tabs tray #11562

cadeyrn opened this issue Jun 14, 2020 · 2 comments · Fixed by #11894
Assignees
@mcarare
Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified eng:ready Ready for engineering Feature:Tabs
Projects
Tabs Tray

Comments

@cadeyrn
Copy link
Contributor

cadeyrn commented Jun 14, 2020 •
edited by data-sync-user
Loading

Steps to reproduce

  1. open the taby tray

Expected behavior

Better alignment of the tree dots menu icon and the close icon of the tabs.

Actual behavior

Device information

  • Android device: OnePlus 7T Pro McLaren Edition with Oxygen OS 10.0.9 (Android 10)
  • Fenix version: master branch revision 7e61165

┆Issue is synchronized with this Jira Task
@cadeyrn cadeyrn added the 🐞 bug Crashes, Something isn't working, .. label Jun 14, 2020
@github-actions github-actions bot added the needs:triage Issue needs triage label Jun 14, 2020
@gabrielluong gabrielluong added Feature:Tabs Skittle and removed needs:triage Issue needs triage labels Jun 16, 2020
@gabrielluong gabrielluong added this to Triage in Tabs Tray via automation Jun 16, 2020
@ValentinTimisica ValentinTimisica added the needs:UX-feedback Needs UX Feedback label Jun 23, 2020
@AmyYLee AmyYLee removed the needs:UX-feedback Needs UX Feedback label Jun 24, 2020
@AmyYLee
Copy link
Collaborator

AmyYLee commented Jun 24, 2020

I agree the 3-dot icon should be centered

@AmyYLee AmyYLee added the eng:ready Ready for engineering label Jun 24, 2020
@gabrielluong gabrielluong moved this from Triage to Sprint in Tabs Tray Jun 24, 2020
mcarare added a commit to mcarare/fenix that referenced this issue Jun 24, 2020
@mcarare
For mozilla-mobile#11562: Align overflow menu button with close buttons.
108bbf6
@darkwing darkwing moved this from Sprint to In Review in Tabs Tray Jun 24, 2020
@mcarare mcarare mentioned this issue Jun 24, 2020
Merged
4 tasks
ekager pushed a commit to mcarare/fenix that referenced this issue Jun 25, 2020
@mcarare @ekager
For mozilla-mobile#11562: Align overflow menu button with close buttons.
399ef9b
Tabs Tray automation moved this from In Review to Done Jun 25, 2020
ekager pushed a commit that referenced this issue Jun 25, 2020
@mcarare @ekager
For #11562: Align overflow menu button with close buttons.
7b20bb9
@ekager ekager added the eng:qa:needed QA Needed label Jun 25, 2020
@AndiAJ
Copy link
Collaborator

AndiAJ commented Jun 25, 2020

Hi, verified as fixed on the latest Nightly Build 200625 from 6/25 using the following devices:
• Google Pixel 3a (Android 10)
• Huawei Mate 20 Lite (Android 9)
• OnePlus A3 (Android 6.0.1)

► Screenshot
rsz_rsz_screennnnnshot_20200625-142037

@AndiAJ AndiAJ added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Jun 25, 2020
@liuche liuche mentioned this issue Jun 27, 2020
Closed
12 tasks
@data-sync-user data-sync-user changed the title [Bug] alignment issue in tabs tray FNX2-16556 ⁃ [Bug] alignment issue in tabs tray Aug 1, 2020
@data-sync-user data-sync-user changed the title FNX2-16556 ⁃ [Bug] alignment issue in tabs tray FNX3-14726 ⁃ [Bug] alignment issue in tabs tray Aug 11, 2020
Tabs Tray automation moved this from Done to In Progress Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX3-14726 ⁃ [Bug] alignment issue in tabs tray FNX-12513 ⁃ [Bug] alignment issue in tabs tray Aug 11, 2020
Tabs Tray automation moved this from In Progress to Done Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX-12513 ⁃ [Bug] alignment issue in tabs tray FNX2-16556 ⁃ [Bug] alignment issue in tabs tray Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX2-16556 ⁃ [Bug] alignment issue in tabs tray [Bug] alignment issue in tabs tray May 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mcarare mcarare

Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified eng:ready Ready for engineering Feature:Tabs
Projects
No open projects
Tabs Tray
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

For #11562: Align overflow menu button with close buttons. mcarare/fenix
8 participants
@cadeyrn @gabrielluong @AmyYLee @ekager @mcarare @AndiAJ @ValentinTimisica @data-sync-user