[Telemetry] Text Selection Toolbar

[vesta0]

Description & Product Manager / Data Scientist User Story

As a product manager, I want to know which context menu option are used frequently when users long press on text on a page, so we can ensure that the order matches our users' needs and saves them time.

What questions will you answer with this data?

-What percentage of users tab on any of the long press context menu options (copy, share, search, select all)?
-Which context menu options are used most frequently.

Acceptance Criteria

• ENG files a DS JIRA request outlining their methodology.
• DS sign off on instrumentation methodology addressing product questions.
• Event pings can be queried via re:dash
• Event pings can be queried via amplitude
• We are sending telemetry events for the actions listed in the requirements
• We have documented the telemetry
• We have asked a data steward to review the telemetry

┆Issue is synchronized with this Jira Task

[sblatz]

This lives in AC

To be clear this is for the TEXT SELECTION contextual menu.

Notes

• Add this under category contextual_menu

[codrut-topliceanu]

which context menu option are used frequently when users long press on text on a page

Ok. So maybe a type: counter for each of the text selection contextual menu options. (DefaultSelectionActionDelegate.kt)

What percentage of users tap on any of the long press context menu options

Perhaps a type: boolean to know if users have ever activated any of these options before.

@kglazko @sblatz Does that sound/look ok to you?

[kglazko]

Yes that looks good to me! I agree with the boolean to indicate if an option was used. I do wonder though if sequential matters at all in these interactions with this toolbar.. I will check in with Data Science and follow up.

[Mugurell]

Talked offline with Kate who confirmed with DS and Boek:

• The newly added metrics should log events, not counters anymore
• An an expiration date 6 months is preferred.
  Maybe if there is already related telemetry for that part of the screen / feature we can reuse the existing expiration date so that all related telemetry probes will be renewed at the same time.

[lobontiumira]

Verified on the 1/5 Nightly build using a Google Pixel (Android 10):

1. contextual menu: copy_tapped ✔️
   Ping a1c8a219-1dcf-41e0-afce-32d106f1097a

{
          "category": "contextual_menu",
          "name": "copy_tapped",
          "timestamp": 10379
        }

2. contextual menu: search_tapped ✔️
   Ping a1c8a219-1dcf-41e0-afce-32d106f1097a

{
         "category": "contextual_menu",
         "name": "search_tapped",
         "timestamp": 18838
       }

3. contextual menu: select_all_tapped ✔️
   Ping a1c8a219-1dcf-41e0-afce-32d106f1097a

{
          "category": "contextual_menu",
          "name": "select_all_tapped",
          "timestamp": 22404
        }

4. contextual menu: share_tapped ✔️
   Ping a1c8a219-1dcf-41e0-afce-32d106f1097a

{
          "category": "contextual_menu",
          "name": "share_tapped",
          "timestamp": 29625
        }

Logcat
Glean dashboard

@codrut-topliceanu there is no "contextual menu: long_press_tapped" event generated.
Could you please review?

[codrut-topliceanu]

@softvision-miralobontiu I've spoken with @kglazko and she said it's okay to remove long_press_tapped.
As this issue's PR is already merged I've created a new issue for the removal. (#17481).

Besides the removal of long_press_tapped is there anything else that needs to be done on this issue?

[lobontiumira]

@codrut-topliceanu thanks!
Nope, the only reason the ticket was left opened was for the "contextual menu: long_press_tapped" event.
I'll close it.