Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Bug]Tabs tray: Tapping the New Tab FAB displays ":)" instead of the tabs number #11672

Closed
AndiAJ opened this issue Jun 17, 2020 · 3 comments
Closed

[Bug]Tabs tray: Tapping the New Tab FAB displays ":)" instead of the tabs number #11672

AndiAJ opened this issue Jun 17, 2020 · 3 comments
Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified Feature:Tabs S2 Major Functionality/product severely impaired and a satisfactory workaround doesn't exist
Projects
Tabs Tray

Comments

@AndiAJ
Copy link
Collaborator

AndiAJ commented Jun 17, 2020 •
edited by data-sync-user
Loading

Prerequisites

Have at least a tab opened

Steps to reproduce

  1. From the page view tap the tabs counter
  2. Tapping the New tab FAB
  3. Check the Tabs Counter icon

Expected behavior

The Tabs Counter should display the number of open tabs

Actual behavior

Displays ":)" while the making the transition to Fenix's home screen
image

Device information

  • Android device: OnePlus A3 (Android 6.0.1)
  • Fenix version:
    • Nightly 200617 from 6/17
    • Beta 5.2.0-beta.2 from 6/16

Notes

► Video
20200617-104416

┆Issue is synchronized with this Jira Task
@AndiAJ AndiAJ added 🐞 bug Crashes, Something isn't working, .. Feature:Tabs labels Jun 17, 2020
@github-actions github-actions bot added the needs:triage Issue needs triage label Jun 17, 2020
@sv-ohorvath sv-ohorvath added this to Triage in Tabs Tray via automation Jun 17, 2020
@AndiAJ AndiAJ mentioned this issue Jun 17, 2020
Closed
@AndiAJ AndiAJ added S2 Major Functionality/product severely impaired and a satisfactory workaround doesn't exist Skittle labels Jun 17, 2020
@gabrielluong gabrielluong removed the needs:triage Issue needs triage label Jun 18, 2020
@mcarare mcarare mentioned this issue Jun 18, 2020
Closed
@hkaancaliskan
Copy link

hkaancaliskan commented Jun 18, 2020 •
edited
Loading

I'm working on this. Instead of showing ":)" why not to don't touch to counter_text until fetching tab number?

fenix/app/src/main/java/org/mozilla/fenix/components/toolbar/TabCounter.kt

Line 32 in 1356b3e

counter_text.text = DEFAULT_TABS_COUNTER_TEXT

@hkaancaliskan hkaancaliskan mentioned this issue Jun 18, 2020
Closed
4 tasks
@BranescuMihai BranescuMihai mentioned this issue Jun 24, 2020
Merged
4 tasks
BranescuMihai pushed a commit to BranescuMihai/fenix that referenced this issue Jun 24, 2020
@BranescuMihai
Fixes mozilla-mobile#11672, mozilla-mobile#11727: Empty default tab t…
3e5f982 
…ext and add padding to infinite character
BranescuMihai pushed a commit to BranescuMihai/fenix that referenced this issue Jun 24, 2020
@hkaancaliskan @BranescuMihai
don't animate unnecessarily
3f88fc9 
Fixes mozilla-mobile#11672, mozilla-mobile#11727: Empty default tab text and add padding to infinite character

Fixes mozilla-mobile#11739: Fix flicker

Update TabCounter.kt

make lint happy

don't animate unnecessarily

don't animate unnecessarily

Fixes mozilla-mobile#11739: Fix flicker

Update TabCounter.kt

squash commits

don't animate unnecessarily

Fixes mozilla-mobile#11672, mozilla-mobile#11727: Empty default tab text and add padding to infinite character

Fixes mozilla-mobile#11739: Fix flicker

Update TabCounter.kt

make lint happy

don't animate unnecessarily
ekager pushed a commit to BranescuMihai/fenix that referenced this issue Jun 25, 2020
@ekager
Fixes mozilla-mobile#11672, mozilla-mobile#11727: Empty default tab t…
29b49b5 
…ext and add padding to infinite character
ekager pushed a commit to BranescuMihai/fenix that referenced this issue Jun 25, 2020
@hkaancaliskan @ekager
don't animate unnecessarily
9336966 
Fixes mozilla-mobile#11672, mozilla-mobile#11727: Empty default tab text and add padding to infinite character

Fixes mozilla-mobile#11739: Fix flicker

Update TabCounter.kt

make lint happy

don't animate unnecessarily

don't animate unnecessarily

Fixes mozilla-mobile#11739: Fix flicker

Update TabCounter.kt

squash commits

don't animate unnecessarily

Fixes mozilla-mobile#11672, mozilla-mobile#11727: Empty default tab text and add padding to infinite character

Fixes mozilla-mobile#11739: Fix flicker

Update TabCounter.kt

make lint happy

don't animate unnecessarily
@ekager ekager closed this as completed in b95804c Jun 25, 2020
Tabs Tray automation moved this from Triage to Done Jun 25, 2020
ekager pushed a commit that referenced this issue Jun 25, 2020
@hkaancaliskan @ekager
don't animate unnecessarily
9068c96 
Fixes #11672, #11727: Empty default tab text and add padding to infinite character

Fixes #11739: Fix flicker

Update TabCounter.kt

make lint happy

don't animate unnecessarily

don't animate unnecessarily

Fixes #11739: Fix flicker

Update TabCounter.kt

squash commits

don't animate unnecessarily

Fixes #11672, #11727: Empty default tab text and add padding to infinite character

Fixes #11739: Fix flicker

Update TabCounter.kt

make lint happy

don't animate unnecessarily
@ekager ekager added the eng:qa:needed QA Needed label Jun 25, 2020
@ekager
Copy link
Contributor

ekager commented Jun 25, 2020

Reopening for QA

@ekager ekager reopened this Jun 25, 2020
Tabs Tray automation moved this from Done to In Progress Jun 25, 2020
@AndiAJ
Copy link
Collaborator Author

AndiAJ commented Jun 25, 2020

Hi, verified as fixed on the latest Nightly Build 200625 from 6/25 using the following devices:
• Google Pixel 3a (Android 10)
• Huawei Mate 20 Lite (Android 9)
• OnePlus A3 (Android 6.0.1)

► Video
20200625-113006

@AndiAJ AndiAJ closed this as completed Jun 25, 2020
Tabs Tray automation moved this from In Progress to Done Jun 25, 2020
@AndiAJ AndiAJ added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Jun 25, 2020
@liuche liuche mentioned this issue Jun 27, 2020
Closed
12 tasks
@data-sync-user data-sync-user changed the title [Bug]Tabs tray: Tapping the New Tab FAB displays ":)" instead of the tabs number FNX2-16610 ⁃ [Bug]Tabs tray: Tapping the New Tab FAB displays ":)" instead of the tabs number Aug 1, 2020
@data-sync-user data-sync-user changed the title FNX2-16610 ⁃ [Bug]Tabs tray: Tapping the New Tab FAB displays ":)" instead of the tabs number FNX3-14812 ⁃ [Bug]Tabs tray: Tapping the New Tab FAB displays ":)" instead of the tabs number Aug 11, 2020
Tabs Tray automation moved this from Done to In Progress Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX3-14812 ⁃ [Bug]Tabs tray: Tapping the New Tab FAB displays ":)" instead of the tabs number FNX-12648 ⁃ [Bug]Tabs tray: Tapping the New Tab FAB displays ":)" instead of the tabs number Aug 11, 2020
Tabs Tray automation moved this from In Progress to Done Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX-12648 ⁃ [Bug]Tabs tray: Tapping the New Tab FAB displays ":)" instead of the tabs number FNX2-16610 ⁃ [Bug]Tabs tray: Tapping the New Tab FAB displays ":)" instead of the tabs number Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX2-16610 ⁃ [Bug]Tabs tray: Tapping the New Tab FAB displays ":)" instead of the tabs number [Bug]Tabs tray: Tapping the New Tab FAB displays ":)" instead of the tabs number May 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified Feature:Tabs S2 Major Functionality/product severely impaired and a satisfactory workaround doesn't exist
Projects
No open projects
Tabs Tray
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes #11672, #11727: Delete default tab text and add padding to infinite character
5 participants
@gabrielluong @hkaancaliskan @ekager @AndiAJ @data-sync-user