Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Bug]Tabs Tray: Tabs counter "∞" symbol padding issue #11727

Closed
AndiAJ opened this issue Jun 18, 2020 · 4 comments · Fixed by #11878
Closed

[Bug]Tabs Tray: Tabs counter "∞" symbol padding issue #11727

AndiAJ opened this issue Jun 18, 2020 · 4 comments · Fixed by #11878
Assignees
@hkaancaliskan
Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified Feature:Tabs

Comments

@AndiAJ
Copy link
Collaborator

AndiAJ commented Jun 18, 2020 •
edited by data-sync-user
Loading

Steps to reproduce

  1. Open more than 100 tabs
  2. Check the Tabs counter

Expected behavior

Properly displayed "∞" symbol

Actual behavior

Padding issues

Device information

  • Android device:
    • Google Pixel 3a (Android 10)
    • Huawei Mate 20 Lite (Android 9)
    • OnePlus A3 (Android 6.0.1)
  • Fenix version:
    • Nightly 200618 from 6/18
    • Beta 5.2.0-beta.2 from 6/16

Notes

► Screenshot
rszUNITO-UNDERSCORE!screenshot!UNITO-UNDERSCORE!20200618-125149!

┆Issue is synchronized with this Jira Task
@AndiAJ AndiAJ added 🐞 bug Crashes, Something isn't working, .. Feature:Tabs labels Jun 18, 2020
@github-actions github-actions bot added the needs:triage Issue needs triage label Jun 18, 2020
@hkaancaliskan
Copy link

hkaancaliskan commented Jun 18, 2020 •
edited
Loading

Is there a way to open 100 tabs easily :)
Edit: while true; do am start -n org.mozilla.fenix.debug/org.mozilla.fenix.IntentReceiverActivity https://amazon.com; sleep 2; done
this works fine on adb shell

@gabrielluong gabrielluong added Skittle and removed needs:triage Issue needs triage labels Jun 18, 2020
@hkaancaliskan
Copy link

hkaancaliskan commented Jun 18, 2020 •
edited
Loading

Added some padding bottom if gonna show infinite character because infinite character's height is nearly half of numbers.
I'm unable to produce that cut-off @AndiAJ.
I'll open pr after some more investigation. #11738
resim

@gabrielluong
Copy link
Member

gabrielluong commented Jun 18, 2020 •
edited
Loading

@hakkikaancaliskan I am assigning this to you since you already looking into this. Thank you for the help!

@hkaancaliskan hkaancaliskan mentioned this issue Jun 18, 2020
Closed
4 tasks
BranescuMihai added a commit to BranescuMihai/fenix that referenced this issue Jun 24, 2020
@BranescuMihai
For mozilla-mobile#11727 - added content description
84c6429
@BranescuMihai BranescuMihai mentioned this issue Jun 24, 2020
Merged
4 tasks
BranescuMihai pushed a commit to BranescuMihai/fenix that referenced this issue Jun 24, 2020
@BranescuMihai
Fixes mozilla-mobile#11672, mozilla-mobile#11727: Empty default tab t…
3e5f982 
…ext and add padding to infinite character
BranescuMihai pushed a commit to BranescuMihai/fenix that referenced this issue Jun 24, 2020
@hkaancaliskan @BranescuMihai
don't animate unnecessarily
3f88fc9 
Fixes mozilla-mobile#11672, mozilla-mobile#11727: Empty default tab text and add padding to infinite character

Fixes mozilla-mobile#11739: Fix flicker

Update TabCounter.kt

make lint happy

don't animate unnecessarily

don't animate unnecessarily

Fixes mozilla-mobile#11739: Fix flicker

Update TabCounter.kt

squash commits

don't animate unnecessarily

Fixes mozilla-mobile#11672, mozilla-mobile#11727: Empty default tab text and add padding to infinite character

Fixes mozilla-mobile#11739: Fix flicker

Update TabCounter.kt

make lint happy

don't animate unnecessarily
BranescuMihai added a commit to BranescuMihai/fenix that referenced this issue Jun 24, 2020
@BranescuMihai
For mozilla-mobile#11727 - added content description
aca3a3b
ekager pushed a commit to BranescuMihai/fenix that referenced this issue Jun 25, 2020
@ekager
Fixes mozilla-mobile#11672, mozilla-mobile#11727: Empty default tab t…
29b49b5 
…ext and add padding to infinite character
ekager pushed a commit to BranescuMihai/fenix that referenced this issue Jun 25, 2020
@hkaancaliskan @ekager
don't animate unnecessarily
9336966 
Fixes mozilla-mobile#11672, mozilla-mobile#11727: Empty default tab text and add padding to infinite character

Fixes mozilla-mobile#11739: Fix flicker

Update TabCounter.kt

make lint happy

don't animate unnecessarily

don't animate unnecessarily

Fixes mozilla-mobile#11739: Fix flicker

Update TabCounter.kt

squash commits

don't animate unnecessarily

Fixes mozilla-mobile#11672, mozilla-mobile#11727: Empty default tab text and add padding to infinite character

Fixes mozilla-mobile#11739: Fix flicker

Update TabCounter.kt

make lint happy

don't animate unnecessarily
ekager pushed a commit to BranescuMihai/fenix that referenced this issue Jun 25, 2020
@BranescuMihai @ekager
For mozilla-mobile#11727 - added content description
afe133c
ekager pushed a commit that referenced this issue Jun 25, 2020
@ekager
Fixes #11672, #11727: Empty default tab text and add padding to infin…
b95804c 
…ite character
ekager pushed a commit that referenced this issue Jun 25, 2020
@hkaancaliskan @ekager
don't animate unnecessarily
9068c96 
Fixes #11672, #11727: Empty default tab text and add padding to infinite character

Fixes #11739: Fix flicker

Update TabCounter.kt

make lint happy

don't animate unnecessarily

don't animate unnecessarily

Fixes #11739: Fix flicker

Update TabCounter.kt

squash commits

don't animate unnecessarily

Fixes #11672, #11727: Empty default tab text and add padding to infinite character

Fixes #11739: Fix flicker

Update TabCounter.kt

make lint happy

don't animate unnecessarily
ekager pushed a commit that referenced this issue Jun 25, 2020
@BranescuMihai @ekager
For #11727 - added content description
be5213e
@ekager ekager added the eng:qa:needed QA Needed label Jun 25, 2020
@AndiAJ
Copy link
Collaborator Author

AndiAJ commented Jun 25, 2020

Hi, verified as fixed on the latest Nightly Build 200625 from 6/25 using the following devices:
• Google Pixel 3a (Android 10)
• Huawei Mate 20 Lite (Android 9)
• OnePlus A3 (Android 6.0.1)

► Screenshots
rsz_11rsz_screenshot_20200625-101350

@AndiAJ AndiAJ closed this as completed Jun 25, 2020
@AndiAJ AndiAJ added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Jun 25, 2020
@gabrielluong gabrielluong linked a pull request Jun 25, 2020 that will close this issue
Bugfix/#11672, #11727: Delete default tab text and add padding to infinite character #11878
Merged
4 tasks
@liuche liuche mentioned this issue Jun 27, 2020
Closed
12 tasks
@data-sync-user data-sync-user changed the title [Bug]Tabs Tray: Tabs counter "∞" symbol padding issue FNX2-16640 ⁃ [Bug]Tabs Tray: Tabs counter "∞" symbol padding issue Aug 1, 2020
@data-sync-user data-sync-user changed the title FNX2-16640 ⁃ [Bug]Tabs Tray: Tabs counter "∞" symbol padding issue FNX3-14861 ⁃ [Bug]Tabs Tray: Tabs counter "∞" symbol padding issue Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX3-14861 ⁃ [Bug]Tabs Tray: Tabs counter "∞" symbol padding issue FNX-12707 ⁃ [Bug]Tabs Tray: Tabs counter "∞" symbol padding issue Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX-12707 ⁃ [Bug]Tabs Tray: Tabs counter "∞" symbol padding issue FNX2-16640 ⁃ [Bug]Tabs Tray: Tabs counter "∞" symbol padding issue Aug 11, 2020
Closed
@data-sync-user data-sync-user changed the title FNX2-16640 ⁃ [Bug]Tabs Tray: Tabs counter "∞" symbol padding issue [Bug]Tabs Tray: Tabs counter "∞" symbol padding issue May 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@hkaancaliskan hkaancaliskan

Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified Feature:Tabs
Projects
None yet
Milestone
No milestone
5 participants
@gabrielluong @hkaancaliskan @ekager @AndiAJ @data-sync-user