This repository has been archived by the owner on Feb 20, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
[Bug] Incorrect URL when sharing page from the reader view #11798
Labels
Comments
Removing ac label as this would needs a fix in Fenix to use the original article URL, if reader mode is turned on, similar to:
|
My comment above will only work for active sessions. If sharing from history or bookmarks etc. we wouldn't find the session in the store. So, a better solution here, is to process the URL before sharing. I will give this a try. |
csadilek
added a commit
to csadilek/fenix
that referenced
this issue
Jun 25, 2020
csadilek
added a commit
to csadilek/fenix
that referenced
this issue
Jun 25, 2020
csadilek
added a commit
to csadilek/fenix
that referenced
this issue
Jun 25, 2020
csadilek
added a commit
to csadilek/fenix
that referenced
this issue
Jun 25, 2020
csadilek
added a commit
to csadilek/fenix
that referenced
this issue
Jun 25, 2020
csadilek
added a commit
that referenced
this issue
Jun 25, 2020
OK, this is fixed now on master and will be in tomorrow's Nightly. |
Verified as fixed on Nightly 06/26 with Xiaomi Redmi Note 8T (Android 9) and LG G7 FIT (Android 8). |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Steps to reproduce
Switch page to reader view. Share it.
Expected behavior
The url in the shared item should be the same as in original page outside reader view so it can be shared directly from reader view.
Actual behavior
Url in shared item is like this
which will not work on receiver's end. It must be switched back from reader view, share it and then return back to reader view, and the article is back on top.
Device information
┆Issue is synchronized with this Jira Task
The text was updated successfully, but these errors were encountered: