-
Notifications
You must be signed in to change notification settings - Fork 1.3k
When clicking URL bar, UI waits on long delay for on capturing thumbnail #11825
Comments
It appears this thumbnail is captured to be used for the animation, which prevents the screen from flashing when the animation occurs. In the worst case where we're unable to perform the animation because capturing the thumbnail is too slow, we should check with UX/product but I think a fast flicker is better than a slow, smoother transition. For non-extreme solutions, maybe we can:
|
I ran an experiment where I commented out the thumbnail code and added In the original code, on the GS5 over 3 runs, to show the first frame of the SearchFragment, it takes:
This confirms fixing this issue will be a big improvement. (Note: this timing does not represent the total duration to show the search screen, just the first frame, but it still good for comparison) |
By changing this as suggested we will lose the cross fade animation we have. This is not possible to mimic without capturing the engine view as we cannot animate the GV layer. @vesta0 what are your thoughts on losing this animation in favor of a performance win? Current Cross FadeProposed No Cross Fade |
I like the animation but performance takes priority. Thanks @sblatz |
Goodbye, sweet summer child.
Goodbye, sweet summer child.
Goodbye, sweet summer child.
This is a breakout to fix an issue found in the investigations in #8795
STR:
Expected:
Search screen appears quickly
Actual:
Long pause before search screen appears. Partial cause, from my perf investigation #8795 (comment):
We shouldn't block the UI from appearing on a background operation, especially one that doesn't update information on the subsequent screen.
┆Issue is synchronized with this Jira Task
The text was updated successfully, but these errors were encountered: