Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Bug] Pressing back on the search screen intermittently returns to homescreen instead of browser when opened from tab #11866

Closed
mcomella opened this issue Jun 23, 2020 · 2 comments
Closed

[Bug] Pressing back on the search screen intermittently returns to homescreen instead of browser when opened from tab #11866

mcomella opened this issue Jun 23, 2020 · 2 comments
Assignees
@ekager
Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified Feature:Search
Projects
Fenix Sprint Kanban

Comments

@mcomella
Copy link
Contributor

mcomella commented Jun 23, 2020 •
edited by data-sync-user

Steps to reproduce

  • Open a tab
  • Click URL bar to open search screen
  • Press back

Expected behavior

Return to open tab

Actual behavior

Usually return to open tab but occassionally return to homescreen. This happens fairly infrequently on my P2 but happens fairly frequently on a GS5.

I can reproduce this behavior 100% if I instead:

  • Open a tab
  • click url bar
  • swipe to dismiss soft keyboard
  • press back

Device information

  • Android device: P2, GS5
  • Fenix version: Nightly 200623

Given actual behavior notes above, perhaps we're conditionally doing pressBack(); pressBack(); (or something like that) and it sometimes doesn't work correctly due to race conditions.

┆Issue is synchronized with this Jira Task
@mcomella mcomella added 🐞 bug Crashes, Something isn't working, .. Feature:Search labels Jun 23, 2020
@github-actions github-actions bot added the needs:triage Issue needs triage label Jun 23, 2020
@ekager
Copy link
Contributor

ekager commented Jun 23, 2020

Looks like because SearchFragment handles back navigation in onEditingCanceled, the onBackPressed call is getting passed to BrowserFragment and SessionFeature is consuming the back press (taking us home). I'll try to get a fix in ASAP.

@ekager ekager self-assigned this Jun 23, 2020
@ekager ekager removed the needs:triage Issue needs triage label Jun 23, 2020
@ekager ekager added this to Bugs before Release in Fenix Sprint Kanban Jun 23, 2020
ekager added a commit to ekager/fenix that referenced this issue Jun 24, 2020
@ekager
For mozilla-mobile#11866 - Update back press logic for SearchFragment
728c9f3
@sv-ohorvath sv-ohorvath mentioned this issue Jun 24, 2020
Closed
ekager added a commit to ekager/fenix that referenced this issue Jun 24, 2020
@ekager
For mozilla-mobile#11866 - Update back press logic for SearchFragment
94e1b4f
ekager added a commit to ekager/fenix that referenced this issue Jun 24, 2020
@ekager
For mozilla-mobile#11866 - Update back press logic for SearchFragment
cf9cc30
@mcomella mcomella mentioned this issue Jun 24, 2020
Merged
4 tasks
ekager added a commit to ekager/fenix that referenced this issue Jun 24, 2020
@ekager
For mozilla-mobile#11866 - Update back press logic for SearchFragment
9f4b1f3
@ekager ekager mentioned this issue Jun 25, 2020
Closed
ekager added a commit that referenced this issue Jun 25, 2020
@ekager
For #11866 - Update back press logic for SearchFragment
c77ddd8
@ekager ekager added the eng:qa:needed QA Needed label Jun 25, 2020
This was referenced Jun 25, 2020
Closed
Closed
boek pushed a commit to boek/fenix that referenced this issue Jun 25, 2020
@ekager @boek
For mozilla-mobile#11866 - Update back press logic for SearchFragment
f87d7b8
@liuche liuche mentioned this issue Jun 27, 2020
Closed
12 tasks
@sv-ohorvath
Copy link
Contributor

Verified as fixed on the latest Nightly and Beta 78.0.1-beta1 with a Nexus 9 (Android 7.1.1).

Fenix Sprint Kanban automation moved this from Bugs before Release to Sprint 20.11 Done Jun 29, 2020
@sv-ohorvath sv-ohorvath added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Jun 29, 2020
@data-sync-user data-sync-user changed the title [Bug] Pressing back on the search screen intermittently returns to homescreen instead of browser when opened from tab FNX2-16695 ⁃ [Bug] Pressing back on the search screen intermittently returns to homescreen instead of browser when opened from tab Aug 1, 2020
@data-sync-user data-sync-user changed the title FNX2-16695 ⁃ [Bug] Pressing back on the search screen intermittently returns to homescreen instead of browser when opened from tab FNX3-14968 ⁃ [Bug] Pressing back on the search screen intermittently returns to homescreen instead of browser when opened from tab Aug 11, 2020
Fenix Sprint Kanban automation moved this from Sprint 20.11 Done to In Progress Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX3-14968 ⁃ [Bug] Pressing back on the search screen intermittently returns to homescreen instead of browser when opened from tab FNX-12860 ⁃ [Bug] Pressing back on the search screen intermittently returns to homescreen instead of browser when opened from tab Aug 11, 2020
Fenix Sprint Kanban automation moved this from In Progress to Sprint 20.11 Done Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX-12860 ⁃ [Bug] Pressing back on the search screen intermittently returns to homescreen instead of browser when opened from tab FNX2-16695 ⁃ [Bug] Pressing back on the search screen intermittently returns to homescreen instead of browser when opened from tab Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX2-16695 ⁃ [Bug] Pressing back on the search screen intermittently returns to homescreen instead of browser when opened from tab [Bug] Pressing back on the search screen intermittently returns to homescreen instead of browser when opened from tab May 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ekager ekager

Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified Feature:Search
Projects
Fenix Sprint Kanban
  
Sprint 20.11 Done
Milestone
No milestone
Development

No branches or pull requests
4 participants
@mcomella @sv-ohorvath @ekager @data-sync-user