Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Hide the keyboard when scrolling through suggestions #1211

Closed
Verdi opened this issue Mar 27, 2019 · 6 comments
Closed

Hide the keyboard when scrolling through suggestions #1211

Verdi opened this issue Mar 27, 2019 · 6 comments

Comments

@Verdi
Copy link

Verdi commented Mar 27, 2019

Steps to reproduce

  1. Enter a search term
  2. Scroll the list of suggestions

Expected behavior

The keyboard should hide since I no longer need and it and it will let see more of the list.

Actual behavior

The keyboard stays up and I can only see 4 suggestions at a time.

Device information

  • Android device: Nokia 3.1
  • Fenix version: 1.0.1913

┆Issue is synchronized with this Jira Task

@lime124 lime124 added the needs:UX-feedback Needs UX Feedback label Mar 28, 2019
@lime124 lime124 mentioned this issue Mar 28, 2019
@vesta0 vesta0 added this to the MVP Backlog milestone Apr 1, 2019
@vesta0 vesta0 added P2 Upcoming release Feature:Search and removed Feature:Search needs:UX-feedback Needs UX Feedback labels Apr 1, 2019
@Verdi Verdi added the Search label Apr 11, 2019
@kbrosnan kbrosnan removed the Search label Apr 27, 2019
@buttercookie42
Copy link

buttercookie42 commented May 17, 2019

This is even worse in landscape - I can only see half a suggestion at most. And pressing back dismisses the whole search screen instead of merely the keyboard, even though the back arrow changes to the down pointing arrow that normally seems to indicate that pressing back will only dismiss the keyboard.

Edit:

I can only see half a suggestion at most

Which also means that even if scrolling dismissed the keyboard, it would still be a pain to scroll in the first place while in landscape mode.

ekager added a commit to ekager/fenix that referenced this issue Jun 3, 2019
colintheshots pushed a commit that referenced this issue Jun 4, 2019
* Closes #1618 - Add fade to awesome bar list instead of shadow

* For #1211 - Hide keyboard on fling suggestions list
ekager added a commit to ekager/fenix that referenced this issue Jun 25, 2019
@ekager
Copy link
Contributor

ekager commented Jun 25, 2019

I had previously completed this, but there's a bug in ConstraintLayout causing weirdness. See #3668 . So I will need to revert this change and revisit this feature later.

ekager added a commit that referenced this issue Jun 26, 2019
ekager added a commit to ekager/fenix that referenced this issue Jun 26, 2019
@ekager ekager closed this as completed Jun 26, 2019
@ekager
Copy link
Contributor

ekager commented Jul 16, 2019

I'm reopening this now. This was removed when implementing #3985. I think this was also causing weird behavior like #3587 because of how we are overriding the back button in Search. We should look into those issues before readding this feature

@sblatz
Copy link
Contributor

sblatz commented Aug 8, 2019

Let's make sure this on @vesta0's roadmap if it's really a P2.

@vesta0 vesta0 added the E8 Estimation Point: about 8 days label Oct 2, 2019
@liuche
Copy link
Contributor

liuche commented Oct 2, 2019

There's a dependency on this where if we do this functionality, either:

  • we would require 2 back-presses to hide the keyboard and then go back in the backstack
  • OR we'd have make some changes to the keyboard hiding behavior in AC (which requires making changes to existing feature) and figure out how to provide this Android keyboard behavior

@mcarare mcarare self-assigned this Nov 6, 2019
mcarare added a commit to mcarare/fenix that referenced this issue Nov 6, 2019
@sblatz sblatz added the eng:qa:needed QA Needed label Nov 8, 2019
@project-bot project-bot bot moved this from Prioritized Feature Backlog to Ready for QA in Fenix Sprint Kanban Nov 8, 2019
@sblatz sblatz modified the milestones: v3.0, v3.1 Nov 8, 2019
@sv-ohorvath
Copy link
Contributor

I think this was also causing weird behavior like #3587 because of how we are overriding the back button in Search. We should look into those issues before readding this feature

Emily was right here.
Current behavior: The keyboard hides while scrolling the suggestions. You need to press back to exit the search mode. If you were on the homescreen when you started the search, this will close the app. If you were on a webpage, it will navigate back one page/close the tab. Logged: #6625

This is verified as fixed on Nightly 11/15.

Fenix Q4 Feature Backlog automation moved this from Could to Done! Nov 15, 2019
@project-bot project-bot bot moved this from Ready for QA to Sprint 11.2 Done in Fenix Sprint Kanban Nov 15, 2019
@sv-ohorvath sv-ohorvath added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Nov 15, 2019
@project-bot project-bot bot moved this from Sprint 11.2 Done to Sprint Backlog in Fenix Sprint Kanban Nov 15, 2019
@project-bot project-bot bot moved this from Sprint Backlog to Sprint 11.2 Done in Fenix Sprint Kanban Nov 15, 2019
@data-sync-user data-sync-user changed the title Hide the keyboard when scrolling through suggestions FNX2-16807 ⁃ Hide the keyboard when scrolling through suggestions Aug 2, 2020
@data-sync-user data-sync-user changed the title FNX2-16807 ⁃ Hide the keyboard when scrolling through suggestions FNX3-15143 ⁃ Hide the keyboard when scrolling through suggestions Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX3-15143 ⁃ Hide the keyboard when scrolling through suggestions FNX-449 ⁃ Hide the keyboard when scrolling through suggestions Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX-449 ⁃ Hide the keyboard when scrolling through suggestions FNX2-16807 ⁃ Hide the keyboard when scrolling through suggestions Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX2-16807 ⁃ Hide the keyboard when scrolling through suggestions Hide the keyboard when scrolling through suggestions May 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
No open projects
Development

No branches or pull requests