Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Bug] I feel stuck at the "Search with" screen #6666

Closed
6 of 10 tasks
darkwing opened this issue Nov 18, 2019 · 13 comments
Closed
6 of 10 tasks

[Bug] I feel stuck at the "Search with" screen #6666

darkwing opened this issue Nov 18, 2019 · 13 comments
Assignees
Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified eng:ready Ready for engineering Feature:Search

Comments

@darkwing
Copy link
Contributor

darkwing commented Nov 18, 2019

Screenshot_20191118-094458

Steps to reproduce

  1. Tap on the search bar, see search screen pop up
  2. Tap anywhere on the screen that isn't a search source, see keyboard disappear
  3. ....now what?

What if I want to go back to my opened tabs? It took me a while to figure out that I was meant to swipe to get back to opened tabs screen, and even then it seems as though I wasn't starting my swipe close enough to the right edge of the phone.

Could we add a UI element to hide this screen? I'm not sure how/if this could be improved.

Device information

  • Android device: Pixel 4 XL
  • Fenix version: ?

UX

Design Work

  • Request for Comments from UX team
  • Usability testing if a new pattern or potentially confusing UI Not required – putting a Back button on the top-left corner of the screen follows established Android System convention
  • Request for Comments from Fenix team and/or A/C, GV, Sync, etc as needed
  • Interaction details included
  • Accessibility - is this a review by someone, just keeping it in mind?
  • For existing UI changes, deltas are highlighted
  • Strings/content reviewed and approved No string required, we’re merely adding a button
    • Are they too long for the component in other locales

Deliverable

  • Assets uploaded to Google Drive No asset required, there’s already a Back icon we can reuse.
  • Links to deliverables (spec, assets) posted in comment 0

Deliverable Links

UI Change Deltas

Current

Proposed

We decided to solve this problem on the search screen by adding a Back button to the left of the address bar.

┆Issue is synchronized with this Jira Task

@darkwing darkwing added the 🐞 bug Crashes, Something isn't working, .. label Nov 18, 2019
@NotWoods
Copy link
Contributor

On older devices Android always displays a back button, but we might want to tweak the UX to better work with gesture navigation in Android 10.

@brampitoyo
Copy link

@darkwing @NotWoods You’re right. On Android <10, this isn’t a problem because the back button is persistent, so users can always dismiss the search bar and return to the start screen.

Android 10 turns back into a gesture. No more button.

Although it’s tempting to solve the “now what” problem by re-introducing the back button somewhere onscreen, I wonder if we should think about keeping the keyboard persistently up (ie. not dismissable)?

With a persistent keyboard, users may understand better that dismissing is accomplished either by tapping the software/hardware Back button, or swiping back (if running Android 10).

Further, when we outline the behaviour, we see a new issue crop up. See number 3 below:

  1. Think: “I want to search for something”
    Action: Tap search bar
    App response: Show search modal

  2. Think: “I want to use another search engine”
    Action: Scroll down the screen
    Expected response: Keyboard stays up – app lets me see other search engines
    Actual response: Keyboard disappears… now what? ← This is the issue @darkwing brought up
    App response: dismiss keyboard, show list of search engines

  3. Think: “Never mind. Just go back.”
    Action: Tap back button or swipe (if on Android 10)
    Expected response: Go back to Firefox Preview start screen ← This is a new issue
    Actual response: Firefox Preview exits to the phone home screen

@brampitoyo
Copy link

I’ve outlined a potential solution to this issue above in #6666 (comment):

keeping the keyboard persistently up (ie. not dismissable)

With a persistent keyboard, users may understand better that dismissing is accomplished either by tapping the software/hardware Back button, or swiping back (if running Android 10).

@darkwing @NotWoods do we think that this solution sounds reasonable to try out, or is there a deeper problem that needs to be solved?

@brampitoyo
Copy link

@darkwing @NotWoods I also want to post another solution we can consider, which is to show a dedicated button for “⬅️ Back” or “Cancel”:

Keep in mind that these buttons will be more useful in Android 10 where users may not have a hardware/software back button. If there’s a back button provided by the OS, we won’t need to show them.

Any thoughts?

@darkwing
Copy link
Contributor Author

I like a back button, but I'm also an ancient 36 years old :)

@brampitoyo
Copy link

Hi @darkwing, since the problem seems to stem from an undismissable search screen, we think we can help solve it using these behaviours:

  • On the search screen, disable the ability to dismiss the keyboard when scrolling/tapping anywhere else outside of it. The keyboard will stay up – always – unless it’s dismissed using a System-native way.
  • Respect the System-native way to dismiss the keyboard, using the ⌄ or ◁ buttons underneath it.
  • When the keyboard is dismissed, take it to mean that the user wants to exit out of the search screen, and return to the previous page.

Hopefully this solves the “I’m stuck” problem on the search screen, by always showing users a clear, non-dismissible exit path? What do you think?

(I think that putting an extra back button to the left of the search bar isn’t a bad idea. I’m just cautious of putting “yet-another-thing” in our UI if it’s not absolutely necessary – but also understand that there’s something to be said about being super clear about indicating “here’s where you exit”.)

@brampitoyo
Copy link

@darkwing @NotWoods A little update on this situation. Hiding the keyboard was intentional!

Quoting @Verdi #1211:

  • Enter a search term
  • Scroll the list of suggestions

Expected behavior
The keyboard should hide since I no longer need and it and it will let see more of the list.

It seems as if the only way to resolve this problem is not by keeping the keyboard always up, but by putting an extra back button in the UI, only on devices with no dedicated Back button.

@NotWoods Is there a way for us to only target these devices? For example, MIUI, Android 10. Note that certain variants of Android 10, like Samsung One UI, has a Back button.

@NotWoods
Copy link
Contributor

NotWoods commented Dec 15, 2019

We might be able to target just devices with gesture navigation turned on. Personally I think it would be fine to always show a back button, as Slack does on its search page:

Slack android search page

@brampitoyo
Copy link

@NotWoods I will run this idea through our UX team, and get back to you.

@brampitoyo
Copy link

@NotWoods @darkwing A short, positive update to say that we’ve reached a consensus of permanently showing the back button!

I will of course post the specs in comment 0 later. This is just a confirmation message to formalise our decision.

@brampitoyo
Copy link

@NotWoods @darkwing I’ve updated comment 0 with specs, and have also highlighted changes made in the search screen UI.

@brampitoyo brampitoyo removed their assignment Dec 18, 2019
@brampitoyo brampitoyo added eng:ready Ready for engineering and removed needs:UX-feedback Needs UX Feedback labels Dec 18, 2019
@sblatz sblatz self-assigned this Dec 19, 2019
sblatz added a commit to sblatz/fenix that referenced this issue Dec 23, 2019
sblatz added a commit to sblatz/fenix that referenced this issue Dec 23, 2019
sblatz added a commit to sblatz/fenix that referenced this issue Dec 23, 2019
@sblatz sblatz added the eng:qa:needed QA Needed label Dec 26, 2019
@sblatz
Copy link
Contributor

sblatz commented Dec 26, 2019

For QA: please verify that the back button now appears and functions properly :)

@sblatz sblatz added eng:qa:needed QA Needed and removed eng:qa:needed QA Needed labels Dec 26, 2019
@lobontiumira
Copy link

lobontiumira commented Dec 27, 2019

Hi all,
Verified that the back button is displayed and functions on the latest Nightly build from 12/27 (#13610605) with Nexus 5 (Android 6.0.1), Nexus 6P (Android 8.1), OnePlus 5T (Android 9), and Google Pixel (Android Q).
However, after tapping on the back arrow, there is a flickery transition, for which I will file a new issue.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified eng:ready Ready for engineering Feature:Search
Projects
None yet
Development

No branches or pull requests

5 participants