Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Bug]Tabs counter isn't updated after deleting the Open Tabs browsing data #12126

Closed
AndiAJ opened this issue Jun 30, 2020 · 3 comments · Fixed by #12307
Closed

[Bug]Tabs counter isn't updated after deleting the Open Tabs browsing data #12126

AndiAJ opened this issue Jun 30, 2020 · 3 comments · Fixed by #12307
Assignees
@BMEduard
Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified Feature:Tabs S1 Blocks development/testing, may impact more than 25% of users, causes data loss, potential chemspill
Projects
Hershey's 🍫

Comments

@AndiAJ
Copy link
Collaborator

AndiAJ commented Jun 30, 2020 •
edited by data-sync-user
Loading

Prerequisites

Have a couple of open tabs
"Open Tabs" should be the only checked option in Delete browsing data

Steps to reproduce

  1. Navigate to Settings → Delete browsing data
  2. Proceed with the deletion
  3. Check the Tabs counter
  4. Check the Open Tabs in the Delete browsing data section

Expected behavior

Tabs counter should display 0 open tabs
The open tabs count in in the Delete browsing data section should be 0 as well

Actual behavior

Tabs counter isn't updated, displays the previous number of open tabs
The Open Tabs count in the Delete browsing data section is 0

Device information

  • Android device: OnePlus A3 (Android 6.0.1)
  • Fenix version:
    •Nightly Build 200629 from 6/30
    •Fenix 79.0.1-beta.1 from 6/30

Notes

❗ Not reproducible using the "Delete browsing data on quit"

► Video
20200630-142023

┆Issue is synchronized with this Jira Task
@AndiAJ AndiAJ added 🐞 bug Crashes, Something isn't working, .. Feature:Tabs S1 Blocks development/testing, may impact more than 25% of users, causes data loss, potential chemspill labels Jun 30, 2020
@github-actions github-actions bot added the needs:triage Issue needs triage label Jun 30, 2020
@sflorean
Copy link
Contributor

sflorean commented Jul 1, 2020

I was able to reproduce this also, following the steps:

  1. Open 3 tabs.
  2. Go to about:crashcontent in one tab.
  3. Choose "close tab".

Expected result: the tab counter is 3.
Actuals result: the tab counter isn't updated.

@mcarare mcarare added this to Backlog in Hershey's 🍫 Jul 2, 2020
@BMEduard BMEduard self-assigned this Jul 6, 2020
BMEduard pushed a commit to BMEduard/fenix that referenced this issue Jul 6, 2020
For issue mozilla-mobile#12126 - Tab counter consumeFrom update
8a6f8bc 
Reverted the consumeFrom method inside HomeFragment for the tab counter
@BMEduard BMEduard linked a pull request Jul 6, 2020 that will close this issue
For issue #12126 - Tab counter consumeFrom update #12307
Merged
4 tasks
BMEduard pushed a commit to BMEduard/fenix that referenced this issue Jul 7, 2020
For issue mozilla-mobile#12126 - Tab counter consumeFrom update
e23b951 
Added a direct call to the updateTabCounter method to account for changes made to the BrowserState while the tabCounter view is not visible.
BMEduard pushed a commit to BMEduard/fenix that referenced this issue Jul 7, 2020
For issue mozilla-mobile#12126 - Tab counter consumeFrom update
cd33133 
Added a direct call to the updateTabCounter method to account for changes made to the BrowserState while the tabCounter view is not visible.
@BMEduard BMEduard mentioned this issue Jul 7, 2020
Merged
4 tasks
Hershey's 🍫 automation moved this from Backlog to QA Review Jul 7, 2020
ekager pushed a commit that referenced this issue Jul 7, 2020
@ekager
For issue #12126 - Tab counter consumeFrom update
eeb8719 
Added a direct call to the updateTabCounter method to account for changes made to the BrowserState while the tabCounter view is not visible.
@AndiAJ
Copy link
Collaborator Author

AndiAJ commented Jul 8, 2020

Hi, verified as fixed on the latest Nightly Build 200708 from 7/8 using the following devices:
• Google Pixel 3a (Android 10)
• Huawei Mate 20 Lite (Android 9)
• OnePlus A3 (Android 6.0.1)

► Video
20200708-105536

@AndiAJ AndiAJ added the eng:qa:verified QA Verified label Jul 8, 2020
@abodea abodea removed the needs:triage Issue needs triage label Jul 8, 2020
@abodea abodea moved this from QA Review to Done in Hershey's 🍫 Jul 8, 2020
@AndiAJ AndiAJ mentioned this issue Jul 10, 2020
Closed
@AndiAJ
Copy link
Collaborator Author

AndiAJ commented Jul 14, 2020

Reproducible on 79.0.0-beta.6 from 7/14 using a OnePlus A3 (Android 6.0.1)

► Video
20200714-113130

@BMEduard BMEduard mentioned this issue Jul 15, 2020
Closed
@liuche liuche mentioned this issue Jul 20, 2020
Closed
9 tasks
@data-sync-user data-sync-user changed the title [Bug]Tabs counter isn't updated after deleting the Open Tabs browsing data FNX3-15157 ⁃ [Bug]Tabs counter isn't updated after deleting the Open Tabs browsing data Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX3-15157 ⁃ [Bug]Tabs counter isn't updated after deleting the Open Tabs browsing data FNX-13155 ⁃ [Bug]Tabs counter isn't updated after deleting the Open Tabs browsing data Aug 11, 2020
Hershey's 🍫 automation moved this from Done to QA Review Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX-13155 ⁃ [Bug]Tabs counter isn't updated after deleting the Open Tabs browsing data FNX2-12978 ⁃ [Bug]Tabs counter isn't updated after deleting the Open Tabs browsing data Aug 11, 2020
@Mugurell Mugurell moved this from QA Review to Done in Hershey's 🍫 Aug 17, 2020
@data-sync-user data-sync-user changed the title FNX2-12978 ⁃ [Bug]Tabs counter isn't updated after deleting the Open Tabs browsing data [Bug]Tabs counter isn't updated after deleting the Open Tabs browsing data May 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@BMEduard BMEduard

Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified Feature:Tabs S1 Blocks development/testing, may impact more than 25% of users, causes data loss, potential chemspill
Projects
No open projects
Hershey's 🍫
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

For issue #12126 - Tab counter consumeFrom update BMEduard/fenix
6 participants
@NotWoods @BMEduard @abodea @AndiAJ @data-sync-user @sflorean