Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Bug]Closing the private tabs from the notification breaks the value of the normal browsing tabs counter #12129

Closed
AndiAJ opened this issue Jun 30, 2020 · 2 comments · Fixed by #12307
Closed

[Bug]Closing the private tabs from the notification breaks the value of the normal browsing tabs counter #12129

AndiAJ opened this issue Jun 30, 2020 · 2 comments · Fixed by #12307
Assignees
@BMEduard
Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified Feature:PrivateBrowsing Feature:Tabs needs:triage Issue needs triage S1 Blocks development/testing, may impact more than 25% of users, causes data loss, potential chemspill

Comments

@AndiAJ
Copy link
Collaborator

AndiAJ commented Jun 30, 2020 •
edited by data-sync-user
Loading

Prerequisites

Have a couple of open tabs in normal browsing

Steps to reproduce

  1. Open a new private tab
  2. Open the Tabs Tray
  3. Close the private tabs using the the system notification
  4. Check the Normal browsing tabs counter value

Expected behavior

The tabs counter should display the number of previously opened normal browsing tabs

Actual behavior

Displays 0 normal browsing open tabs

Device information

  • Android device: OnePlus A3 (Android 6.0.1)
  • Fenix version:
    • Nightly Build 200629 from 6/30
    • Fenix 79.0.1-beta.1 from 6/30

Notes

►Video
20200630-164808

┆Issue is synchronized with this Jira Task
@AndiAJ AndiAJ added 🐞 bug Crashes, Something isn't working, .. Feature:PrivateBrowsing Feature:Tabs S1 Blocks development/testing, may impact more than 25% of users, causes data loss, potential chemspill labels Jun 30, 2020
@github-actions github-actions bot added the needs:triage Issue needs triage label Jun 30, 2020
@BMEduard BMEduard self-assigned this Jul 14, 2020
@BMEduard BMEduard linked a pull request Jul 15, 2020 that will close this issue
For issue #12126 - Tab counter consumeFrom update #12307
Merged
4 tasks
@BMEduard
Copy link
Contributor

After investigating, this issue was also fixed by PR #12307 . and it had the same underlying problem as #12126 .

@BMEduard BMEduard added the eng:qa:needed QA Needed label Jul 15, 2020
@AndiAJ
Copy link
Collaborator Author

AndiAJ commented Jul 16, 2020

Hi, verified as fixed on the latest Nightly Build 200716 from 7/16 using the following devices:
• Google Pixel 3a (Android 10)
• Huawei Mate 20 Lite (Android 9)
• OnePlus A3 (Android 6.0.1)

►Video
20200716-095353

@AndiAJ AndiAJ closed this as completed Jul 16, 2020
@AndiAJ AndiAJ added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Jul 16, 2020
@data-sync-user data-sync-user changed the title [Bug]Closing the private tabs from the notification breaks the value of the normal browsing tabs counter FNX3-15159 ⁃ [Bug]Closing the private tabs from the notification breaks the value of the normal browsing tabs counter Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX3-15159 ⁃ [Bug]Closing the private tabs from the notification breaks the value of the normal browsing tabs counter FNX-13158 ⁃ [Bug]Closing the private tabs from the notification breaks the value of the normal browsing tabs counter Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX-13158 ⁃ [Bug]Closing the private tabs from the notification breaks the value of the normal browsing tabs counter FNX2-12976 ⁃ [Bug]Closing the private tabs from the notification breaks the value of the normal browsing tabs counter Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX2-12976 ⁃ [Bug]Closing the private tabs from the notification breaks the value of the normal browsing tabs counter [Bug]Closing the private tabs from the notification breaks the value of the normal browsing tabs counter May 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@BMEduard BMEduard

Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified Feature:PrivateBrowsing Feature:Tabs needs:triage Issue needs triage S1 Blocks development/testing, may impact more than 25% of users, causes data loss, potential chemspill
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

For issue #12126 - Tab counter consumeFrom update BMEduard/fenix
4 participants
@NotWoods @BMEduard @AndiAJ @data-sync-user