Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Voice input for Search #1216

Closed
4 tasks
vesta0 opened this issue Mar 27, 2019 · 34 comments
Closed
4 tasks

Voice input for Search #1216

vesta0 opened this issue Mar 27, 2019 · 34 comments

Comments

@vesta0
Copy link
Collaborator

vesta0 commented Mar 27, 2019

Feature Goal

  • Provide users with a clear visible option to voice search
  • Learn about whether our users would like us to invest more in Voice features

User Story

As a user, I want to be able to do a quick voice search, so I can search faster.

Acceptance Criteria

  • I can initiate a voice search from the search bar
  • I can turn this option off when I go to the Accessibility menu in settings
  • The first time user taps on the mic icon, they should see a permission prompt and agree to voice search
  • Telemetry Ticket [Telemetry] Voice Search #10465

Note: This is already possible today, user can tap on the Android microphone icon on their keyboard and voice search, but since this request comes up a lot by users, we can only assume that it's possibly hidden on some phones and/or users are used to seeing it in the search bar.

Fenix:
ScreenshotUNITO-UNDERSCORE!20200507-171812!

Fennec:
ScreenshotUNITO-UNDERSCORE!20200507-171805~2!

┆Issue is synchronized with this Jira Task

@vesta0 vesta0 added this to the Milestone 4 Backlog milestone Mar 27, 2019
@vesta0 vesta0 added Epic needs:ac Needs Android Component Work needs:product needs:UX-feedback Needs UX Feedback P1 Current sprint labels Mar 27, 2019
@lime124
Copy link
Collaborator

lime124 commented Mar 29, 2019

Hey @vesta0 What is the specific question to UX? as I understand it, we're going to be using all native stuff so there isn't anything for us to provide.

@vesta0 vesta0 self-assigned this Apr 1, 2019
@vesta0 vesta0 removed needs:UX-feedback Needs UX Feedback needs:product UX needs:ac Needs Android Component Work labels Apr 2, 2019
@vesta0
Copy link
Collaborator Author

vesta0 commented Apr 2, 2019

Confirmed with the team that this already works with the native android voice search. We won't build anything extra for MVP.

@vesta0 vesta0 closed this as completed Apr 2, 2019
@ghost ghost removed the P1 Current sprint label Apr 2, 2019
@vesta0 vesta0 reopened this Sep 25, 2019
@vesta0 vesta0 removed this from the MVP Backlog milestone Sep 25, 2019
@vesta0 vesta0 added this to To be Triaged in Fenix Sprint Kanban via automation Sep 25, 2019
@vesta0 vesta0 added the should label Sep 25, 2019
@vesta0 vesta0 added this to Should in Fenix Q4 Feature Backlog Sep 25, 2019
@FruityWelsh
Copy link

FruityWelsh commented Sep 27, 2019

Is there overlap between the voicefill project and this issue?

@NotWoods
Copy link
Contributor

NotWoods commented Sep 27, 2019

We could potentially use Mozilla SpeakToMe for voice search. This service is used for Voice Fill and WebThings Gateway. (I think it can be configured to use Common Voice as a dataset?)

SpeakToMe has a JS API that calls the server we can use as a template to figure out how to structure REST calls.

@sblatz
Copy link
Contributor

sblatz commented Oct 1, 2019

I think this would not be a ton of engineering effort for us since we're already using this for the search widget :)

@liuche
Copy link
Contributor

liuche commented Oct 1, 2019

Some other concerns:

  • Will users expect to be notified about using Google voice search, rather than their default search engine?

@vesta0 vesta0 removed this from To be Triaged in Fenix Sprint Kanban Oct 1, 2019
@sblatz
Copy link
Contributor

sblatz commented May 21, 2020

The only thing missing from what we discussed is the toggle in the accessibility settings.

I added it to the search settings screen.
@brampitoyo is this an okay place for this preference to live? I figured since it's directly related to search it makes sense here, but please chime in with your thoughts!

image

@yoasif
Copy link
Contributor

yoasif commented May 21, 2020

@sblatz I think it is fine either way - I just wanted it available. Thanks for clarifying!

@AndiAJ
Copy link
Collaborator

AndiAJ commented May 22, 2020

Hi, I've just checked this matter on the latest Nightly Build 200522 from 5/22 using the following devices:
• Google Pixel 3a (Android 10)
• Huawei Mate 20 Lite (Android 9)
• OnePlus A3 (Android 6.0.1

✔️ I can initiate a voice search from the search bar and widget
✔️ I can turn this option off when I go to the Accessibility menu in settings
❓ The first time user taps on the mic icon, they should see a permission prompt - You have to disable the microphone permission for Google and only afterwards the prompt gets displayed

► Video
20200522-115354

@sblatz - Not sure about the prompt behavior, could you please review and advise?
Everything else works properly, great job! ☺️

I'll remove the QA needed label until further notice.

@AndiAJ AndiAJ removed the eng:qa:needed QA Needed label May 22, 2020
@project-bot project-bot bot moved this from Ready for QA to Sprint in Fenix Sprint Kanban May 22, 2020
@sblatz
Copy link
Contributor

sblatz commented May 22, 2020

I believe the prompt is working as expected here. It should have the same behavior as our search widget in this regard, so I will close this :)

@sblatz sblatz closed this as completed May 22, 2020
@sblatz sblatz added this to 🏁 Done in A-C: Android Components Sprint Planning via automation May 22, 2020
Fenix Sprint Kanban automation moved this from Sprint to Sprint 20.9 Done May 22, 2020
@sblatz sblatz moved this from Sprint 20.9 Done to Sprint 20.10 Done in Fenix Sprint Kanban May 22, 2020
@liuche liuche added the E5 Estimation Point: about 5 days label May 22, 2020
@AndiAJ AndiAJ added the eng:qa:verified QA Verified label May 27, 2020
sblatz added a commit to sblatz/fenix that referenced this issue May 29, 2020
sblatz added a commit to sblatz/fenix that referenced this issue May 29, 2020
sblatz added a commit to sblatz/fenix that referenced this issue May 29, 2020
sblatz added a commit to sblatz/fenix that referenced this issue May 29, 2020
sblatz added a commit to sblatz/fenix that referenced this issue Jun 1, 2020
sblatz added a commit to sblatz/fenix that referenced this issue Jun 1, 2020
@liuche liuche mentioned this issue Jun 10, 2020
29 tasks
@data-sync-user data-sync-user changed the title Voice input for Search FNX2-16818 ⁃ Voice input for Search Aug 2, 2020
@data-sync-user data-sync-user changed the title FNX2-16818 ⁃ Voice input for Search FNX3-15179 ⁃ Voice input for Search Aug 11, 2020
Fenix Sprint Kanban automation moved this from Sprint 20.10 Done to In Progress Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX3-15179 ⁃ Voice input for Search FNX-450 ⁃ Voice input for Search Aug 11, 2020
Fenix Sprint Kanban automation moved this from In Progress to Sprint 20.11 Done Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX-450 ⁃ Voice input for Search FNX2-16818 ⁃ Voice input for Search Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX2-16818 ⁃ Voice input for Search Voice input for Search May 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
E5 Estimation Point: about 5 days eng:qa:verified QA Verified Feature:Search Feature:Voice needs:strings Needs strings needs:UX-feedback Needs UX Feedback
Projects
Fenix Sprint Kanban
  
Sprint 20.11 Done
Development

No branches or pull requests