Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Bug] [Synced tabs] The list of opened tabs are not displayed after restarting the app and accessing Synced tabs #12195

Closed
ebalazs-sv opened this issue Jul 2, 2020 · 5 comments
Closed

[Bug] [Synced tabs] The list of opened tabs are not displayed after restarting the app and accessing Synced tabs #12195

ebalazs-sv opened this issue Jul 2, 2020 · 5 comments
Assignees
@BranescuMihai
Labels
🐞 bug Crashes, Something isn't working, .. E3 Estimation Point: average, 2 - 3 days eng:qa:verified QA Verified Feature:SyncTabs Sync tabs S2 Major Functionality/product severely impaired and a satisfactory workaround doesn't exist
Projects
Hershey's 🍫 A-C: Meta: Sync Tabs

Comments

@ebalazs-sv
Copy link

ebalazs-sv commented Jul 2, 2020 •
edited by data-sync-user
Loading

Preconditions:

Sign in with valid credentials on one or two mobile devices and on desktop.
Open several tabs on each device.
Trigger sync.

Steps to reproduce

  1. Launch Fenix;
  2. Remove Fenix from Recent apps;
  3. Launch Fenix and from the three-dot menu go to Synced tabs;
  4. Observe the Synced tabs information.
    1. Expected behavior
      The Synced tabs page opens displaying the connected devices and a list with the opened tabs on each device.
    2. Actual behavior
      "Connect with a Firefox Account." text is displayed. Then a second text is displayed: "You don't have any tabs open in Firefox on your other devices."
      Going to Settings, the logged in email address is not displayed, only "Firefox Account".
    3. Notes:
      This is not reproducible after restarting Fenix and going to Settings first.
      20200702UNITO-UNDERSCORE!142426!

Device information

  • Android device: Motorola Moto G6 (Android 8), Huawei P20 lite (Android 9), Samsung Galaxy Tab S6 (Android 9);
  • Fenix version: Fenix Beta 79.0.0-beta.4 GV 79 from 7/1.

┆Issue is synchronized with this Jira Task
@ebalazs-sv ebalazs-sv added the 🐞 bug Crashes, Something isn't working, .. label Jul 2, 2020
@github-actions github-actions bot added the needs:triage Issue needs triage label Jul 2, 2020
@ebalazs-sv ebalazs-sv added Feature:SyncTabs Sync tabs S2 Major Functionality/product severely impaired and a satisfactory workaround doesn't exist and removed needs:triage Issue needs triage labels Jul 2, 2020
@BranescuMihai BranescuMihai added this to Backlog in Hershey's 🍫 Jul 2, 2020
@liuche liuche moved this from Backlog to Sprint in Hershey's 🍫 Jul 2, 2020
@BranescuMihai BranescuMihai moved this from Sprint to In Progress in Hershey's 🍫 Jul 6, 2020
@BranescuMihai BranescuMihai self-assigned this Jul 6, 2020
@BranescuMihai BranescuMihai added the E3 Estimation Point: average, 2 - 3 days label Jul 20, 2020
@st3fan st3fan added this to Backlog in A-C: Meta: Sync Tabs via automation Jul 24, 2020
@BranescuMihai BranescuMihai moved this from In Progress to Waiting in Hershey's 🍫 Jul 29, 2020
@BranescuMihai BranescuMihai mentioned this issue Jul 29, 2020
Merged
4 tasks
@BranescuMihai BranescuMihai added the 🙅 waiting Issues that are blocked or has dependencies that are not ready label Jul 29, 2020
@BranescuMihai
Copy link
Contributor

Progress: So the problem is that the user clicks the sync tabs page while the auth flow is in progress. Currently this is not handled in the code and always displays an error first.

I decided to wait until mozilla-mobile/android-components#7856 is landed, since that PR refactors the whole sync flow and gives access to an internal state (auth in progress) that we need

@data-sync-user data-sync-user changed the title [Bug] [Synced tabs] The list of opened tabs are not displayed after restarting the app and accessing Synced tabs FNX3-15203 ⁃ [Bug] [Synced tabs] The list of opened tabs are not displayed after restarting the app and accessing Synced tabs Aug 1, 2020
@data-sync-user data-sync-user changed the title FNX3-15203 ⁃ [Bug] [Synced tabs] The list of opened tabs are not displayed after restarting the app and accessing Synced tabs FNX-13232 ⁃ [Bug] [Synced tabs] The list of opened tabs are not displayed after restarting the app and accessing Synced tabs Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX-13232 ⁃ [Bug] [Synced tabs] The list of opened tabs are not displayed after restarting the app and accessing Synced tabs FNX2-15073 ⁃ [Bug] [Synced tabs] The list of opened tabs are not displayed after restarting the app and accessing Synced tabs Aug 11, 2020
@Mugurell
Copy link
Contributor

Checked if this is ready to be worked on.
Based on #12195 (comment) we are still waiting for the refactorization happening in mozilla-mobile/android-components#7856.

@kbrosnan kbrosnan changed the title FNX2-15073 ⁃ [Bug] [Synced tabs] The list of opened tabs are not displayed after restarting the app and accessing Synced tabs [Bug] [Synced tabs] The list of opened tabs are not displayed after restarting the app and accessing Synced tabs Aug 29, 2020
@Mugurell
Copy link
Contributor

Seems like this is blocked until at least mid September - mozilla-mobile/android-components#7856 (comment)

@bifleming
Copy link

Fix for related bug was merged 2 days ago.

@bifleming bifleming removed the 🙅 waiting Issues that are blocked or has dependencies that are not ready label Sep 24, 2020
@ebalazs-sv
Copy link
Author

Verified as fixed on Nightly 200925 06:01 GV 83.0a1 from 9/25 with Motorola Moto G6 (Android 8).
20200925_112539

A-C: Meta: Sync Tabs automation moved this from Backlog to Done Sep 25, 2020
Hershey's 🍫 automation moved this from Waiting to QA Review Sep 25, 2020
@ebalazs-sv ebalazs-sv added the eng:qa:verified QA Verified label Sep 25, 2020
@mcarare mcarare moved this from QA Review to Done Sprint 20.20 in Hershey's 🍫 Sep 28, 2020
@mcarare mcarare moved this from Done Sprint 20.20 to Done in Hershey's 🍫 Oct 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@BranescuMihai BranescuMihai

Labels
🐞 bug Crashes, Something isn't working, .. E3 Estimation Point: average, 2 - 3 days eng:qa:verified QA Verified Feature:SyncTabs Sync tabs S2 Major Functionality/product severely impaired and a satisfactory workaround doesn't exist
Projects
No open projects
A-C: Meta: Sync Tabs
  
Done
Hershey's 🍫
  
Done
Milestone
No milestone
Development

No branches or pull requests
4 participants
@BranescuMihai @Mugurell @bifleming @ebalazs-sv