Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

For #11498 and #11499 - Add Sync tabs error view (with/without CTA) #11634

Merged

Conversation

BranescuMihai
Copy link
Contributor

@BranescuMihai BranescuMihai commented Jun 16, 2020

As per this documentation:

Sign-in error
No tabs error
Re-authenticate error

Pull Request checklist

  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

After merge

  • Milestone: Make sure issues finished by this pull request are added to the milestone of the version currently in development.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

@codecov-commenter
Copy link

codecov-commenter commented Jun 16, 2020

Codecov Report

Merging #11634 into master will increase coverage by 0.06%.
The diff coverage is 23.02%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #11634      +/-   ##
============================================
+ Coverage     27.51%   27.57%   +0.06%     
- Complexity     1006     1010       +4     
============================================
  Files           415      416       +1     
  Lines         16586    16655      +69     
  Branches       2127     2134       +7     
============================================
+ Hits           4563     4592      +29     
- Misses        11697    11732      +35     
- Partials        326      331       +5     
Impacted Files Coverage Δ Complexity Δ
...in/java/org/mozilla/fenix/AppRequestInterceptor.kt 84.00% <0.00%> (ø) 6.00 <0.00> (ø)
...a/org/mozilla/fenix/browser/BaseBrowserFragment.kt 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...nix/components/toolbar/BrowserToolbarController.kt 69.88% <0.00%> (-0.98%) 0.00 <0.00> (ø)
.../mozilla/fenix/migration/MigrationStatusAdapter.kt 70.00% <0.00%> (ø) 5.00 <0.00> (ø)
.../mozilla/fenix/search/awesomebar/AwesomeBarView.kt 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...java/org/mozilla/fenix/tabtray/FenixTabsAdapter.kt 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...main/java/org/mozilla/fenix/tabtray/TabTrayView.kt 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
.../java/org/mozilla/fenix/tabtray/TabsTouchHelper.kt 10.63% <10.63%> (+10.63%) 0.00 <0.00> (ø)
...ava/org/mozilla/fenix/sync/SyncedTabsViewHolder.kt 54.28% <23.80%> (-45.72%) 1.00 <0.00> (ø)
...in/java/org/mozilla/fenix/sync/SyncedTabsLayout.kt 30.76% <33.33%> (+5.05%) 0.00 <0.00> (ø)
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 239e3de...01a2465. Read the comment docs.

@BranescuMihai BranescuMihai changed the title For #11498 - Add Sync tabs error view (with/without CTA) For #11498 and #11499 - Add Sync tabs error view (with/without CTA) Jun 16, 2020
@codrut-topliceanu codrut-topliceanu self-assigned this Jun 17, 2020
Copy link
Contributor

@codrut-topliceanu codrut-topliceanu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks.
I found some bugs unrelated to your PR that I will document in their own separate issues.

  1. Cold starting Fenix and rushing to synced tabs fragment leads to some strange concurrency issues.
  2. Being logged in on other devices with no tabs opened on them will lead to a blank page of synced devices instead of the "no tabs error".

Both issues are visible in this video : https://drive.google.com/file/d/14u83g7dp8Kjkw2G7LHjYdYJgbEGQ69Na/view?usp=sharing

@BranescuMihai
Copy link
Contributor Author

Currently waiting on mozilla-mobile/android-components#7422 to get fixed on AC

@jonalmeida
Copy link
Contributor

Cold starting Fenix and rushing to synced tabs fragment leads to some strange concurrency issues.

We have two bugs filed that needs more account manager support:

@codrut-topliceanu
Copy link
Contributor

@BranescuMihai Related AC issue/PR is now closed/merged

@BranescuMihai
Copy link
Contributor Author

Progress: Still not merging this because there are some issues on AC that call refreshSyncedTabs twice, and the first time since the tabs are not yet synced, it will send to Fenix the NO_TABS error, leading to wrong UI behaviour. Will investigate after code freeze.

@ekager
Copy link
Contributor

ekager commented Jul 16, 2020

Product wants this CTA in our Sept release. Can we prioritize the blocking issues in AC or find a workaround @jonalmeida @BranescuMihai ?

@BranescuMihai
Copy link
Contributor Author

Since the related bug is now explained in a different issue: #12195, and this PR is only about a UI change, we can proceed with this one

@BranescuMihai BranescuMihai merged commit 64072a1 into mozilla-mobile:master Jul 31, 2020
@BranescuMihai BranescuMihai added this to Done in A-C: Meta: Sync Tabs via automation Jul 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

5 participants