Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Telemetry] Error Pages #1242

Closed
bbinto opened this issue Mar 28, 2019 · 9 comments
Closed

[Telemetry] Error Pages #1242

bbinto opened this issue Mar 28, 2019 · 9 comments

Comments

@bbinto
Copy link
Contributor

bbinto commented Mar 28, 2019

Description & Product Manager User Story

  • As a product owner, I want to know when people encounter errors on websites so we know when they

What questions will you answer with this data?

  • When and what errors users experience within the app
  • What will users do after they've encountered an error (Amplitude funnel) and how will they get out of it

Why does Mozilla need to answer these questions? Are there benefits for users? Do we need this information to address product or business requirements?

  • Understand the health of the web and how often users encounter website errors

What probes (suggested, if applicable)

  • send an event ping on each specific error, see here for kind of errors

Dependencies (Added by PM and Eng)

  • Glean SDK

Acceptance Criteria (Added by PM)

  • Event pings can be queried via re:dash
  • We are sending telemetry events for the actions listed in the requirements
  • We have documented the telemetry
  • We have asked a data steward to review the telemetry
  • NOT an AC: Data science to create dashboard or further graphs (this will be a separate issue, this issue is only about hooking up the events described and that they can be queried in re-dash)

┆Issue is synchronized with this Jira Task

@bbinto bbinto modified the milestones: Eng Backlog, Backlog Mar 28, 2019
@vesta0 vesta0 added P2 Upcoming release and removed P3 Some future sprint labels Mar 29, 2019
@vesta0 vesta0 modified the milestones: Backlog, Backlog (After MVP) Mar 29, 2019
@vesta0 vesta0 added P1 Current sprint and removed P2 Upcoming release labels Apr 23, 2019
@vesta0 vesta0 modified the milestones: Post-MVP Backlog, MVP Backlog Apr 23, 2019
@vesta0 vesta0 added this to Ready for Dev in Fenix Sprint Kanban Apr 30, 2019
@sblatz sblatz self-assigned this May 14, 2019
@sblatz
Copy link
Contributor

sblatz commented May 14, 2019

@vesta0 is there any other data we want to track in this? I'm understanding this ticket to mean that we're just going to send a ping with the error type (e.g. ERROR_NET_TIMEOUT) and no other information.

sblatz added a commit to sblatz/fenix that referenced this issue May 14, 2019
sblatz added a commit to sblatz/fenix that referenced this issue May 14, 2019
@vesta0
Copy link
Collaborator

vesta0 commented May 15, 2019

@sblatz I think that's about it (when and what error type). We also want to track what users do right after they've encountered the error but I think that depends on other probes we have put in place, would you agree?

sblatz added a commit to sblatz/fenix that referenced this issue May 15, 2019
@project-bot project-bot bot moved this from Ready for Dev to In Progress in Fenix Sprint Kanban May 15, 2019
@bifleming bifleming added the Release Blocker Blocks a Release label May 17, 2019
sblatz added a commit to sblatz/fenix that referenced this issue May 21, 2019
@sblatz sblatz added eng:qa:needed QA Needed and removed in progress labels Jun 6, 2019
@project-bot project-bot bot moved this from In Progress to Ready for QA in Fenix Sprint Kanban Jun 6, 2019
@sblatz
Copy link
Contributor

sblatz commented Jun 6, 2019

Should be fixed by #3224.

@AndiAJ
Copy link
Collaborator

AndiAJ commented Jun 11, 2019

Hi, the error_page still doesn't work.

Please find attached and review the logcat Errortxt.txt and the log from the dashboard (https://debug-ping-preview.firebaseapp.com/pings/2311bde3-47fc-4272-9a8b-b1cce4e7eaf5/aj-TezzErr-00)

I've used the following websites to trigger the errors:

https://www.fakeurlwebsite.org/
http://mediarepoes.net/
http://www.odiadon.com/
http://tessline.com/
https://testsafebrowsing.appspot.com/s/phishing.html
https://testsafebrowsing.appspot.com/s/unwanted.html
https://expired.badssl.com

One question though, @sblatz shouldn't it be correlated with "searched_page" event ping? After accessing a page only afterwards the error should pop up ?

Based on this comment I'll remove the QA needed label.

@abodea abodea added in progress and removed eng:qa:needed QA Needed labels Jun 11, 2019
@project-bot project-bot bot moved this from Ready for QA to In Progress in Fenix Sprint Kanban Jun 11, 2019
@sblatz
Copy link
Contributor

sblatz commented Jun 11, 2019

Could @boek weigh in here? I'm really not sure what else would be the issue here. I'm able to get the telemetry line triggered in my debugging. I wonder if the AppRequestInterceptor is for some reason not compatible with Telemetry?

@vesta0 vesta0 removed the Release Blocker Blocks a Release label Jun 12, 2019
boek added a commit to boek/fenix that referenced this issue Jun 13, 2019
@sblatz sblatz added eng:qa:needed QA Needed and removed in progress labels Jun 13, 2019
@project-bot project-bot bot moved this from In Progress to Ready for QA in Fenix Sprint Kanban Jun 13, 2019
@AndiAJ
Copy link
Collaborator

AndiAJ commented Jun 14, 2019

Hi, verified as fixed on the latest Fenix version (2019-06-14) using a Google Pixel 3XL(Android 9)

I've used the following websites to trigger the errors:

https://www.fakeurlwebsite.org/
http://mediarepoes.net/
http://www.odiadon.com/
http://tessline.com/
https://testsafebrowsing.appspot.com/s/phishing.html
https://testsafebrowsing.appspot.com/s/malware.html
https://testsafebrowsing.appspot.com/s/unwanted.html
https://expired.badssl.com

Please find attached the logcat Error.txt
and the link from the dashboard:https://debug-ping-preview.firebaseapp.com/pings/c9dd95fc-79ff-455b-ac97-eac9d4ccc7df/aj-testerr-140600

@boek @sblatz - Please review the attached logs and if any problems encountered, reopen this ticket.

Based on this comment I'll remove the QA needed label and close the ticket

@abodea abodea added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Jun 14, 2019
@abodea abodea moved this from Ready for QA to Done in Fenix Sprint Kanban Jun 14, 2019
@sblatz sblatz closed this as completed Jun 14, 2019
@data-sync-user data-sync-user changed the title [Telemetry] Error Pages FNX2-16866 ⁃ [Telemetry] Error Pages Aug 2, 2020
@data-sync-user data-sync-user changed the title FNX2-16866 ⁃ [Telemetry] Error Pages FNX3-15380 ⁃ [Telemetry] Error Pages Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX3-15380 ⁃ [Telemetry] Error Pages FNX-4896 ⁃ [Telemetry] Error Pages Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX-4896 ⁃ [Telemetry] Error Pages FNX2-16866 ⁃ [Telemetry] Error Pages Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX2-16866 ⁃ [Telemetry] Error Pages [Telemetry] Error Pages May 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

7 participants