Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Align Settings -> Site permissions -> Sub-pages to 72dp keyline #12532

Closed
brampitoyo opened this issue Jul 14, 2020 · 5 comments
Closed

Align Settings -> Site permissions -> Sub-pages to 72dp keyline #12532

brampitoyo opened this issue Jul 14, 2020 · 5 comments
Labels
eng:qa:verified QA Verified eng:ux-debt Feature polish and UX engineering debt

Comments

@brampitoyo
Copy link

brampitoyo commented Jul 14, 2020 •
edited by data-sync-user
Loading

@hakkikaancaliskan

The main page of Site permissions has correct keyline value and icon alignment.

The sub-pages (Autoplay, Camera, Location, Microphone, Notification, Exceptions) all need to follow.

Sub-page: Location (also applies to other adjacent sub-pages)

The text block that says “Blocked by Android” should also align to a 72dp keyline.

Sub-page: Exceptions

Sub-page: Exceptions -> Individual site > Location (also applies to other adjacent subpages)

The text block that says “Blocked by Android” should also align to a 72dp keyline.

┆Issue is synchronized with this Jira Task
@brampitoyo brampitoyo added 🐞 bug Crashes, Something isn't working, .. ux:visual-design labels Jul 14, 2020
@github-actions github-actions bot added the needs:triage Issue needs triage label Jul 14, 2020
@eliserichards eliserichards added eng:ux-debt Feature polish and UX engineering debt and removed needs:triage Issue needs triage 🐞 bug Crashes, Something isn't working, .. labels Jul 14, 2020
@eliserichards eliserichards changed the title [Bug] Align Settings -> Site permissions -> Sub-pages to 72dp keyline Align Settings -> Site permissions -> Sub-pages to 72dp keyline Jul 14, 2020
eliserichards added a commit that referenced this issue Jul 17, 2020
@eliserichards @hkaancaliskan
For #12532: Align Settings -> Site permissions -> Sub-pages to 72dp k…
37af9df 
…eyline (#12680)

Co-authored-by: Hakkı Kaan Çalışkan <caliskanhkaan@gmail.com>
liuche pushed a commit that referenced this issue Jul 20, 2020
@hkaancaliskan
For #12532: Quick fix for radio button alignment (#12691)
aeabd3e
@liuche liuche mentioned this issue Jul 20, 2020
Closed
9 tasks
@sv-ohorvath
Copy link
Contributor

@liuche @eliserichards Looking at the commits list, this appears to have landed on Beta 79.1.0. Could you please let us know if it's ready for QA? Thanks!

@lobontiumira
Copy link

Hi all!

The settings in Site permissions are not aligned yet in the latest Nightly from 7/24, or Beta 79.1.0-beta.1. Tested on Samsung Galaxy Tab S6 (Android 9), and Sony Xperia Z5 Premium (Android 7.1.1).

permissions

@hkaancaliskan
Copy link

Hmm, that's aligned on my device. I'll take a look at it when I get home.

@hkaancaliskan
Copy link

@softvision-miralobontiu That radio button texts are aligned on my devices with master and 7/24:
XZ1 Android 10

Android 5.0 API 21 Emulator

@NotWoods how or what should i do for this?

@data-sync-user data-sync-user changed the title Align Settings -> Site permissions -> Sub-pages to 72dp keyline FNX3-13541 ⁃ Align Settings -> Site permissions -> Sub-pages to 72dp keyline Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX3-13541 ⁃ Align Settings -> Site permissions -> Sub-pages to 72dp keyline FNX-13613 ⁃ Align Settings -> Site permissions -> Sub-pages to 72dp keyline Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX-13613 ⁃ Align Settings -> Site permissions -> Sub-pages to 72dp keyline FNX2-15312 ⁃ Align Settings -> Site permissions -> Sub-pages to 72dp keyline Aug 11, 2020
@kbrosnan kbrosnan changed the title FNX2-15312 ⁃ Align Settings -> Site permissions -> Sub-pages to 72dp keyline Align Settings -> Site permissions -> Sub-pages to 72dp keyline Aug 29, 2020
@lobontiumira
Copy link

Verified as fixed on the 2/15 Nightly, on Beta 86.0.0-beta.5, and RC 85.1.3, with Google Pixel (Android 10).

@lobontiumira lobontiumira added the eng:qa:verified QA Verified label Feb 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
eng:qa:verified QA Verified eng:ux-debt Feature polish and UX engineering debt
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@brampitoyo @lime124 @sv-ohorvath @hkaancaliskan @lobontiumira @eliserichards