Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

For #12532: Quick fix for site permission radio button alignment #12691

Merged
merged 1 commit into from
Jul 20, 2020
Merged

For #12532: Quick fix for site permission radio button alignment #12691

merged 1 commit into from
Jul 20, 2020

Conversation

hkaancaliskan
Copy link

Idk how but when I was writing this preference_seek_bar_padding was 24 dp, but now 16dp. Fixed with dimen.
Screenshot_1595058655

Pull Request checklist

  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

After merge

  • Milestone: Make sure issues finished by this pull request are added to the milestone of the version currently in development.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

@firefoxci-taskcluster
Copy link

No Taskcluster jobs started for this pull request
The `allowPullRequests` configuration for this repository (in `.taskcluster.yml` on the
default branch) does not allow starting tasks for this pull request.

@hkaancaliskan hkaancaliskan changed the title For #12532: Quick fix for radio button alignment For #12532: Quick fix for site permission radio button alignment Jul 20, 2020
@liuche liuche merged commit aeabd3e into mozilla-mobile:master Jul 20, 2020
@brampitoyo
Copy link

@hakkikaancaliskan The text alignment on this screen looks good to me!

@hkaancaliskan hkaancaliskan deleted the site-permission-quickfix branch July 21, 2020 06:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants