Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Homescreen] Adjust top and left alignment of logo on homescreen #12673

Closed
AmyYLee opened this issue Jul 17, 2020 · 6 comments
Closed

[Homescreen] Adjust top and left alignment of logo on homescreen #12673

AmyYLee opened this issue Jul 17, 2020 · 6 comments
Assignees
Labels

Comments

@AmyYLee
Copy link
Collaborator

AmyYLee commented Jul 17, 2020

Hi,

Please update the homescreen logo position to the mock posted below. The logo should be left aligned with 16px margin along with the collections elements and should be vertically aligned to the Private browsing icon. Thanks

┆Issue is synchronized with this Jira Task

@AmyYLee AmyYLee added 🐞 bug Crashes, Something isn't working, .. eng:ready Ready for engineering needs:triage Issue needs triage implementation review and removed 🐞 bug Crashes, Something isn't working, .. labels Jul 17, 2020
@eliserichards eliserichards removed the needs:triage Issue needs triage label Jul 17, 2020
@Dunexus
Copy link

Dunexus commented Jul 17, 2020

@AmyYLee What about the alignment of beta and nightly text as it has two lines of text ("Firefox Browser" and "Beta"/"Nightly") ?

Currently, "Firefox Browser" is aligned with the logo and "Beta"/"Nightly" below seems missaligned.

Screenshot_20200717-224743.jpg

@hkaancaliskan
Copy link

@AmyYLee What about the alignment of beta and nightly text as it has two lines of text ("Firefox Browser" and "Beta"/"Nightly") ?

Currently, "Firefox Browser" is aligned with the logo and "Beta"/"Nightly" below seems missaligned.

Screenshot_20200717-224743.jpg

Yep, agreed. We will need new wordmark icons for that, there will be no problem on eng side.

@data-sync-user data-sync-user changed the title [Homescreen] Adjust top and left alignment of logo on homescreen FNX3-21828 ⁃ [Homescreen] Adjust top and left alignment of logo on homescreen Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX3-21828 ⁃ [Homescreen] Adjust top and left alignment of logo on homescreen FNX-13776 ⁃ [Homescreen] Adjust top and left alignment of logo on homescreen Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX-13776 ⁃ [Homescreen] Adjust top and left alignment of logo on homescreen FNX2-15406 ⁃ [Homescreen] Adjust top and left alignment of logo on homescreen Aug 11, 2020
@AmyYLee
Copy link
Collaborator Author

AmyYLee commented Aug 25, 2020

Screen Shot 2020-08-25 at 3 47 31 PM

@hakkikaancaliskan The alignment should follow like this for the Nightly logo. Thanks

@AmyYLee What about the alignment of beta and nightly text as it has two lines of text ("Firefox Browser" and "Beta"/"Nightly") ?
Currently, "Firefox Browser" is aligned with the logo and "Beta"/"Nightly" below seems missaligned.
Screenshot_20200717-224743.jpg

Yep, agreed. We will need new wordmark icons for that, there will be no problem on eng side.

This should be top aligned with the

@AmyYLee
Copy link
Collaborator Author

AmyYLee commented Aug 25, 2020

Moving forward - please ping @apbitner for review

@hkaancaliskan
Copy link

Screen Shot 2020-08-25 at 3 47 31 PM

@hakkikaancaliskan The alignment should follow like this for the Nightly logo. Thanks

@AmyYLee What about the alignment of beta and nightly text as it has two lines of text ("Firefox Browser" and "Beta"/"Nightly") ?
Currently, "Firefox Browser" is aligned with the logo and "Beta"/"Nightly" below seems missaligned.
Screenshot_20200717-224743.jpg

Yep, agreed. We will need new wordmark icons for that, there will be no problem on eng side.

This should be top aligned with the

It's currently as you said in #12676 afaik. I'll check and post a screenshot in pr.

liuche pushed a commit that referenced this issue Aug 28, 2020
@kbrosnan kbrosnan changed the title FNX2-15406 ⁃ [Homescreen] Adjust top and left alignment of logo on homescreen [Homescreen] Adjust top and left alignment of logo on homescreen Aug 29, 2020
TrianguloY pushed a commit to TrianguloY/fenix that referenced this issue Sep 3, 2020
@mcarare mcarare added the eng:qa:needed QA Needed label Sep 10, 2020
@abodea
Copy link
Member

abodea commented Sep 10, 2020

Verified as fixed on the latest Nightly build 9/10 with Google Pixel 4 XL (Android 11).

@abodea abodea closed this as completed Sep 10, 2020
@abodea abodea added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Sep 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

6 participants