Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

For #12673: Adjust top and left alignment of logo on homescreen #12676

Merged
merged 1 commit into from
Aug 28, 2020
Merged

For #12673: Adjust top and left alignment of logo on homescreen #12676

merged 1 commit into from
Aug 28, 2020

Conversation

hkaancaliskan
Copy link

@hkaancaliskan hkaancaliskan commented Jul 17, 2020

Screenshot_20200717-210430_Firefox_Preview

Pull Request checklist

  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

After merge

  • Milestone: Make sure issues finished by this pull request are added to the milestone of the version currently in development.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

@firefoxci-taskcluster
Copy link

No Taskcluster jobs started for this pull request
The `allowPullRequests` configuration for this repository (in `.taskcluster.yml` on the
default branch) does not allow starting tasks for this pull request.

@ekager ekager added the needs:UX-feedback Needs UX Feedback label Jul 17, 2020
@hkaancaliskan
Copy link
Author

@apbitner I've rebased and looks like good to go.
I've cc'd you because of this #12673 (comment)
Screenshot_1598388029

@NotWoods NotWoods removed the needs:UX-feedback Needs UX Feedback label Aug 26, 2020
Copy link
Contributor

@NotWoods NotWoods left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM!

@NotWoods NotWoods added the pr:needs-landing PRs that are ready to land [Will be merged by Mergify] label Aug 26, 2020
@codecov-commenter
Copy link

Codecov Report

Merging #12676 into master will increase coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #12676   +/-   ##
=========================================
  Coverage     29.81%   29.81%           
- Complexity     1115     1117    +2     
=========================================
  Files           422      422           
  Lines         17172    17170    -2     
  Branches       2229     2227    -2     
=========================================
+ Hits           5119     5120    +1     
+ Misses        11678    11676    -2     
+ Partials        375      374    -1     
Impacted Files Coverage Δ Complexity Δ
...pp/src/main/java/org/mozilla/fenix/FeatureFlags.kt 100.00% <ø> (ø) 3.00 <0.00> (ø)
...a/org/mozilla/fenix/browser/BaseBrowserFragment.kt 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
.../java/org/mozilla/fenix/browser/BrowserFragment.kt 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...zilla/fenix/components/metrics/MetricController.kt 35.51% <0.00%> (-0.68%) 0.00 <0.00> (ø)
...in/java/org/mozilla/fenix/settings/SupportUtils.kt 75.51% <0.00%> (+4.08%) 13.00% <0.00%> (+2.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 35f63f8...145f2ce. Read the comment docs.

@liuche liuche merged commit dc377dd into mozilla-mobile:master Aug 28, 2020
@hkaancaliskan hkaancaliskan deleted the align-wordmark branch August 28, 2020 10:22
TrianguloY pushed a commit to TrianguloY/fenix that referenced this pull request Sep 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr:needs-landing PRs that are ready to land [Will be merged by Mergify]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants