Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[taskcluster] Dep-sign APKs for Raptor consumption on each master commit #1321

Closed
mitchhentges opened this issue Apr 2, 2019 · 2 comments
Closed
Assignees
Labels
eng:automation Build automation, Continuous integration, .. eng:release Release Engineering
Milestone

Comments

@mitchhentges
Copy link
Contributor

mitchhentges commented Apr 2, 2019

We will have performance tests running on fenix in the future. One of the requirements is to have builds signed with our releng-mobile "dep" key. The "dep" ("dependency") key is very similar to our release key that's used for production/beta/nightly, except that it's used strictly for internal automation (such as for performance-testing/raptor 😄)

This ticket requires that, on every commit to the master branch, the "release raptor" variants should dep-signed.

┆Issue is synchronized with this Jira Task

@mitchhentges mitchhentges added the eng:automation Build automation, Continuous integration, .. label Apr 2, 2019
@mitchhentges mitchhentges self-assigned this Apr 2, 2019
@vesta0 vesta0 added this to the MVP Backlog milestone Apr 2, 2019
@vesta0 vesta0 added the eng:release Release Engineering label Apr 2, 2019
mitchhentges pushed a commit to mitchhentges/fenix that referenced this issue Apr 5, 2019
mitchhentges pushed a commit to mitchhentges/fenix that referenced this issue Apr 5, 2019
mitchhentges pushed a commit to mitchhentges/fenix that referenced this issue Apr 5, 2019
mitchhentges pushed a commit to mitchhentges/fenix that referenced this issue Apr 5, 2019
mitchhentges pushed a commit to mitchhentges/fenix that referenced this issue Apr 5, 2019
mitchhentges pushed a commit to mitchhentges/fenix that referenced this issue Apr 5, 2019
@ghost ghost added the review label Apr 5, 2019
mitchhentges pushed a commit to mitchhentges/fenix that referenced this issue Apr 5, 2019
mitchhentges pushed a commit to mitchhentges/fenix that referenced this issue Apr 8, 2019
mitchhentges pushed a commit to mitchhentges/fenix that referenced this issue Apr 8, 2019
mitchhentges pushed a commit to mitchhentges/fenix that referenced this issue Apr 8, 2019
mitchhentges pushed a commit to mitchhentges/fenix that referenced this issue Apr 8, 2019
mitchhentges pushed a commit to mitchhentges/fenix that referenced this issue Apr 8, 2019
mitchhentges pushed a commit to mitchhentges/fenix that referenced this issue Apr 8, 2019
mitchhentges pushed a commit to mitchhentges/fenix that referenced this issue Apr 8, 2019
mitchhentges pushed a commit to mitchhentges/fenix that referenced this issue Apr 8, 2019
mitchhentges pushed a commit to mitchhentges/fenix that referenced this issue Apr 8, 2019
mitchhentges pushed a commit to mitchhentges/fenix that referenced this issue Apr 8, 2019
mitchhentges pushed a commit to mitchhentges/fenix that referenced this issue Apr 8, 2019
mitchhentges pushed a commit to mitchhentges/fenix that referenced this issue Apr 8, 2019
mitchhentges pushed a commit to mitchhentges/fenix that referenced this issue Apr 9, 2019
mitchhentges pushed a commit to mitchhentges/fenix that referenced this issue Apr 9, 2019
@ncalexan
Copy link
Contributor

ncalexan commented Apr 9, 2019

We will have performance tests running on fenix in the future. One of the requirements is to have builds signed with the dep key.

What is the "dep" key?

This ticket requires that, on every commit to the master branch, all the debug variants should be dep-signed.

This seems very counter-intuitive. In general, I would much prefer to have automation Just Work on release builds -- especially for browsers, where we legitimately want to support other people automating things.

I have a plan that runs through Bug 1533385 -- sadly, just backed out -- to make GeckoView itself handle this type of configuration for automation, rather than requiring vehicles (like Fenix) pass things through. If we did this we could run Raptor directly against Fenix, and not do things that are surprising to me, like signing debug builds with what I expect is a release key.

@mitchhentges, what's the rest of the context here?

mitchhentges pushed a commit to mitchhentges/fenix that referenced this issue Apr 10, 2019
@mitchhentges
Copy link
Contributor Author

Good points Nick! I haven't kept this ticket up-to-date, unfortunately.

  • Within Releng Mobile, we have three types of keys: release keys (used for production, beta and nightlies), dep keys (so-called "dependency keys" used for automation - such as logic tests, performance tests, or perhaps staging builds) and dev keys ("development keys" used for debugging automation by hand)
  • When this ticket was created, there was an issue that stopped release builds from being raptor-able (which I should've linked 😬). However, the underlying issue has been resolved since this ticket was created, and the PR that I'm preparing to land is indeed using release builds.

TL;DR: The "dep" key isn't the same key as used for releasing Fenix to users, and we are indeed using release builds :)

Let me know if that clears up the misinformation in my original ticket 😄

@mitchhentges mitchhentges changed the title [taskcluster] Dep-sign APKs for Raptor consumption on each master commit [taskcluster] Sign APKs for Raptor consumption on each master commit Apr 10, 2019
@mitchhentges mitchhentges changed the title [taskcluster] Sign APKs for Raptor consumption on each master commit [taskcluster] Dep-sign APKs for Raptor consumption on each master commit Apr 10, 2019
@ghost ghost removed the review label Apr 10, 2019
ncalexan added a commit to ncalexan/fenix that referenced this issue Apr 10, 2019
This just looks wrong.  I'm concerned that this was green as a PR,
because it suggests that we were signing with an incorrect
`worker_type` there; but here we are -- let's see if it addresses the
issue.  If not, we'll back the whole of mozilla-mobile#1321 out.
ncalexan added a commit that referenced this issue Apr 10, 2019
This just looks wrong.  I'm concerned that this was green as a PR,
because it suggests that we were signing with an incorrect
`worker_type` there; but here we are -- let's see if it addresses the
issue.  If not, we'll back the whole of #1321 out.
@data-sync-user data-sync-user changed the title [taskcluster] Dep-sign APKs for Raptor consumption on each master commit FNX2-17032 ⁃ [taskcluster] Dep-sign APKs for Raptor consumption on each master commit Aug 3, 2020
@data-sync-user data-sync-user changed the title FNX2-17032 ⁃ [taskcluster] Dep-sign APKs for Raptor consumption on each master commit FNX3-15482 ⁃ [taskcluster] Dep-sign APKs for Raptor consumption on each master commit Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX3-15482 ⁃ [taskcluster] Dep-sign APKs for Raptor consumption on each master commit FNX-4956 ⁃ [taskcluster] Dep-sign APKs for Raptor consumption on each master commit Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX-4956 ⁃ [taskcluster] Dep-sign APKs for Raptor consumption on each master commit FNX2-17032 ⁃ [taskcluster] Dep-sign APKs for Raptor consumption on each master commit Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX2-17032 ⁃ [taskcluster] Dep-sign APKs for Raptor consumption on each master commit [taskcluster] Dep-sign APKs for Raptor consumption on each master commit May 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
eng:automation Build automation, Continuous integration, .. eng:release Release Engineering
Projects
None yet
Development

No branches or pull requests

4 participants