This repository has been archived by the owner on Feb 20, 2023. It is now read-only.
Try to fix build bustage from #1321. #1538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This just looks wrong. I'm concerned that this was green as a PR, because it suggests that we were signing with an incorrect `worker_type` there; but here we are -- let's see if it addresses the issue. If not, we'll back the whole of mozilla-mobile#1321 out.
ghost
assigned 
boek
approved these changes
Apr 10, 2019
|
Thank you very much for fixing this issue. Sadly we came across the same problem a few hours before on reference-browser mozilla-mobile/reference-browser#711 😕 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This just looks wrong. I'm concerned that this was green as a PR,
because it suggests that we were signing with an incorrect
worker_typethere; but here we are -- let's see if it addresses theissue. If not, we'll back the whole of #1321 out.
This is basically untested, 'cuz it's not really possible/worth the effort to test except on
master.