Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Bug] "scroll to hide toolbar" option does not work (with bottom toolbar) #14902

Closed
cadeyrn opened this issue Sep 9, 2020 · 4 comments
Closed

[Bug] "scroll to hide toolbar" option does not work (with bottom toolbar) #14902

cadeyrn opened this issue Sep 9, 2020 · 4 comments
Assignees
@Mugurell
Labels
🐞 bug Crashes, Something isn't working, .. E1 Estimation Point: trivial, less than half day eng:qa:verified QA Verified Feature:Gesture Feature:Settings S2 Major Functionality/product severely impaired and a satisfactory workaround doesn't exist
Projects
Hershey's 🍫

Comments

@cadeyrn
Copy link
Contributor

cadeyrn commented Sep 9, 2020 •
edited by data-sync-user
Loading

Steps to reproduce

  1. Make sure you have the bottom toolbar enabled
  2. Disable the new "Scroll to hide toolbar" option

Expected behavior

Static toolbar.

Actual behavior

Still a dynamic toolbar. Since the other new options "Swipe toolbar sideways to switch tabs" and "Pull to refresh" both works I guess the "Scroll to hide toolbar" option is also supposed to work.

With the toolbar on top the option works.

/cc @Mugurell

Device information

  • Android device: OnePlus 7T Pro McLaren / Oxygen OS 10.0.10 (Android 10)
  • Fenix version: master branch revision 4de80a0

┆Issue is synchronized with this Jira Task
@cadeyrn cadeyrn added the 🐞 bug Crashes, Something isn't working, .. label Sep 9, 2020
@cadeyrn cadeyrn changed the title [Bug] "scroll to hide toolbar" option does not work [Bug] "scroll to hide toolbar" option does not work (with bottom toolbar) Sep 9, 2020
@github-actions github-actions bot added the needs:triage Issue needs triage label Sep 9, 2020
@ekager ekager added the hershey label Sep 9, 2020
@kbrosnan kbrosnan removed the needs:triage Issue needs triage label Sep 9, 2020
@Mugurell Mugurell added this to In Dev Review in Hershey's 🍫 Sep 10, 2020
@Mugurell Mugurell mentioned this issue Sep 10, 2020
Closed
@sv-ohorvath sv-ohorvath added the S2 Major Functionality/product severely impaired and a satisfactory workaround doesn't exist label Sep 10, 2020
This was referenced Sep 10, 2020
Closed
Closed
@Mugurell Mugurell added the E1 Estimation Point: trivial, less than half day label Sep 10, 2020
@MicroBeast
Copy link

Issue on Youtube Mobile page (m.youtube.com) when Toolbar on Top and Scroll to hide toolbar is off. Youtube Bottom Toolbar will float above what suppose to be Firefox Bottom Toolbar.

Nightly 200910 06:07 (Build #2015763057)
SM-T555, Redmi 4A

@cadeyrn
Copy link
Contributor Author

cadeyrn commented Sep 10, 2020

@MicroBeast Please open a separate issue for other problems with the toolbar.

liuche pushed a commit that referenced this issue Sep 11, 2020
@Mugurell
For #14902 - Disabling bottom toolbar animation now works (#14927)
b54949e
@liuche liuche added the eng:qa:needed QA Needed label Sep 11, 2020
interfect pushed a commit to fork-maintainers/iceraven-browser that referenced this issue Sep 11, 2020
@Mugurell @interfect
For mozilla-mobile#14902 - Disabling bottom toolbar animation now wor…
2e225a2 
…ks (mozilla-mobile#14927)
@Mugurell Mugurell moved this from In Dev Review to QA Review in Hershey's 🍫 Sep 11, 2020
@Mugurell
Copy link
Contributor

Ticket for the page layout issues - #14974

abhijitvalluri pushed a commit to abhijitvalluri/firefox2 that referenced this issue Sep 11, 2020
@Mugurell @abhijitvalluri
For mozilla-mobile#14902 - Disabling bottom toolbar animation now wor…
d21caf7 
…ks (mozilla-mobile#14927)
ekager added a commit to ekager/fenix that referenced this issue Sep 11, 2020
@ekager
Revert "For mozilla-mobile#14902 - Disabling bottom toolbar animation…
18ac25b 
… now works (mozilla-mobile#14927)"

This reverts commit b54949e.
liuche pushed a commit that referenced this issue Sep 11, 2020
@ekager
Reverts Disabling Gestures from 81.1.1 (#15005)
39d391c 
* Revert "For #10240 - New preferences to control gesture based features"

This reverts commit d8d896c.

* Revert "For #14902 - Disabling bottom toolbar animation now works (#14927)"

This reverts commit b54949e.
abhijitvalluri pushed a commit to fork-maintainers/iceraven-browser that referenced this issue Sep 13, 2020
@Mugurell @abhijitvalluri
For mozilla-mobile#14902 - Disabling bottom toolbar animation now wor…
84b9fb3 
…ks (mozilla-mobile#14927)
abhijitvalluri added a commit to fork-maintainers/iceraven-browser that referenced this issue Sep 13, 2020
@abhijitvalluri
Revert "For mozilla-mobile#14902 - Disabling bottom toolbar animation…
f3ce887 
… now works (mozilla-mobile#14927)"

This reverts commit 84b9fb3.
abhijitvalluri added a commit to fork-maintainers/iceraven-browser that referenced this issue Sep 13, 2020
@abhijitvalluri
Revert "For mozilla-mobile#14902 - Disabling bottom toolbar animation…
64ee2e9 
… now works (mozilla-mobile#14927)"

This reverts commit 84b9fb3.
@sflorean
Copy link
Contributor

Verified as fixed on Nightly 9/16 with Google Pixel 3 (Android 11) and Samsung Galaxy Note10 (Android 10).

@sflorean sflorean removed the eng:qa:needed QA Needed label Sep 16, 2020
@sflorean sflorean added the eng:qa:verified QA Verified label Sep 16, 2020
@mcarare mcarare moved this from QA Review to Done in Hershey's 🍫 Sep 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Mugurell Mugurell

Labels
🐞 bug Crashes, Something isn't working, .. E1 Estimation Point: trivial, less than half day eng:qa:verified QA Verified Feature:Gesture Feature:Settings S2 Major Functionality/product severely impaired and a satisfactory workaround doesn't exist
Projects
No open projects
Hershey's 🍫
  
Done
Milestone
No milestone
Development

No branches or pull requests
8 participants
@kbrosnan @liuche @cadeyrn @sv-ohorvath @Mugurell @MicroBeast @ekager @sflorean