Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Bug] Youtube Mobile page bottom toolbar float when Toolbar on Top and Scroll to hide toolbar is off. #14974

Closed
MicroBeast opened this issue Sep 11, 2020 · 4 comments
Closed

[Bug] Youtube Mobile page bottom toolbar float when Toolbar on Top and Scroll to hide toolbar is off. #14974

MicroBeast opened this issue Sep 11, 2020 · 4 comments
Assignees
@Mugurell
Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified Feature:Toolbar Address bar, see also Feature:Search
Projects
Hershey's 🍫

Comments

@MicroBeast
Copy link

MicroBeast commented Sep 11, 2020 •
edited by data-sync-user

Steps to reproduce

  1. Set Toolbar on top.
  2. Turn off Scroll to hide toolbar

Expected behavior

Youtube bottom toolbar stay where it suppose to be.

Actual behavior

Youtube bottom toolbar stay where it suppose to be.

Device information

  • Android device: SM-T555, Redmi 4A
  • Fenix version:
    Nightly 200910 06:07 (Build #2015763057)
    Nightly 200911 06:01 (Build #2015763249)

Screenshot_20200911-135829

Edited: Sorry, mixed up the actual and expected behaviour.

┆Issue is synchronized with this Jira Task
@MicroBeast MicroBeast added the 🐞 bug Crashes, Something isn't working, .. label Sep 11, 2020
@github-actions github-actions bot added the needs:triage Issue needs triage label Sep 11, 2020
@mcarare mcarare added the Feature:Toolbar Address bar, see also Feature:Search label Sep 11, 2020
@Mugurell Mugurell self-assigned this Sep 11, 2020
@Mugurell Mugurell added this to In Progress in Hershey's 🍫 Sep 11, 2020
This was referenced Sep 11, 2020
Closed
Closed
Closed
ekager pushed a commit that referenced this issue Sep 11, 2020
@Mugurell @ekager
For #14974 - Ensure website bottom elements stay at bottom
75aa2d4 
engineView.setDynamicToolbarMaxHeight(0) vs
engineView.setDynamicToolbarMaxHeight(toolbarHeight)
ensures webpage's bottom elements are aligned to the bottom of the browser.

We also need to make sure that when the toolbar is static it does not cover the
bottom of the page - something desired when the toolbar was dynamic.
For this the engineView will have a toolbarHeight bottom margin.
@evilpie evilpie mentioned this issue Sep 13, 2020
Closed
abhijitvalluri pushed a commit to abhijitvalluri/firefox2 that referenced this issue Sep 13, 2020
@Mugurell @abhijitvalluri
For mozilla-mobile#14974 - Ensure website bottom elements stay at bottom
3d74f0c 
engineView.setDynamicToolbarMaxHeight(0) vs
engineView.setDynamicToolbarMaxHeight(toolbarHeight)
ensures webpage's bottom elements are aligned to the bottom of the browser.

We also need to make sure that when the toolbar is static it does not cover the
bottom of the page - something desired when the toolbar was dynamic.
For this the engineView will have a toolbarHeight bottom margin.
abhijitvalluri pushed a commit to fork-maintainers/iceraven-browser that referenced this issue Sep 13, 2020
@Mugurell @abhijitvalluri
For mozilla-mobile#14974 - Ensure website bottom elements stay at bottom
8793acb 
engineView.setDynamicToolbarMaxHeight(0) vs
engineView.setDynamicToolbarMaxHeight(toolbarHeight)
ensures webpage's bottom elements are aligned to the bottom of the browser.

We also need to make sure that when the toolbar is static it does not cover the
bottom of the page - something desired when the toolbar was dynamic.
For this the engineView will have a toolbarHeight bottom margin.
abhijitvalluri added a commit to fork-maintainers/iceraven-browser that referenced this issue Sep 13, 2020
@abhijitvalluri
Revert "For mozilla-mobile#14974 - Ensure website bottom elements sta…
1673ea1 
…y at bottom"

This reverts commit 8793acb.
abhijitvalluri added a commit to fork-maintainers/iceraven-browser that referenced this issue Sep 13, 2020
@abhijitvalluri
Revert "For mozilla-mobile#14974 - Ensure website bottom elements sta…
94ee6c3 
…y at bottom"

This reverts commit 8793acb.
@MicroBeast
Copy link
Author

Fixed. Thank you.

Hershey's 🍫 automation moved this from In Progress to QA Review Sep 16, 2020
@SL-Lee
Copy link

SL-Lee commented Sep 17, 2020 •
edited

Possible regression caused by the fix for this issue: a bottom margin is added to fullscreen videos when toolbar position is set to the bottom and "Scroll to hide toolbar" is set to off.

Screenshot:

CC @Mugurell

@SL-Lee SL-Lee mentioned this issue Sep 17, 2020
Closed
@mcarare mcarare moved this from QA Review to Backlog in Hershey's 🍫 Sep 18, 2020
This was referenced Sep 19, 2020
Closed
Closed
@Mugurell
Copy link
Contributor

Possible regression caused by the fix for this issue: a bottom margin is added to fullscreen videos when toolbar position is set to the bottom and "Scroll to hide toolbar" is set to off.

Screenshot:

CC @Mugurell

Thanks!
Fixed in #15272

@Mugurell Mugurell reopened this Sep 28, 2020
@Mugurell Mugurell moved this from Backlog to QA Review in Hershey's 🍫 Sep 28, 2020
@Mugurell Mugurell added eng:qa:needed QA Needed and removed needs:triage Issue needs triage labels Sep 28, 2020
@sflorean
Copy link
Contributor

Verified as fixed on Nightly 9/28 with Xiaomi Redmi Note 8T (Android 9) and Samsung Galaxy Note10 (Android 10).

@sflorean sflorean removed the eng:qa:needed QA Needed label Sep 28, 2020
@sflorean sflorean added the eng:qa:verified QA Verified label Sep 28, 2020
@mcarare mcarare moved this from QA Review to Done in Hershey's 🍫 Oct 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Mugurell Mugurell

Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified Feature:Toolbar Address bar, see also Feature:Search
Projects
No open projects
Hershey's 🍫
  
Done
Milestone
No milestone
Development

No branches or pull requests
5 participants
@Mugurell @MicroBeast @SL-Lee @mcarare @sflorean