Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Bug] can't access closed tabs from tab tray if no tabs open #15324

Closed
LinAGKar opened this issue Sep 22, 2020 · 3 comments
Closed

[Bug] can't access closed tabs from tab tray if no tabs open #15324

LinAGKar opened this issue Sep 22, 2020 · 3 comments
Assignees
@ekager
Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified Feature:Tabs

Comments

@LinAGKar
Copy link

LinAGKar commented Sep 22, 2020 •
edited by data-sync-user

Steps to reproduce

  1. Close some tabs
  2. Open the tab tray

Expected behavior

The option to reopen tabs should be there.

Actual behavior

The menu button is completely gone. Most menu items pertain to the current tab, so it's fine for them, but "recently closed tabs" and "tab settings" should still be there even if no tabs are open.

Device information

  • Android device: ONEPLUS 5, LineageOS 16
  • Fenix version: Nightly 200922 16:54 (Build #2015765451)

┆Issue is synchronized with this Jira Task
@LinAGKar LinAGKar added the 🐞 bug Crashes, Something isn't working, .. label Sep 22, 2020
@github-actions github-actions bot added the needs:triage Issue needs triage label Sep 22, 2020
@ekager ekager added Feature:Tabs needs:UX-feedback Needs UX Feedback and removed needs:triage Issue needs triage labels Sep 22, 2020
@ekager
Copy link
Contributor

ekager commented Sep 22, 2020

cc @topotropic for tabs tray menu feedback

@topotropic
Copy link

Yes, that makes sense. Thanks.

Summary:
When the tab tray has 0 tabs the menu is still accessible and has the following entries: "Tab settings", "Recently closed tabs".

@topotropic topotropic removed the needs:UX-feedback Needs UX Feedback label Sep 25, 2020
@ekager ekager self-assigned this Sep 28, 2020
ekager added a commit to ekager/fenix that referenced this issue Sep 28, 2020
@ekager
For mozilla-mobile#15324 - Show tab settings and recently closed item…
773b114 
…s in menu when no tabs
ekager added a commit to ekager/fenix that referenced this issue Sep 28, 2020
@ekager
For mozilla-mobile#15324 - Show tab settings and recently closed item…
963dcd8 
…s in menu when no tabs
ekager added a commit that referenced this issue Sep 29, 2020
@ekager
For #15324 - Show tab settings and recently closed items in menu when…
01e802f 
… no tabs
@ekager ekager added the eng:qa:needed QA Needed label Sep 29, 2020
@ebalazs-sv
Copy link

ebalazs-sv commented Sep 29, 2020 •
edited

Verified as fixed on Nightly 200929 05:08 (Build #2015766697) GV 83.0a1 from 9/29 with Motorola Moto G6 (Android 8) and Nexus 5 (Android 6.0.1).
I will close this issue and remove the qa:needed label.

New related issue: #15535

@ebalazs-sv ebalazs-sv added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Sep 29, 2020
ekager added a commit to ekager/fenix that referenced this issue Sep 30, 2020
@ekager
For mozilla-mobile#15324 - Show tab settings and recently closed item…
b32142b 
…s in menu when no tabs
ekager added a commit that referenced this issue Oct 2, 2020
@ekager
For #15324 - Show tab settings and recently closed items in menu when…
07f544a 
… no tabs
@Poopooracoocoo Poopooracoocoo mentioned this issue Oct 7, 2020
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ekager ekager

Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified Feature:Tabs
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@topotropic @LinAGKar @ekager @ebalazs-sv