Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Bug] The entire tabs tray menu is displayed when switching from normal to private browsing #15535

Closed
ebalazs-sv opened this issue Sep 29, 2020 · 1 comment
Assignees
Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified Feature:PrivateBrowsing Feature:Tabs needs:triage Issue needs triage S2 Major Functionality/product severely impaired and a satisfactory workaround doesn't exist

Comments

@ebalazs-sv
Copy link

ebalazs-sv commented Sep 29, 2020

Preconditions

Do not have any opened tabs in private browsing.

Steps to reproduce

  1. Launch Fenix and open 2-3 tabs in normal browsing;
  2. Tap the tab counter to open the tabs tray;
  3. Tap the private icon;
  4. Tap the ⋮ button;

Expected behavior

The tabs tray menu when there are no opened tabs has the options: "Tab setting" and "Recently closed tab".

Actual behavior

The tabs tray menu has all the options: "Share all tabs", "Tab settings", "Recently closed tabs", "Close all tabs".

Notes

This is also reproducible when there are opened tabs in private browsing and no opened tabs in normal browsing.
20200929_162513

Device information

  • Android device: Motorola Moto G6 (Android 8);
  • Fenix version: Nightly 200929 05:08 (Build #2015766697) GV 83.0a1 from 9/29

┆Issue is synchronized with this Jira Task

@ebalazs-sv ebalazs-sv added 🐞 bug Crashes, Something isn't working, .. Feature:Tabs S2 Major Functionality/product severely impaired and a satisfactory workaround doesn't exist labels Sep 29, 2020
@github-actions github-actions bot added the needs:triage Issue needs triage label Sep 29, 2020
mcarare added a commit to mcarare/fenix that referenced this issue Sep 30, 2020
@mcarare mcarare self-assigned this Sep 30, 2020
@mcarare mcarare added this to In Dev Review in Hershey's 🍫 Sep 30, 2020
@ekager ekager added the eng:qa:needed QA Needed label Sep 30, 2020
ekager pushed a commit to ekager/fenix that referenced this issue Sep 30, 2020
@mcarare mcarare moved this from In Dev Review to QA Review in Hershey's 🍫 Oct 1, 2020
@ebalazs-sv
Copy link
Author

ebalazs-sv commented Oct 2, 2020

Verified as fixed on Nightly 201002 05:00 (Build #2015767273) GV 83.0a1 from 10/02 with Motorola Moto G6 (Android 8).
New related issue, the "Save to collection" is displayed in normal browsing tabs tray menu: #15632

@ebalazs-sv ebalazs-sv added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Oct 2, 2020
@mcarare mcarare moved this from QA Review to Done Sprint 20.20 in Hershey's 🍫 Oct 2, 2020
@mcarare mcarare moved this from Done Sprint 20.20 to Done in Hershey's 🍫 Oct 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified Feature:PrivateBrowsing Feature:Tabs needs:triage Issue needs triage S2 Major Functionality/product severely impaired and a satisfactory workaround doesn't exist
Projects
No open projects
Development

No branches or pull requests

3 participants