Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Telemetry] View Downloads #15367

Closed
7 tasks
vesta0 opened this issue Sep 24, 2020 · 4 comments
Closed
7 tasks

[Telemetry] View Downloads #15367

vesta0 opened this issue Sep 24, 2020 · 4 comments

Comments

@vesta0
Copy link
Collaborator

vesta0 commented Sep 24, 2020

Description & Product Manager / Data Scientist User Story

As a product manager, I want to understand how often users view their downloaded files in order to prioritize future download features.

What questions will you answer with this data?

  • How often users (and what % of users) open their downloads folder?
  • How often users (and what % of users) tap on a downloaded file in the browser to open it?
  • How often users (and what % of users) delete a downloaded file?

Acceptance Criteria

  • ENG files a DS JIRA request outlining their methodology.
  • DS sign off on instrumentation methodology addressing product questions.
  • Event pings can be queried via re:dash
  • Event pings can be queried via amplitude
  • We are sending telemetry events for the actions listed in the requirements
  • We have documented the telemetry
  • We have asked a data steward to review the telemetry

┆Issue is synchronized with this Jira Task

@vesta0 vesta0 added this to Telemetry in Fenix Product Backlog Sep 24, 2020
@github-actions github-actions bot added the needs:triage Issue needs triage label Sep 24, 2020
@vesta0 vesta0 added sourpatch and removed needs:triage Issue needs triage labels Sep 24, 2020
@Mugurell Mugurell self-assigned this Nov 23, 2020
@Mugurell
Copy link
Contributor

Talked offline with Kate who then confirmed with DS and Boek:

  • The newly added metrics should log events, not counters anymore
  • An an expiration date 6 months is preferred.
    Maybe if there is already related telemetry for that part of the screen / feature we can reuse the existing expiration date so that all related telemetry probes will be renewed at the same time.

Mugurell added a commit that referenced this issue Dec 15, 2020
Adds a counter for how many times the user does the following action:
- opens the Downloads section inside the app
- tap to open an item from inside Downloads / from the download dialog
- tap to delete one or more downloads at once
@Mugurell Mugurell added the eng:qa:needed QA Needed label Dec 15, 2020
Mugurell added a commit that referenced this issue Dec 16, 2020
These pings were implemented first as counters.
When changing to events "send_in_pings: - metrics" still remained causing
confusion.
This patch comes to remove this confusion and potential future issues.
@AndiAJ
Copy link
Collaborator

AndiAJ commented Dec 16, 2020

Hi, I've just checked this matter on the latest Nightly 201216 using a Google Pixel 3a (Android 11) and it seems that the corresponding event type pings aren't generated.

@Mugurell please review

@AndiAJ AndiAJ removed the eng:qa:needed QA Needed label Dec 16, 2020
@Mugurell
Copy link
Contributor

Thank you @AndiAJ.
The changes should now be available to test in the current Nightly.

@Mugurell Mugurell added the eng:qa:needed QA Needed label Dec 17, 2020
@lobontiumira
Copy link

Verified as fixed on the latest Nightly build from 12/18 using a Google Pixel (Android 10):

  • Download screen opened - ping 7bcbd887-0f8e-4b70-af5c-2b6101ce305e
{
          "category": "downloads_management",
          "name": "downloads_screen_opened",
          "timestamp": 3383
        }
  • Downloaded item opened from - ping 27c2f6eb-ccfa-4e58-bb04-c5e2a2a472b8
{
          "category": "downloads_management",
          "name": "item_opened",
          "timestamp": 4367
        }
  • Downloaded item deletion - ping b9d07d5a-54e5-4875-bfff-26abab1ced0e
{
          "category": "downloads_management",
          "name": "item_deleted",
          "timestamp": 12492
        }

Logcat - download item deleted
Logcat - download item opened
Logcat - downloads screen opened
Glean dashboard 1
Glean dashboard 2

@lobontiumira lobontiumira added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Dec 18, 2020
pkirakosyan pushed a commit to gexsi/user-agent-android that referenced this issue Aug 4, 2021
…e#16728)

Adds a counter for how many times the user does the following action:
- opens the Downloads section inside the app
- tap to open an item from inside Downloads / from the download dialog
- tap to delete one or more downloads at once
pkirakosyan pushed a commit to gexsi/user-agent-android that referenced this issue Aug 4, 2021
…bile#17071)

These pings were implemented first as counters.
When changing to events "send_in_pings: - metrics" still remained causing
confusion.
This patch comes to remove this confusion and potential future issues.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants