This repository has been archived by the owner on Feb 20, 2023. It is now read-only.
For #15367 - Cleanup download telemetry - metrics ping reference #17071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These pings were implemented first as counters. When changing to events "send_in_pings: - metrics" still remained causing confusion. This patch comes to remove this confusion and potential future issues.
Codecov Report
@@ Coverage Diff @@
## master #17071 +/- ##
=========================================
Coverage 30.78% 30.78%
Complexity 1241 1241
=========================================
Files 455 455
Lines 18666 18666
Branches 2619 2619
=========================================
Hits 5747 5747
Misses 12456 12456
Partials 463 463 Continue to review full report at Codecov.
|
pkirakosyan
pushed a commit
to gexsi/user-agent-android
that referenced
this pull request
Aug 4, 2021
…bile#17071) These pings were implemented first as counters. When changing to events "send_in_pings: - metrics" still remained causing confusion. This patch comes to remove this confusion and potential future issues.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These pings were implemented first as counters.
When changing to events "send_in_pings: - metrics" still remained causing
confusion.
This patch comes to remove this confusion and potential future issues.
The download probes will appear as before in the "events" array of the core ping.
Pull Request checklist
To download an APK when reviewing a PR: