Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Telemetry] Picture in Picture #15368

Closed
7 tasks
vesta0 opened this issue Sep 24, 2020 · 2 comments
Closed
7 tasks

[Telemetry] Picture in Picture #15368

vesta0 opened this issue Sep 24, 2020 · 2 comments

Comments

@vesta0
Copy link
Collaborator

vesta0 commented Sep 24, 2020

Description & Product Manager / Data Scientist User Story

As a product manager, I want to understand how often users discover and enable the picture in picture feature.

What questions will you answer with this data?

  • How often (and what % of users) watch a video in full screen?
  • How often (and what % of users) enable the picture in picture mode by minimizing a tap playing full screen video?

Acceptance Criteria

  • ENG files a DS JIRA request outlining their methodology.
  • DS sign off on instrumentation methodology addressing product questions.
  • Event pings can be queried via re:dash
  • Event pings can be queried via amplitude
  • We are sending telemetry events for the actions listed in the requirements
  • We have documented the telemetry
  • We have asked a data steward to review the telemetry

┆Issue is synchronized with this Jira Task

@github-actions github-actions bot added the needs:triage Issue needs triage label Sep 24, 2020
@vesta0 vesta0 added Skittle and removed needs:triage Issue needs triage labels Sep 24, 2020
@codrut-topliceanu codrut-topliceanu self-assigned this Dec 3, 2020
codrut-topliceanu pushed a commit to codrut-topliceanu/fenix that referenced this issue Dec 3, 2020
codrut-topliceanu pushed a commit to codrut-topliceanu/fenix that referenced this issue Dec 3, 2020
@Mugurell
Copy link
Contributor

Talked offline with Kate who confirmed with DS and Boek:

  • The newly added metrics should log events, not counters anymore
  • An an expiration date 6 months is preferred.
    Maybe if there is already related telemetry for that part of the screen / feature we can reuse the existing expiration date so that all related telemetry probes will be renewed at the same time.

@AndiAJ
Copy link
Collaborator

AndiAJ commented Dec 16, 2020

Hi, verified as fixed on the latest Nightly 201216 using a Google Pixel 3a (Android 11)

Ping c181bff3-1713-43ef-ba91-302a16a7608d

► ✔️ Full screen event

{
         "category": "media_state",
         "name": "fullscreen",
         "timestamp": 19186
       }

► ✔️ Enable the picture in picture mode

{
          "category": "media_state",
          "name": "picture_in_picture",
          "timestamp": 21987
        }

Logcat
Glean dashboard

@AndiAJ AndiAJ closed this as completed Dec 16, 2020
@AndiAJ AndiAJ added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Dec 16, 2020
pkirakosyan pushed a commit to gexsi/user-agent-android that referenced this issue Aug 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants