Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Fill link from clipboard opens up for same URL on every new tab #15588

Closed
nsrosenqvist opened this issue Oct 1, 2020 · 10 comments · Fixed by #15730, nathanmkaya/fenix#108, C-EO/fenix#4 or fork-house/fenix#14
Closed

Fill link from clipboard opens up for same URL on every new tab #15588

nsrosenqvist opened this issue Oct 1, 2020 · 10 comments · Fixed by #15730, nathanmkaya/fenix#108, C-EO/fenix#4 or fork-house/fenix#14
Labels
🐞 bug Crashes, Something isn't working, .. Feature:Search pin Issues, features, improvements that are still valid

Comments

@nsrosenqvist
Copy link

nsrosenqvist commented Oct 1, 2020 •
edited by data-sync-user

Steps to reproduce

  1. Copy a link from a website
  2. Open a new tab
  3. Choose to not fill from the clipboard
  4. Open yet another tab
  5. Now it asks again, and will continue asking for the same URL into infinity

Expected behavior

If you choose to not fill from clipboard then Firefox should stop nagging the user on subsequent new tabs for the same clipboard content.

Actual behavior

It nags the user for the same clipboard contents every single time a new tab is opened, requiring extra taps to open a new site.

Device information

  • Android device: Pixel 3a, Android 11
  • Fenix version: 81.1.1

┆Issue is synchronized with this Jira Task
@nsrosenqvist nsrosenqvist added the 🐞 bug Crashes, Something isn't working, .. label Oct 1, 2020
@github-actions github-actions bot added the needs:triage Issue needs triage label Oct 1, 2020
@kbrosnan kbrosnan added Feature:Search and removed needs:triage Issue needs triage labels Oct 1, 2020
vmadalin added a commit to vmadalin/fenix that referenced this issue Oct 6, 2020
@vmadalin
Fixed link from clipboard open up from same URL on every new tab mozi…
eed1970 
…lla-mobile#15588
@vmadalin vmadalin mentioned this issue Oct 6, 2020
Merged
3 tasks
@ekager
Copy link
Contributor

ekager commented Oct 6, 2020

I think this needs UX feedback before a solution.

@ekager ekager added the needs:UX-feedback Needs UX Feedback label Oct 6, 2020
@apbitner
Copy link

While I didn't work on the initial implementation, this seems to make sense to me. @ekager can you think of any reason why we'd want to persist the clipboard link notification?

@apbitner apbitner removed the needs:UX-feedback Needs UX Feedback label Oct 20, 2020
@stale
Copy link

stale bot commented Apr 18, 2021

See: #17373 This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Apr 18, 2021
@nsrosenqvist
Copy link
Author

*bump (to stop stale-bot)

@stale stale bot removed the wontfix label Apr 18, 2021
@stale
Copy link

stale bot commented Oct 15, 2021

See: #17373 This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Oct 15, 2021
@nsrosenqvist
Copy link
Author

Commenting to remove "stale" as it's still an issue

@stale stale bot removed the wontfix label Oct 15, 2021
@stale
Copy link

stale bot commented Apr 14, 2022

See: #17373 This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Apr 14, 2022
@amedyne amedyne added pin Issues, features, improvements that are still valid and removed wontfix labels Apr 19, 2022
boek pushed a commit to vmadalin/fenix that referenced this issue Dec 3, 2022
@vmadalin @boek
Fixed link from clipboard open up from same URL on every new tab mozi…
2a15457 
…lla-mobile#15588
@gabrielluong gabrielluong added the eng:reopen-for-qa Reopens and tags the issue for QA needed when the issue is merged label Dec 3, 2022
boek pushed a commit to vmadalin/fenix that referenced this issue Dec 5, 2022
@vmadalin @boek
Fixed link from clipboard open up from same URL on every new tab mozi…
3eaa81c 
…lla-mobile#15588
rocketsroger pushed a commit to vmadalin/fenix that referenced this issue Dec 5, 2022
@vmadalin @rocketsroger
For mozilla-mobile#15588: Fixed link from clipboard open up from same…
5728efe 
… URL on every new tab
@github-actions github-actions bot mentioned this issue Dec 5, 2022
Closed
4 tasks
rocketsroger pushed a commit to vmadalin/fenix that referenced this issue Dec 5, 2022
@vmadalin @rocketsroger
For mozilla-mobile#15588: Fixed link from clipboard open up from same…
aca6ebc 
… URL on every new tab
rocketsroger pushed a commit to rocketsroger/fenix that referenced this issue Dec 5, 2022
@vmadalin @rocketsroger
For mozilla-mobile#15588: Fixed link from clipboard open up from same…
5b18ff6 
… URL on every new tab
boek pushed a commit to vmadalin/fenix that referenced this issue Dec 5, 2022
@vmadalin @boek
Fixed link from clipboard open up from same URL on every new tab mozi…
e59da4a 
…lla-mobile#15588
@github-actions github-actions bot mentioned this issue Dec 5, 2022
Closed
4 tasks
boek pushed a commit to vmadalin/fenix that referenced this issue Dec 6, 2022
@vmadalin @boek
Fixed link from clipboard open up from same URL on every new tab mozi…
1ff5410 
…lla-mobile#15588
@mergify mergify bot closed this as completed in #15730 Dec 6, 2022
mergify bot pushed a commit that referenced this issue Dec 6, 2022
@vmadalin @mergify
Fixed link from clipboard open up from same URL on every new tab #15588
1b63240
@github-actions github-actions bot added this to the 109 milestone Dec 6, 2022
@github-actions github-actions bot reopened this Dec 6, 2022
@github-actions github-actions bot added eng:qa:needed QA Needed and removed eng:reopen-for-qa Reopens and tags the issue for QA needed when the issue is merged labels Dec 6, 2022
@AdinaPetridean
Copy link

This issue is still reproducible following the steps above on the latest Nightly 109.0a1 with Motorola Moto G9 plus (Android 11).

@vmadalin I will remove qa needed label for further investigation. Thanks!

clipboard111.mp4

@AdinaPetridean AdinaPetridean removed the eng:qa:needed QA Needed label Dec 7, 2022
@gabrielluong
Copy link
Member

@boek Since you landed a fix for this in #15730, could you investigate further since the issue is still reproducible?

@gabrielluong gabrielluong removed this from the 109 milestone Dec 12, 2022
@cpeterso cpeterso changed the title [Bug] Fill link from clipboard opens up for same URL on every new tab Fill link from clipboard opens up for same URL on every new tab Dec 27, 2022
@cpeterso
Copy link

Moved to bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1807726

Change performed by the Move to Bugzilla add-on.

This was referenced Jan 15, 2023
Merged
Merged
Merged
JohanLorenzo pushed a commit to mozilla-mobile/firefox-android that referenced this issue Feb 14, 2023
@vmadalin @mergify
[fenix] Fixed link from clipboard open up from same URL on every new …
56e0965 
…tab mozilla-mobile/fenix#15588
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
🐞 bug Crashes, Something isn't working, .. Feature:Search pin Issues, features, improvements that are still valid
Projects
None yet
Milestone
No milestone
8 participants
@kbrosnan @cpeterso @gabrielluong @nsrosenqvist @apbitner @ekager @amedyne @AdinaPetridean