Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Bug] "Save to collection" is displayed in tabs tray menu when there are no open tabs in normal browsing #15632

Closed
ebalazs-sv opened this issue Oct 2, 2020 · 1 comment
Closed

[Bug] "Save to collection" is displayed in tabs tray menu when there are no open tabs in normal browsing #15632

ebalazs-sv opened this issue Oct 2, 2020 · 1 comment
Assignees
@mcarare
Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified
Projects
Hershey's 🍫

Comments

@ebalazs-sv
Copy link

ebalazs-sv commented Oct 2, 2020 •
edited by data-sync-user

Preconditions

Do not have any opened tabs in normal browsing.

Steps to reproduce

  1. Launch Fenix and open 2-3 tabs in private browsing;
  2. Tap the tab counter to open the tabs tray;
  3. Tap the normal browsing icon;
  4. Tap the ⋮ button;

Expected behavior

The tabs tray menu when there are no opened tabs has the options: "Tab setting" and "Recently closed tab".

Actual behavior

The tabs tray menu has the options: "Save to collection", "Tab settings", "Recently closed tabs".

Notes

This is not reproducible when there are no opened tabs in private browsing and no opened tabs in normal browsing.

Device information

  • Android device: Motorola Moto G6 (Android 8);
  • Fenix version: Nightly 201002 05:00 (Build #2015767273) GV 83.0a1 from 10/02

┆Issue is synchronized with this Jira Task
@ebalazs-sv ebalazs-sv added the 🐞 bug Crashes, Something isn't working, .. label Oct 2, 2020
@github-actions github-actions bot added the needs:triage Issue needs triage label Oct 2, 2020
@ebalazs-sv ebalazs-sv mentioned this issue Oct 2, 2020
Closed
@mcarare mcarare self-assigned this Oct 2, 2020
@mcarare mcarare added this to In Progress in Hershey's 🍫 Oct 2, 2020
@mcarare mcarare moved this from In Progress to In Dev Review in Hershey's 🍫 Oct 2, 2020
mcarare added a commit to mcarare/fenix that referenced this issue Oct 2, 2020
@mcarare
For mozilla-mobile#15632: Improve checking open tabs logic to show co…
9350e0e 
…llection button.

Check now considers selected tab tray mode.
gabrielluong pushed a commit that referenced this issue Oct 3, 2020
@mcarare @gabrielluong
For #15632: Improve checking open tabs logic to show collection button.
07748f6 
Check now considers selected tab tray mode.
@mcarare mcarare moved this from In Dev Review to QA Review in Hershey's 🍫 Oct 5, 2020
@mcarare mcarare added the eng:qa:needed QA Needed label Oct 5, 2020
ekager pushed a commit to ekager/fenix that referenced this issue Oct 5, 2020
@mcarare @ekager
For mozilla-mobile#15632: Improve checking open tabs logic to show co…
e6d78cf 
…llection button.

Check now considers selected tab tray mode.
@lobontiumira lobontiumira mentioned this issue Oct 6, 2020
Closed
@lobontiumira
Copy link

lobontiumira commented Oct 6, 2020 •
edited

Verified that the "Save to collection" option isn't displayed when there are no opened tabs.
Tested on 10/6 Nightly build, and on RC 81.1.3 with Samsung Galaxy Tab S6 (Android 10), and Google Pixel (Android 10).

Untitled

@lobontiumira lobontiumira added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Oct 6, 2020
@mcarare mcarare moved this from QA Review to Done Sprint 20.20 in Hershey's 🍫 Oct 7, 2020
@mcarare mcarare moved this from Done Sprint 20.20 to Done in Hershey's 🍫 Oct 12, 2020
@kbrosnan kbrosnan removed the needs:triage Issue needs triage label Nov 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mcarare mcarare

Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified
Projects
No open projects
Hershey's 🍫
  
Done
Milestone
No milestone
Development

No branches or pull requests
4 participants
@kbrosnan @lobontiumira @ebalazs-sv @mcarare