Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Bug] Custom search providers deleted after upgrade to 81.1.12 Build 2015767043 #15711

Closed
lordgurke opened this issue Oct 5, 2020 · 4 comments
Assignees
Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified Feature:Search Feature:SearchProvider

Comments

@lordgurke
Copy link

lordgurke commented Oct 5, 2020

Steps to reproduce

  • Configure custom search providers in Firefox
  • Upgrade to Firefox 81.1.12 (Build 2015767043) via Google Play Store

Expected behavior

  • Custom search providers are retained

Actual behavior

  • The default search provider is kept, all other search providers are gone without any trace

Device information

  • Android device: HTC 10, Android 8
  • Fenix version: 81.1.2, Build 2015767043.
    Previous version unknwon.

┆Issue is synchronized with this Jira Task

@lordgurke lordgurke added the 🐞 bug Crashes, Something isn't working, .. label Oct 5, 2020
@github-actions github-actions bot added the needs:triage Issue needs triage label Oct 5, 2020
@ysooqe
Copy link

ysooqe commented Oct 6, 2020

They are not gone "without any trace". I do not see them anymore aswell, but when I try to add a custom search provider with the same name as one that I know I had added already, it says that I can't add it because a provider with the same name already exists.
Also, adding an entirely new custom provider does not work, as soon as you hit the confirm action when trying to add a new provider, it does not show up under search providers.

@sflorean
Copy link
Contributor

sflorean commented Oct 9, 2020

@mcarare I made an update from Nightly 10/08 to Nightly 10/09 and the custom search engines Youtube and Reddit weren't displayed after the update. The only engines still listed was CNN - set as default on Nightly 10/08.

Verified also #15741 and it is fixed on Nightly 10/09.

@sflorean sflorean removed the eng:qa:needed QA Needed label Oct 9, 2020
@sflorean
Copy link
Contributor

sflorean commented Oct 9, 2020

@mcarare yes, they appear but an update should keep them on the main list if they were previously added. I will check again, on Monday 10/12, and file a new issue if the result is the same.

Update: updated with Nightly 10/12 and the custom engines were displayed.

@sflorean sflorean closed this as completed Oct 9, 2020
@sflorean sflorean added the eng:qa:verified QA Verified label Oct 9, 2020
@mcarare mcarare self-assigned this Oct 12, 2020
@mcarare mcarare added this to Done in Hershey's 🍫 Oct 12, 2020
@mcarare mcarare moved this from Done to Done Sprint 20.21 in Hershey's 🍫 Oct 12, 2020
liuche pushed a commit that referenced this issue Oct 15, 2020
Co-authored-by: mcarare <mihai.carare.dev@gmail.com>
@ebalazs-sv
Copy link

Verified as fixed on Beta 82.0.0-beta.6 (Build #2015769931) GV 82.0 and Release 82.1.0-rc.1 (Build #2015769955) GV 82.0 from 10/16 with Pixel 2 (Android 9), Xiaomi Mi Pad 2 (Android 5.1), OnePlus A3 (Android 6.0.1).

@mcarare mcarare moved this from Done Sprint 20.21 to Done in Hershey's 🍫 Oct 30, 2020
@kbrosnan kbrosnan removed the needs:triage Issue needs triage label Nov 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified Feature:Search Feature:SearchProvider
Projects
No open projects
Development

No branches or pull requests

7 participants