Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Uplift for 15711 - Custom search providers deleted after upgrade to 81.1.12 Build 2015767043 #15938

Merged
merged 1 commit into from Oct 15, 2020

Conversation

st3fan
Copy link
Contributor

@st3fan st3fan commented Oct 15, 2020

Pull Request checklist

  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

@st3fan st3fan requested a review from liuche October 15, 2020 21:13
@codecov-io
Copy link

codecov-io commented Oct 15, 2020

Codecov Report

Merging #15938 into releases/v82.0.0 will decrease coverage by 0.00%.
The diff coverage is 80.00%.

Impacted file tree graph

@@                  Coverage Diff                   @@
##             releases/v82.0.0   #15938      +/-   ##
======================================================
- Coverage               29.21%   29.21%   -0.01%     
  Complexity               1159     1159              
======================================================
  Files                     456      456              
  Lines                   18654    18654              
  Branches                 2414     2414              
======================================================
- Hits                     5450     5449       -1     
- Misses                  12820    12822       +2     
+ Partials                  384      383       -1     
Impacted Files Coverage Δ Complexity Δ
...mponents/searchengine/FenixSearchEngineProvider.kt 58.92% <80.00%> (-0.90%) 15.00 <1.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 39ac009...968192b. Read the comment docs.

Copy link
Contributor

@liuche liuche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uplift

@gabrielluong gabrielluong added the pr:approved PR that has been approved label Oct 15, 2020
@liuche liuche merged commit d2d8f4e into releases/v82.0.0 Oct 15, 2020
@bors bors bot deleted the st3fan/Release82b6 branch October 15, 2020 22:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr:approved PR that has been approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants