Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Intermittent UI test failure - MediaNotificationTest.videoPlaybackSystemNotificationTest #15754

Closed
jonalmeida opened this issue Oct 7, 2020 · 9 comments
Assignees
Labels
eng:disabled-test For any test that has been disabled eng:intermittent-test Evil test failures that only happen now-and-then and are a productivity killer eng:ui-test UI Tests 🙅 waiting Issues that are blocked or has dependencies that are not ready

Comments

@jonalmeida
Copy link
Contributor

jonalmeida commented Oct 7, 2020

Firebase Test Run:

https://console.firebase.google.com/project/moz-fenix/testlab/histories/bh.66b7091e15d53d45/matrices/4983241498387819676

Stacktrace:

  • See the results at the link for the tests:
    • audioPlaybackSystemNotificationTest
    • mediaSystemNotificationInPrivateModeTest
    • tabMediaControlButtonTest

Build:

**All media tests are now re-enabled, except the videoPlaybackSystemNotificationTest which is still waiting for mozilla-mobile/android-components#9748

┆Issue is synchronized with this Jira Task

@jonalmeida jonalmeida added eng:intermittent-test Evil test failures that only happen now-and-then and are a productivity killer eng:ui-test UI Tests labels Oct 7, 2020
@github-actions github-actions bot added the needs:triage Issue needs triage label Oct 7, 2020
jonalmeida added a commit to jonalmeida/fenix that referenced this issue Oct 7, 2020
@jonalmeida
Copy link
Contributor Author

Copied over from: #15734 (comment)


There are a few tests that are failing, so I ended up testing with tabMediaControlButtonTest from the following list:

  • audioPlaybackSystemNotificationTest - apparent intermittent; consistent failing now
  • mediaSystemNotificationInPrivateModeTest - hard to reproduce; need older API level device that I do not have.
  • tabMediaControlButtonTest - should be consistent.

I tried a bunch of GV builds to see what the media failure is but I've come across some confusing results. Using the latest AC (3e68528074) with these GV Nightly versions tested:

  • 83.0.20201005093214 - ❌ (monday's GV after media regression was fixed)
  • 83.0.20201001094020 - ❌ (GV media breakage)
  • 83.0.20200930092918 - ❌ (before GV media breakage; expected to fail)
  • 83.0.20200929094055 - ❌ (second before media breakage; expected to fail)

GV media regression was fixed (feature was disabled) in 20201001094020 so the 83.0.20201005093214 should have worked.

jonalmeida added a commit to jonalmeida/fenix that referenced this issue Oct 7, 2020
@jonalmeida
Copy link
Contributor Author

Adding videoPlaybackSystemNotificationTest to the list of ignored tests which seem to fail (intermittently though).

@jonalmeida
Copy link
Contributor Author

jonalmeida commented Oct 8, 2020

To expand on comment 2, I was able to see audioPlaybackSystemNotificationTest consistently although it was called out as an intermittent failure.

You can read more about that test analysis here: #15734 (comment)


For mediaSystemNotificationInPrivateModeTest it seems like it asserts on the Android OS system media notification which was hard for me to trust with my Android 11 device that has a new UI design for the system notifications - for that reason I didn't look further into why that test was failing.


For tabMediaControlButtonTest, previously we saw this test legitimately fail and catch a regression. Visually, this test was seen trying to press the play button and that would fail.

With the regression fixed, we were able to land a fixed GV version. Now however, we are seeing the same test fail, but visually watching the test run, we can see the media content play, but the assertion always fails.

@sv-ohorvath sv-ohorvath added eng:disabled-test For any test that has been disabled and removed needs:triage Issue needs triage labels Oct 13, 2020
@sv-ohorvath sv-ohorvath self-assigned this Feb 8, 2021
@sv-ohorvath
Copy link
Contributor

sv-ohorvath commented Feb 16, 2021

Tried to fix the tests but found there is an open bug blocking media notifications for some videos: mozilla-mobile/android-components#9748. We need to wait for that to be fixed.

@sv-ohorvath
Copy link
Contributor

All media tests are now re-enabled, except the videoPlaybackSystemNotificationTest which is still waiting for mozilla-mobile/android-components#9748

@sv-ohorvath sv-ohorvath changed the title Intermittent UI test failure - MediaNotificationTest Intermittent UI test failure - MediaNotificationTest.videoPlaybackSystemNotificationTest Jun 8, 2021
@mozilla-mobile mozilla-mobile deleted a comment from AndiAJ Jul 13, 2021
@mozilla-mobile mozilla-mobile deleted a comment from AndiAJ Jul 13, 2021
pkirakosyan pushed a commit to gexsi/user-agent-android that referenced this issue Aug 11, 2021
@stale
Copy link

stale bot commented Jan 9, 2022

See: #17373 This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Jan 9, 2022
@sv-ohorvath
Copy link
Contributor

Lets keep it.

@stale stale bot removed the wontfix label Jan 10, 2022
@sv-ohorvath
Copy link
Contributor

sv-ohorvath commented Jun 2, 2022

After a bit more investigation I've found that videos muted or without sound don't show a notification, I left a new comment on mozilla-mobile/android-components#9748.
The video asset used in this test didn't have sound so I replaced it with a new file which now looks like it could fix the problem, but while running on Firebase I hit the same ANR reported here: #24047 so I'll leave it disabled until we find a fix for that.

Latest test runs (with ANR results): https://github.com/mozilla-mobile/fenix/runs/6707769666

@sv-ohorvath
Copy link
Contributor

The tests were re-enabled in #27060

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
eng:disabled-test For any test that has been disabled eng:intermittent-test Evil test failures that only happen now-and-then and are a productivity killer eng:ui-test UI Tests 🙅 waiting Issues that are blocked or has dependencies that are not ready
Projects
None yet
Development

No branches or pull requests

2 participants