Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Bug] Space between tab tray grid item borders #16323

Closed
Mugurell opened this issue Nov 2, 2020 · 3 comments
Closed

[Bug] Space between tab tray grid item borders #16323

Mugurell opened this issue Nov 2, 2020 · 3 comments
Labels
🐞 bug Crashes, Something isn't working, .. E1 Estimation Point: trivial, less than half day eng:qa:verified QA Verified Feature:Tabs

Comments

@Mugurell
Copy link
Contributor

Mugurell commented Nov 2, 2020 •
edited by data-sync-user

As a followup to #15968 which added a new border,
there is a small gap between the borders of the items shown:
image

The dimensions follow the specs but I think this is happening because
Currently we are using a 8dp cornerRadius for both the inner and the other borders.
I think a solution would be to use

Proposed solutions:

10dp cornerRadius for the outer border ⌄

image

6dp cornerRadius for the inner border ⌄

image

┆Issue is synchronized with this Jira Task
@Mugurell Mugurell added the 🐞 bug Crashes, Something isn't working, .. label Nov 2, 2020
@Mugurell
Copy link
Contributor Author

Mugurell commented Nov 2, 2020

@topotropic Does the solutions above sounds okay with you?

@github-actions github-actions bot added the needs:triage Issue needs triage label Nov 2, 2020
@Mugurell Mugurell added needs:UX-feedback Needs UX Feedback Feature:Tabs and removed needs:triage Issue needs triage labels Nov 2, 2020
@gabrielluong gabrielluong added this to Inbox in Engineering triage via automation Nov 2, 2020
@gabrielluong gabrielluong moved this from Inbox to Grid View in Engineering triage Nov 2, 2020
@topotropic
Copy link

thanks @Mugurell, let's go with 10dp cornerRadius for the outer border

@topotropic topotropic removed the needs:UX-feedback Needs UX Feedback label Nov 3, 2020
gabrielluong pushed a commit that referenced this issue Nov 4, 2020
@Mugurell
For #16323 - Use 10dp corner radius for the selected outer border of …
1358e09 
…a grid item (#16364)

This would ensure the corners of the inner and outer borders are aligned, with
no empty gap between them.
@gabrielluong gabrielluong added the eng:qa:needed QA Needed label Nov 4, 2020
@AndiAJ
Copy link
Collaborator

AndiAJ commented Nov 5, 2020

Hi, verified as fixed on the latest Nightly Build 201105 using a Google Pixel 3a (Android 11)

► Portrait screenshot
rsz_screenshot_20201105-095412222

► Landscape screenshot
rsz_screenshot_20201105-09542555555

@AndiAJ AndiAJ closed this as completed Nov 5, 2020
@AndiAJ AndiAJ added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Nov 5, 2020
@codrut-topliceanu codrut-topliceanu added the E1 Estimation Point: trivial, less than half day label Nov 5, 2020
@gabrielluong gabrielluong removed this from Grid View in Engineering triage Nov 5, 2020
@lobontiumira lobontiumira mentioned this issue Nov 11, 2020
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
🐞 bug Crashes, Something isn't working, .. E1 Estimation Point: trivial, less than half day eng:qa:verified QA Verified Feature:Tabs
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@topotropic @gabrielluong @Mugurell @AndiAJ @codrut-topliceanu