Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

For #16323 - Slightly larger corner radius for the outer border of a grid item #16364

Merged
merged 1 commit into from
Nov 4, 2020
Merged

For #16323 - Slightly larger corner radius for the outer border of a grid item #16364

merged 1 commit into from
Nov 4, 2020

Conversation

Mugurell
Copy link
Contributor

@Mugurell Mugurell commented Nov 4, 2020

This would ensure the corners of the inner and outer borders are aligned, with
no empty space between them.

image

Pull Request checklist

  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR does not include any a11y user facing features.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

…grid item

This would ensure the corners of the inner and outer borders are aligned, with
no empty space between them.
@Mugurell Mugurell requested review from a team as code owners November 4, 2020 10:30
Copy link
Contributor

@mcarare mcarare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gabrielluong gabrielluong merged commit 1358e09 into mozilla-mobile:master Nov 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants