Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Bug] Prefill arrow (in search suggestions) should be facing downward in bottom toolbar mode #16483

Closed
violasong opened this issue Nov 10, 2020 · 1 comment
Closed

[Bug] Prefill arrow (in search suggestions) should be facing downward in bottom toolbar mode #16483

violasong opened this issue Nov 10, 2020 · 1 comment
Assignees
@mcarare
Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified needs:ac Needs Android Component Work

Comments

@violasong
Copy link
Collaborator

violasong commented Nov 10, 2020 •
edited by data-sync-user

Right now when you enter something into the address bar, the pre-fill arrows are pointing to the top-left regardless of toolbar position. We should have them point to the bottom-left instead when the user has the toolbar positioned at the bottom. E.g. ↙️

Thanks to @antlam for noticing this!

image

┆Issue is synchronized with this Jira Task
@violasong violasong added the 🐞 bug Crashes, Something isn't working, .. label Nov 10, 2020
@github-actions github-actions bot added the needs:triage Issue needs triage label Nov 10, 2020
@mcarare mcarare self-assigned this Dec 2, 2020
@mcarare mcarare added AC-by-Fenix needs:ac Needs Android Component Work labels Dec 2, 2020
@mcarare mcarare mentioned this issue Dec 2, 2020
Closed
mcarare added a commit to mcarare/fenix that referenced this issue Dec 2, 2020
@mcarare
For mozilla-mobile#16483: Rotate edit arrow when toolbar position is …
afc1c0c 
…set to bottom.
mcarare added a commit to mcarare/fenix that referenced this issue Dec 16, 2020
@mcarare
For mozilla-mobile#16483: Rotate edit arrow when toolbar position is …
6c0c4f3 
…set to bottom.
mcarare added a commit to mcarare/fenix that referenced this issue Dec 16, 2020
@mcarare
For mozilla-mobile#16483: Rotate edit arrow when toolbar position is …
565ca18 
…set to bottom.
mcarare added a commit to mcarare/fenix that referenced this issue Dec 16, 2020
@mcarare
For mozilla-mobile#16483: Rotate edit arrow when toolbar position is …
58fa214 
…set to bottom.
mcarare added a commit that referenced this issue Dec 16, 2020
@mcarare
For #16483: Rotate edit arrow when toolbar position is set to bottom.
04bd9c6
@mcarare mcarare added the eng:qa:needed QA Needed label Dec 16, 2020
@abodea
Copy link
Member

abodea commented Dec 18, 2020 •
edited

Verified as fixed on 85.0.0-beta.2 with Google Pixel 4 XL (11), Samsung Galaxy S10+ (10) OnePlus A3 (Android 6.0.1).
@mcarare I think we can remove the needs:ac too, right?

@abodea abodea closed this as completed Dec 18, 2020
@abodea abodea added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed needs:triage Issue needs triage labels Dec 18, 2020
pkirakosyan pushed a commit to gexsi/user-agent-android that referenced this issue Aug 4, 2021
@mcarare @pkirakosyan
For mozilla-mobile#16483: Rotate edit arrow when toolbar position is …
8a5381a 
…set to bottom.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mcarare mcarare

Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified needs:ac Needs Android Component Work
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@violasong @abodea @mcarare