Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Bug] No snackbar is displayed when a tab is closed #1694

Closed
lobontiumira opened this issue Apr 17, 2019 · 8 comments
Closed

[Bug] No snackbar is displayed when a tab is closed #1694

lobontiumira opened this issue Apr 17, 2019 · 8 comments
Assignees
Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified eng:ready Ready for engineering Feature:HomeScreen Feature:Tabs P1 Current sprint

Comments

@lobontiumira
Copy link

lobontiumira commented Apr 17, 2019

Steps to reproduce

  1. On the home screen, go to Current session.
  2. Close a tab.

Expected behavior

There is no snackbar displayed.

Actual behavior

A snackbar with an "Undo" button should be displayed.

Device information

  • Android device: Sony Xperia Z5 (Android 7.1.1)
  • Fenix version: 1.0.1916 (Build#11061212)

2019UNITO-UNDERSCORE!04!UNITO-UNDERSCORE!17!UNITO-UNDERSCORE!15!UNITO-UNDERSCORE!59!UNITO-UNDERSCORE!42!

┆Issue is synchronized with this Jira Task

@vesta0
Copy link
Collaborator

vesta0 commented Apr 30, 2019

@softvision-miralobontiu is there an undo button in the UX specs?

@yoasif
Copy link
Contributor

yoasif commented Apr 30, 2019

Fennec shows an undo snackbar once a tab is closed, FYI.

@vesta0 vesta0 added the needs:UX-feedback Needs UX Feedback label Apr 30, 2019
@vesta0 vesta0 added this to the Bugs milestone Apr 30, 2019
@vesta0
Copy link
Collaborator

vesta0 commented May 1, 2019

I don't think this is necessary (they can always access it from history if it was closed accidentally) but I will leave it to UX to think through FYI @lime124

@yoasif
Copy link
Contributor

yoasif commented May 1, 2019

At least on my Moto G, it is far too easy to close a tab while simply trying to scroll through the home view, so a snackbar would really be appreciated.

The only other browser on Android (besides Focus) that I have seen that doesn't use a snackbar to allow a user to reopen closed tabs is Samsung Internet, and it has a menu option in the tab switcher to "reopen closed tab" (a little like Firefox Desktop's undo closed tab in the tab menu).

History feels far too hard to discover on accidental close, at least imo.

@topotropic
Copy link

Let's display a undo snackbar – please use the same display time as we use for other undo snackbars (for example the delete bookmark one).

@lime124 lime124 added eng:ready Ready for engineering and removed needs:UX-feedback Needs UX Feedback labels May 2, 2019
@lime124
Copy link
Collaborator

lime124 commented May 2, 2019

@vesta0 i think this should be a p1 as this creates a pretty bad experience when people accidentally close their tabs. it's not data loss b/c it can be recovered from history, but when it's easy to make mistakes we should make it easy to recover.

@ekager
Copy link
Contributor

ekager commented May 2, 2019

Part of the Collections Spec is a Snackbar with UNDO action for Collections and Tabs within collections. It will be simple to also hook this action up for the tabs in the normal tab view.

@ekager ekager self-assigned this May 2, 2019
ekager added a commit to ekager/fenix that referenced this issue May 2, 2019
@vesta0 vesta0 added the P1 Current sprint label May 3, 2019
@vesta0 vesta0 modified the milestones: Bugs, Sprint 5-1 (Milestone 5) May 3, 2019
@vesta0 vesta0 added this to High priority backlog (not in the current sprint) in Fenix Sprint Kanban May 3, 2019
@vesta0 vesta0 moved this from High priority backlog (not in the current sprint) to Ready for Dev in Fenix Sprint Kanban May 3, 2019
@ekager ekager moved this from Ready for Dev to Ready for QA in Fenix Sprint Kanban May 3, 2019
@ekager ekager added the eng:qa:needed QA Needed label May 3, 2019
@bsurd
Copy link

bsurd commented May 6, 2019

The snackbar is now displayed whenever closing a tab. Logged #2289 for the undo action as it does not work as intended.

@bsurd bsurd closed this as completed May 6, 2019
@bsurd bsurd added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels May 6, 2019
@bsurd bsurd moved this from Ready for QA to Done in Fenix Sprint Kanban May 6, 2019
@bifleming bifleming removed this from Done in Fenix Sprint Kanban May 7, 2019
@data-sync-user data-sync-user changed the title [Bug] No snackbar is displayed when a tab is closed FNX2-17330 ⁃ [Bug] No snackbar is displayed when a tab is closed Aug 4, 2020
@data-sync-user data-sync-user changed the title FNX2-17330 ⁃ [Bug] No snackbar is displayed when a tab is closed FNX3-15747 ⁃ [Bug] No snackbar is displayed when a tab is closed Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX3-15747 ⁃ [Bug] No snackbar is displayed when a tab is closed FNX-5190 ⁃ [Bug] No snackbar is displayed when a tab is closed Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX-5190 ⁃ [Bug] No snackbar is displayed when a tab is closed [Bug] No snackbar is displayed when a tab is closed May 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified eng:ready Ready for engineering Feature:HomeScreen Feature:Tabs P1 Current sprint
Projects
None yet
Development

No branches or pull requests

9 participants