Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Bug] Undo from close tab snackbar does not bring back your tab if used multiple times #2289

Closed
bsurd opened this issue May 6, 2019 · 1 comment
Closed

[Bug] Undo from close tab snackbar does not bring back your tab if used multiple times #2289

bsurd opened this issue May 6, 2019 · 1 comment
Assignees
@ekager
Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified P1 Current sprint
Milestone
Sprint 5-2 (Miles...

Comments

@bsurd
Copy link

bsurd commented May 6, 2019 •
edited by data-sync-user
Loading

Steps to reproduce

  1. Open any page.
  2. Tap on the tab counter.
  3. Close the tab.
  4. In the snackbar tap on undo.
  5. Repeat steps 3 and 4.

Expected behavior

The tab is restored again.

Actual behavior

The tab is no longer restored.

Device information

  • Android device:
    • Samsung Galaxy S8 (Android 9)
    • Google Pixel (Android 9)
    • HTC Desire 820 (Android 6.0.1)
  • Fenix version: 5/6

20190506UNITO-UNDERSCORE!105118!

┆Issue is synchronized with this Jira Task
@bsurd bsurd added the 🐞 bug Crashes, Something isn't working, .. label May 6, 2019
@bsurd bsurd mentioned this issue May 6, 2019
Closed
@ekager ekager self-assigned this May 6, 2019
ekager added a commit to ekager/fenix that referenced this issue May 6, 2019
@ekager
For mozilla-mobile#2289 - Null out pending job on undo
e168cec
colintheshots pushed a commit that referenced this issue May 6, 2019
@ekager @colintheshots
For #2289 - Null out pending job on undo (#2303)
37bae3b
@vesta0 vesta0 added the P1 Current sprint label May 8, 2019
@vesta0 vesta0 added this to the Sprint 5-1 (Milestone 5) milestone May 8, 2019
@vesta0 vesta0 added this to In Progress in Fenix Sprint Kanban May 8, 2019
@ekager ekager added the eng:qa:needed QA Needed label May 13, 2019
@project-bot project-bot bot moved this from In Progress to Ready for QA in Fenix Sprint Kanban May 13, 2019
@sv-ohorvath
Copy link
Contributor

Verified as fixed on the 5/14 build.
Samsung Galaxy S8 (Android 9)
HTC Desire 820 (Android 6.0.1)

@sv-ohorvath sv-ohorvath added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels May 15, 2019
@sv-ohorvath sv-ohorvath moved this from Ready for QA to Done in Fenix Sprint Kanban May 15, 2019
@data-sync-user data-sync-user changed the title [Bug] Undo from close tab snackbar does not bring back your tab if used multiple times FNX2-17854 ⁃ [Bug] Undo from close tab snackbar does not bring back your tab if used multiple times Aug 5, 2020
@data-sync-user data-sync-user changed the title FNX2-17854 ⁃ [Bug] Undo from close tab snackbar does not bring back your tab if used multiple times FNX3-16207 ⁃ [Bug] Undo from close tab snackbar does not bring back your tab if used multiple times Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX3-16207 ⁃ [Bug] Undo from close tab snackbar does not bring back your tab if used multiple times FNX-5571 ⁃ [Bug] Undo from close tab snackbar does not bring back your tab if used multiple times Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX-5571 ⁃ [Bug] Undo from close tab snackbar does not bring back your tab if used multiple times [Bug] Undo from close tab snackbar does not bring back your tab if used multiple times May 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ekager ekager

Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified P1 Current sprint
Projects
None yet
Milestone
Sprint 5-2 (Milestone 5)
Development

No branches or pull requests
6 participants
@sv-ohorvath @bsurd @ekager @vesta0 @bifleming @data-sync-user