Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Fix systemUiVisibility deprecations in ThemeManager #17808

Closed
Tracked by #17810
Amejia481 opened this issue Feb 3, 2021 · 13 comments
Closed
Tracked by #17810

Fix systemUiVisibility deprecations in ThemeManager #17808

Amejia481 opened this issue Feb 3, 2021 · 13 comments
Assignees
Labels
Android:11 Issues specific to Android 11 - API 30 eng:health Improve code health help wanted Help wanted from a contributor. More complex than good first issue.

Comments

@Amejia481
Copy link
Contributor

Amejia481 commented Feb 3, 2021

Deprecation docs:
https://developer.android.com/reference/android/view/View#getSystemUiVisibility()
https://developer.android.com/reference/android/view/View#SYSTEM_UI_FLAG_LIGHT_NAVIGATION_BAR
https://developer.android.com/reference/android/view/View#SYSTEM_UI_FLAG_LIGHT_STATUS_BAR

window.decorView.systemUiVisibility or SYSTEM_UI_FLAG_LIGHT_STATUS_BAR

window.decorView.systemUiVisibility =

window.decorView.systemUiVisibility = window.decorView.systemUiVisibility and

window.decorView.systemUiVisibility = window.decorView.systemUiVisibility and

Similar mozilla-mobile/android-components#9554

┆Issue is synchronized with this Jira Task

@Amejia481 Amejia481 added eng:health Improve code health Android:11 Issues specific to Android 11 - API 30 labels Feb 3, 2021
@github-actions github-actions bot added the needs:triage Issue needs triage label Feb 3, 2021
@Amejia481 Amejia481 added help wanted Help wanted from a contributor. More complex than good first issue. and removed needs:triage Issue needs triage labels Feb 3, 2021
@Amejia481 Amejia481 mentioned this issue Feb 3, 2021
6 tasks
@CharlesAdam
Copy link
Contributor

CharlesAdam commented Feb 17, 2021

Can you please assign me to this issue?

@Amejia481
Copy link
Contributor Author

Sure!

@CharlesAdam
Copy link
Contributor

I'm trying to update the compileSdkVersion so I can use the new features to solve this issue since they are only available at API 30 however some errors are appearing whenever the projects try to build as in this screenshot:
image

@CharlesAdam
Copy link
Contributor

@Amejia481 It seems some methods are not being overridden because now activities cannot be null as in this link: https://developer.android.com/reference/android/app/Application.ActivityLifecycleCallbacks#onActivityCreated(android.app.Activity,%20android.os.Bundle)
So we just need to remove the safe calls so the app can be built, however, should this be another issue?

@cadeyrn
Copy link
Contributor

cadeyrn commented Feb 18, 2021

should this be another issue?

There is already a PR: #17809

@CharlesAdam
Copy link
Contributor

@cadeyrn thanks for the info, I will generate the branch from this PR 😃

@Amejia481
Copy link
Contributor Author

Thank you @cadeyrn and CharlesAdam, we are doing some round of tests to find any possible issue before land it.

@mcarare
Copy link
Contributor

mcarare commented Mar 18, 2021

@CharlesAdam are you still working on this?

@CharlesAdam
Copy link
Contributor

CharlesAdam commented Mar 18, 2021

@mcarare Yes, I sent a PR back then but it shouldn't be merged before the base branch, I'll update and set it up for the merge

@mcarare mcarare added the 🙅 waiting Issues that are blocked or has dependencies that are not ready label May 12, 2021
@mcarare
Copy link
Contributor

mcarare commented May 12, 2021

This is still waiting on a stable version for https://developer.android.com/jetpack/androidx/releases/core 1.5.0 (it has reached the RC stage).

@wbillan
Copy link

wbillan commented Jun 8, 2021

1.5.0 stable was released May 18

@mcarare mcarare added this to Technical Debt (top 10) in Android Team Backlog Staging Board Jun 8, 2021
@mcarare
Copy link
Contributor

mcarare commented Jun 30, 2021

@CharlesAdam Do you want to continue working on this?

@mcarare mcarare added this to Ready for Engineering (min-5 ; max-22) in Android Engineering Team Kanban board via automation Jul 1, 2021
@mcarare mcarare moved this from Ready for Engineering (min-5 ; max-22) to In Development (WIP limit - 15) in Android Engineering Team Kanban board Jul 1, 2021
@mcarare mcarare assigned mcarare and unassigned CharlesAdam Jul 1, 2021
mcarare added a commit to mcarare/fenix that referenced this issue Jul 1, 2021
mcarare added a commit to mcarare/fenix that referenced this issue Jul 2, 2021
@mcarare mcarare removed the 🙅 waiting Issues that are blocked or has dependencies that are not ready label Jul 2, 2021
@mcarare mcarare removed this from Technical Debt (top 10) in Android Team Backlog Staging Board Jul 2, 2021
mcarare added a commit to mcarare/fenix that referenced this issue Jul 5, 2021
@mcarare mcarare moved this from In Development (WIP limit - 15) to Dev Complete (WIP limit - 5) in Android Engineering Team Kanban board Jul 6, 2021
mcarare added a commit to mcarare/fenix that referenced this issue Jul 12, 2021
mcarare added a commit to mcarare/fenix that referenced this issue Jul 12, 2021
@mcarare
Copy link
Contributor

mcarare commented Jul 14, 2021

Closed in #20220.

@mcarare mcarare closed this as completed Jul 14, 2021
Android Engineering Team Kanban board automation moved this from Dev Complete (WIP limit - 5) to Done Jul 14, 2021
czlucius pushed a commit to czlucius/fenix that referenced this issue Aug 20, 2021
czlucius pushed a commit to czlucius/fenix that referenced this issue Aug 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Android:11 Issues specific to Android 11 - API 30 eng:health Improve code health help wanted Help wanted from a contributor. More complex than good first issue.
Projects
No open projects
Development

No branches or pull requests

5 participants