-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Fix systemUiVisibility deprecations in ThemeManager #17808
Comments
Can you please assign me to this issue? |
Sure! |
@Amejia481 It seems some methods are not being overridden because now activities cannot be null as in this link: https://developer.android.com/reference/android/app/Application.ActivityLifecycleCallbacks#onActivityCreated(android.app.Activity,%20android.os.Bundle) |
There is already a PR: #17809 |
@cadeyrn thanks for the info, I will generate the branch from this PR 😃 |
Thank you @cadeyrn and CharlesAdam, we are doing some round of tests to find any possible issue before land it. |
@CharlesAdam are you still working on this? |
@mcarare Yes, I sent a PR back then but it shouldn't be merged before the base branch, I'll update and set it up for the merge |
This is still waiting on a stable version for https://developer.android.com/jetpack/androidx/releases/core 1.5.0 (it has reached the RC stage). |
1.5.0 stable was released May 18 |
@CharlesAdam Do you want to continue working on this? |
Closed in #20220. |
Deprecation docs:
https://developer.android.com/reference/android/view/View#getSystemUiVisibility()
https://developer.android.com/reference/android/view/View#SYSTEM_UI_FLAG_LIGHT_NAVIGATION_BAR
https://developer.android.com/reference/android/view/View#SYSTEM_UI_FLAG_LIGHT_STATUS_BAR
fenix/app/src/main/java/org/mozilla/fenix/theme/ThemeManager.kt
Line 81 in f4a7b4c
fenix/app/src/main/java/org/mozilla/fenix/theme/ThemeManager.kt
Line 88 in f4a7b4c
fenix/app/src/main/java/org/mozilla/fenix/theme/ThemeManager.kt
Line 96 in f4a7b4c
fenix/app/src/main/java/org/mozilla/fenix/theme/ThemeManager.kt
Line 102 in f4a7b4c
Similar mozilla-mobile/android-components#9554
┆Issue is synchronized with this Jira Task
The text was updated successfully, but these errors were encountered: