Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Select credit card] Display a credit card autofill prompt #18287

Closed
gabrielluong opened this issue Mar 2, 2021 · 5 comments · Fixed by #19477
Closed

[Select credit card] Display a credit card autofill prompt #18287

gabrielluong opened this issue Mar 2, 2021 · 5 comments · Fixed by #19477
Assignees
@gabrielluong
Labels
cc-autofill Autofill credit card E3 Estimation Point: average, 2 - 3 days eng:qa:verified QA Verified Feature:Autofill Address and Credit Card autofill
Projects
Autofill Android Engineering Team Kanban board
Milestone
90

Comments

@gabrielluong
Copy link
Member

gabrielluong commented Mar 2, 2021 •
edited by data-sync-user

This issue is to show the "Select credit card" prompt when a credit form is encountered that can be autofilled. This will depend on GV/AC work to wire everything up for this to be displayed. We will not worry about the functionality in the prompt in this issue and it is only focused on wiring things up to display the prompt.

This depends on #18282.

Screen Shot 2021-03-02 at 6 07 24 PM

┆Issue is synchronized with this Jira Task
@gabrielluong gabrielluong added needs:ac Needs Android Component Work E3 Estimation Point: average, 2 - 3 days blocked Feature:Autofill Address and Credit Card autofill cc-autofill Autofill credit card labels Mar 2, 2021
@gabrielluong gabrielluong added this to Waiting on Dependencies in Autofill Mar 2, 2021
@github-actions github-actions bot added the needs:triage Issue needs triage label Mar 2, 2021
@gabrielluong gabrielluong mentioned this issue Mar 2, 2021
Closed
@gabrielluong gabrielluong removed the needs:triage Issue needs triage label Mar 2, 2021
@gabrielluong gabrielluong self-assigned this Apr 22, 2021
@gabrielluong gabrielluong moved this from Waiting on Dependencies to In progress in Autofill Apr 22, 2021
@gabrielluong gabrielluong added this to Ready for Engineering (min-5 ; max-22) in Android Engineering Team Kanban board via automation May 12, 2021
gabrielluong added a commit to gabrielluong/fenix that referenced this issue May 12, 2021
@gabrielluong
For mozilla-mobile#18287 - Display a credit card autofill prompt
8adc69f
@gabrielluong gabrielluong mentioned this issue May 12, 2021
Merged
3 tasks
@gabrielluong gabrielluong moved this from Ready for Engineering (min-5 ; max-22) to Review in progress (WIP limit - 11) in Android Engineering Team Kanban board May 12, 2021
@gabrielluong gabrielluong moved this from In progress to Review in progress in Autofill May 12, 2021
@gabrielluong gabrielluong added this to the 90 milestone May 12, 2021
gabrielluong added a commit to gabrielluong/fenix that referenced this issue May 13, 2021
@gabrielluong
For mozilla-mobile#18287 - Display a credit card autofill prompt
b9e5c6f
@gabrielluong gabrielluong removed the needs:ac Needs Android Component Work label May 13, 2021
gabrielluong added a commit to gabrielluong/fenix that referenced this issue May 13, 2021
@gabrielluong
For mozilla-mobile#18287 - Display a credit card autofill prompt
1d01e6a
gabrielluong added a commit to gabrielluong/fenix that referenced this issue May 13, 2021
@gabrielluong
For mozilla-mobile#18287 - Display a credit card autofill prompt
bfb12f4
Android Engineering Team Kanban board automation moved this from Review in progress (WIP limit - 11) to Done May 14, 2021
Autofill automation moved this from Review in progress to Done May 14, 2021
gabrielluong added a commit that referenced this issue May 14, 2021
@gabrielluong
For #18287 - Display a credit card autofill prompt (#19477)
75fc116
@gabrielluong gabrielluong reopened this May 14, 2021
Android Engineering Team Kanban board automation moved this from Done to In Development (WIP limit - 15) May 14, 2021
Autofill automation moved this from Done to In progress May 14, 2021
@gabrielluong gabrielluong added the eng:qa:needed QA Needed label May 14, 2021
@gabrielluong gabrielluong moved this from In progress to QA in Autofill May 14, 2021
@gabrielluong gabrielluong moved this from In Development (WIP limit - 15) to In Testing/QA in Android Engineering Team Kanban board May 14, 2021
@abodea
Copy link
Member

abodea commented May 18, 2021

@gabrielluong is there any test website for this?

@abodea
Copy link
Member

abodea commented May 19, 2021

Before verifying this, I have a question regarding how it should look, is this the correct one?
Or there should be a prompt like in the picture from the description?
Screenshot_20210519-120930

Also, please note that I added this bug #19559.

@abodea
Copy link
Member

abodea commented May 20, 2021

Removing eng:qa:needed until further notice.

@abodea abodea removed the eng:qa:needed QA Needed label May 20, 2021
@gabrielluong
Copy link
Member Author

It should look like this

Screenshot_20210518-130804_Firefox Nightly

@gabrielluong gabrielluong added the eng:qa:needed QA Needed label May 21, 2021
@abodea
Copy link
Member

abodea commented May 26, 2021

Verified as fixed on the latest Nightly 5/26 with OnePlus Nord (Android 10).
Screenshot_20210526-154433

@abodea abodea closed this as completed May 26, 2021
Android Engineering Team Kanban board automation moved this from In Testing/QA to Done May 26, 2021
Autofill automation moved this from QA to Done May 26, 2021
@abodea abodea added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels May 26, 2021
@gabrielluong gabrielluong mentioned this issue May 28, 2021
Closed
7 tasks
@gabrielluong gabrielluong mentioned this issue Apr 26, 2022
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@gabrielluong gabrielluong

Labels
cc-autofill Autofill credit card E3 Estimation Point: average, 2 - 3 days eng:qa:verified QA Verified Feature:Autofill Address and Credit Card autofill
Projects
No open projects
Android Engineering Team Kanban board
Done
Autofill
Done
Milestone
90
Development

Successfully merging a pull request may close this issue.

For #18287 - Display a credit card autofill prompt gabrielluong/fenix
2 participants
@gabrielluong @abodea