Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

For #18287 - Display a credit card autofill prompt #19477

Merged
merged 1 commit into from
May 14, 2021

Conversation

gabrielluong
Copy link
Member

Fixes #18287

Pull Request checklist

  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

@gabrielluong gabrielluong added the pr:needs-ac-bump PR that needs a AC bump label May 12, 2021
@gabrielluong gabrielluong requested review from a team as code owners May 12, 2021 03:59
@@ -120,6 +120,7 @@ class Core(
defaultSettings,
GeckoProvider.getOrCreateRuntime(
context,
lazyAutofillStorage,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not the right way to adding a storage delegate. Unfortunately, we have logins that started doing this with the pattern following.

Maybe we need to file an issue to fix this up to change these APIs before it happens the third or fourth time.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't adding the storage delegate. We're adding the storage delegate here

geckoRuntime.autocompleteStorageDelegate = GeckoAutocompleteStorageDelegate(
. This is simply about passing the underlying storage so that it can be passed to their respective storage delegate when the GeckoRuntime is created and can be set via autocompleteStorageDelegate, which is its proper GV API.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're talking about the same thing at a different abstraction level. See the Engine.kt API which is how we should be adding these storage delegates.

I think it's a bit too late in this particular process to clean this up, so let's do it in a follow up.

@mergify
Copy link
Contributor

mergify bot commented May 13, 2021

This pull request has conflicts when rebasing. Could you fix it @gabrielluong? 🙏

@gabrielluong gabrielluong merged commit 75fc116 into mozilla-mobile:master May 14, 2021
@gabrielluong gabrielluong deleted the 18287 branch May 18, 2021 18:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr:needs-ac-bump PR that needs a AC bump
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Select credit card] Display a credit card autofill prompt
3 participants