Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Bug] make_default_browser deeplink doesn't work on Android 6 & 5 devices #18453

Closed
AndiAJ opened this issue Mar 12, 2021 · 4 comments
Closed

[Bug] make_default_browser deeplink doesn't work on Android 6 & 5 devices #18453

AndiAJ opened this issue Mar 12, 2021 · 4 comments
Assignees
@kershan
Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified good first issue Good for newcomers S2 Major Functionality/product severely impaired and a satisfactory workaround doesn't exist
Milestone
89

Comments

@AndiAJ
Copy link
Collaborator

AndiAJ commented Mar 12, 2021 •
edited by data-sync-user

Prerequisites

Identify your User ID

Steps to reproduce

  1. Run adb shell am start -a android.intent.action.VIEW -d fenix-nightly://make_default_browser\?uid=Your User ID on a Nightly Build.

Expected behavior

Open "Make Firefox the default browser on Android" Sumo page ❓ as implemeted in #5898

Actual behavior

Besides launching Fenix nothing else happens

Device information

  • Device vendor / model and Android version:
    • OnePlus A3 (Android 6.0.1)
    • Samsung Galaxy Tab A6 (Android 5.1.1)

  • Firefox for Android version:

  • • Nightly 210312
    • Beta 87.0.0-beta.5
    • RC 86.1.1

┆Issue is synchronized with this Jira Task
@AndiAJ AndiAJ added 🐞 bug Crashes, Something isn't working, .. S2 Major Functionality/product severely impaired and a satisfactory workaround doesn't exist labels Mar 12, 2021
@github-actions github-actions bot added the needs:triage Issue needs triage label Mar 12, 2021
@AndiAJ AndiAJ removed the needs:triage Issue needs triage label Mar 12, 2021
@Mugurell
Copy link
Contributor

Mugurell commented Mar 12, 2021 •
edited

Because the functionality of sending users to system settings from where the default app can be set is only available on later APIs, to ensure consistency with what already happens when users press the "Set as default browser" option in app settings we should add an else clause here
to open the app with this link

@Mugurell Mugurell added the good first issue Good for newcomers label Mar 12, 2021
@kershan
Copy link
Contributor

kershan commented Mar 21, 2021 •
edited

Hey, I would like to pick this issue up to work on if it is still available and needed.

@Mugurell
Copy link
Contributor

Hey, I would like to pick this issue up to work on if it is still available and needed.

That would be awesome! Thank you!

kershan added a commit to kershan/fenix that referenced this issue Mar 22, 2021
@kershan
For mozilla-mobile#18453 Add deep link navigation to support page for…
f6564f0 
… setting as default browser action when Android SDK below API 24.
kershan added a commit to kershan/fenix that referenced this issue Mar 22, 2021
@kershan
For mozilla-mobile#18453 Updates deep linking documentation for setti…
ccba87b 
…ng as default browser action when Android SDK below API 24.
kershan added a commit to kershan/fenix that referenced this issue Mar 23, 2021
@kershan
For mozilla-mobile#18453 Adds tests for setting as default browser ac…
44f43d3 
…tion when Android SDK is below and when above API 24.
kershan added a commit to kershan/fenix that referenced this issue Mar 25, 2021
@kershan
For mozilla-mobile#18453 Removes maxSdk = P for mark_default_browser …
bce4ad2 
…test.
kershan added a commit to kershan/fenix that referenced this issue Mar 25, 2021
@kershan
For mozilla-mobile#18453 Revert unneeded code reformat.
2a21a4d
kershan added a commit to kershan/fenix that referenced this issue Mar 25, 2021
@kershan
For mozilla-mobile#18453 Removes unused import.
892e2d7
kershan added a commit to kershan/fenix that referenced this issue Mar 25, 2021
@kershan
Revert "For mozilla-mobile#18453 Removes maxSdk = P for mark_default_…
6ea3b66 
…browser test."

This reverts commit bce4ad2
kershan added a commit to kershan/fenix that referenced this issue Mar 25, 2021
@kershan
Revert "For mozilla-mobile#18453 Removes unused import."
9432f81 
This reverts commit 892e2d7
kershan added a commit to kershan/fenix that referenced this issue Mar 25, 2021
@kershan
For mozilla-mobile#18453 Add navigation to support when Android SDK b…
1bd3859 
…elow API 24.

Add deep link navigation to support page for setting as default browser action when Android SDK below API 24.
kershan added a commit to kershan/fenix that referenced this issue Mar 25, 2021
@kershan
For mozilla-mobile#18453 Updates deep linking documentation for setti…
cc281e0 
…ng as default browser action when Android SDK below API 24.
kershan added a commit to kershan/fenix that referenced this issue Mar 25, 2021
@kershan
For mozilla-mobile#18453 Adds tests for setting as default browser ac…
522e74e 
…tion when Android SDK is below and when above API 24.
kershan added a commit to kershan/fenix that referenced this issue Mar 25, 2021
@kershan
For mozilla-mobile#18453 Removes maxSdk = P for mark_default_browser …
edc2e26 
…test.
kershan added a commit to kershan/fenix that referenced this issue Mar 25, 2021
@kershan
For mozilla-mobile#18453 Revert unneeded code reformat.
dc14d3f
kershan added a commit to kershan/fenix that referenced this issue Mar 25, 2021
@kershan
For mozilla-mobile#18453 Removes unused import.
0fd9de1
kershan added a commit to kershan/fenix that referenced this issue Mar 25, 2021
@kershan
Revert "For mozilla-mobile#18453 Removes maxSdk = P for mark_default_…
7b74159 
…browser test."

This reverts commit bce4ad2
kershan added a commit to kershan/fenix that referenced this issue Mar 25, 2021
@kershan
Revert "For mozilla-mobile#18453 Removes unused import."
f382d71 
This reverts commit 892e2d7
kershan added a commit to kershan/fenix that referenced this issue Mar 25, 2021
@kershan
For mozilla-mobile#18453 Updates deep linking documentation.
6c84be2 
Updates deep linking documentation for setting as default browser action when Android SDK below API 24.
kershan added a commit to kershan/fenix that referenced this issue Mar 25, 2021
@kershan
For mozilla-mobile#18453 Adds tests for setting as default browser ac…
2b4b563 
…tion.

Adds tests for setting as default browser action when Android SDK is below and when above API 24.
kershan added a commit to kershan/fenix that referenced this issue Mar 25, 2021
@kershan
For mozilla-mobile#18453 Removes maxSdk = P for mark_default_browser …
aa0add3 
…test.
kershan added a commit to kershan/fenix that referenced this issue Mar 25, 2021
@kershan
For mozilla-mobile#18453 Revert unneeded code reformat.
e794e79
kershan added a commit to kershan/fenix that referenced this issue Mar 25, 2021
@kershan
For mozilla-mobile#18453 Removes unused import.
39f5f3a
kershan added a commit to kershan/fenix that referenced this issue Mar 25, 2021
@kershan
Revert "For mozilla-mobile#18453 Removes maxSdk = P for mark_default_…
74d44bc 
…browser test."

This reverts commit bce4ad2
kershan added a commit to kershan/fenix that referenced this issue Mar 25, 2021
@kershan
Revert "For mozilla-mobile#18453 Removes unused import."
9b9bcf8 
This reverts commit 892e2d7
kershan added a commit to kershan/fenix that referenced this issue Mar 29, 2021
@kershan
For mozilla-mobile#18453 Add navigation to support when Android SDK b…
b89c79d 
…elow API 24.

Add deep link navigation to support page for setting as default browser action when Android SDK below API 24.
kershan added a commit to kershan/fenix that referenced this issue Mar 29, 2021
@kershan
For mozilla-mobile#18453 Updates deep linking documentation.
9354834 
Updates deep linking documentation for setting as default browser action when Android SDK below API 24.
kershan added a commit to kershan/fenix that referenced this issue Mar 29, 2021
@kershan
For mozilla-mobile#18453 Adds tests for setting as default browser ac…
7459d55 
…tion.

Adds tests for setting as default browser action when Android SDK is below and when above API 24.
kershan added a commit to kershan/fenix that referenced this issue Mar 29, 2021
@kershan
For mozilla-mobile#18453 Removes maxSdk = P for mark_default_browser …
68edbe8 
…test.
kershan added a commit to kershan/fenix that referenced this issue Mar 29, 2021
@kershan
For mozilla-mobile#18453 Revert unneeded code reformat.
fad8bb0
kershan added a commit to kershan/fenix that referenced this issue Mar 29, 2021
@kershan
For mozilla-mobile#18453 Removes unused import.
40e7831
kershan added a commit to kershan/fenix that referenced this issue Mar 29, 2021
@kershan
Revert "For mozilla-mobile#18453 Removes maxSdk = P for mark_default_…
f1b32b2 
…browser test."

This reverts commit bce4ad2
kershan added a commit to kershan/fenix that referenced this issue Mar 29, 2021
@kershan
Revert "For mozilla-mobile#18453 Removes unused import."
f775e73 
This reverts commit 892e2d7
Mugurell pushed a commit that referenced this issue Mar 29, 2021
@kershan
For #18453 - Show SUMO for default browser deeplink on Android <N
02d70d3 
Lower Android versions don't offer the possibility of opening system settings
at a specific preference. In this cases we already shown a sumo article
detailing the manual steps each user is expected to perform to change the
system set default browser.
@Mugurell Mugurell added the eng:qa:needed QA Needed label Mar 29, 2021
@lobontiumira
Copy link

Verified as fixed on the 3/30 Nightly build with Samsung Galaxy Tab A6 (Android 5.1.1).
Running adb shell am start -a android.intent.action.VIEW -d fenix-nightly://make_default_browser?uid= opens the "Make Firefox the default browser on Android" SUMO page.

@lobontiumira lobontiumira added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Mar 30, 2021
@Mugurell Mugurell added this to the 89 milestone Mar 30, 2021
pkirakosyan pushed a commit to gexsi/user-agent-android that referenced this issue Aug 5, 2021
@kershan @pkirakosyan
For mozilla-mobile#18453 - Show SUMO for default browser deeplink on …
e2eccc5 
…Android <N

Lower Android versions don't offer the possibility of opening system settings
at a specific preference. In this cases we already shown a sumo article
detailing the manual steps each user is expected to perform to change the
system set default browser.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@kershan kershan

Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified good first issue Good for newcomers S2 Major Functionality/product severely impaired and a satisfactory workaround doesn't exist
Projects
None yet
Milestone
89
Development

No branches or pull requests
4 participants
@kershan @Mugurell @lobontiumira @AndiAJ