Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Don't hide "set as default browser" on Android 5 & 6 #5898

Closed
sblatz opened this issue Oct 9, 2019 · 3 comments
Closed

Don't hide "set as default browser" on Android 5 & 6 #5898

sblatz opened this issue Oct 9, 2019 · 3 comments
Assignees
Labels
🐞 bug Crashes, Something isn't working, .. E2 Estimation Point: easy, half a day to 2 days eng:qa:verified QA Verified Feature:FennecTransition

Comments

@sblatz
Copy link
Contributor

sblatz commented Oct 9, 2019

In #382 we hid the default browser toggle on these lower versions for MVP.

As suggested by Vesta, we should unhide this toggle and use it to link to the sumo article (which is what we did in Focus): https://support.mozilla.org/en-US/kb/how-set-firefox-preview-your-default-browser-android

This would also deal with #5870 as users could access that toggle.

┆Issue is synchronized with this Jira Task

@sblatz sblatz self-assigned this Oct 10, 2019
@sblatz sblatz added the E2 Estimation Point: easy, half a day to 2 days label Oct 10, 2019
@sblatz sblatz assigned sblatz and unassigned sblatz Oct 10, 2019
@project-bot project-bot bot added this to In Progress in Fenix Sprint Kanban Oct 10, 2019
sblatz added a commit to sblatz/fenix that referenced this issue Oct 10, 2019
sblatz added a commit to sblatz/fenix that referenced this issue Oct 10, 2019
sblatz added a commit to sblatz/fenix that referenced this issue Oct 10, 2019
sblatz added a commit to sblatz/fenix that referenced this issue Oct 10, 2019
@sblatz
Copy link
Contributor Author

sblatz commented Oct 10, 2019

Updated behavior:

new behavior on lower api

@sblatz sblatz added the eng:qa:needed QA Needed label Oct 10, 2019
@project-bot project-bot bot moved this from In Progress to Ready for QA in Fenix Sprint Kanban Oct 10, 2019
@AndiAJ AndiAJ removed the eng:qa:needed QA Needed label Oct 11, 2019
@project-bot project-bot bot moved this from Ready for QA to Sprint Backlog in Fenix Sprint Kanban Oct 11, 2019
@AndiAJ
Copy link
Collaborator

AndiAJ commented Oct 11, 2019

Hi, I've check on the latest debug build from Master 1.0.1941 11/10 using the following devices:
• Samsung Galaxy S6 (Android 6.0.1)
• OnePlus A3 (Android 6.0.1)
• LG Nexus 4 (Android 5.1.1)
• Samsung Galaxy Tab Active (Android 5.1.1)

The "Set as default browser" section is indeed displayed on the other hand there is no redirecting made to the newly opened page (sumo article).
You need to check and navigate t it from the Open tabs section.

Similar behavior trying to "disable" the toggle.

► Enable
20191011_120733

► Disable
20191011_122306

@sblatz Please review and let us know if the user should automatically redirected to the sumo article.
Until then I'll remove the QA needed label.

@sblatz sblatz moved this from Sprint Backlog to In Progress in Fenix Sprint Kanban Oct 11, 2019
sblatz added a commit to sblatz/fenix that referenced this issue Oct 11, 2019
@sblatz sblatz moved this from In Progress to In Dev Review in Fenix Sprint Kanban Oct 11, 2019
bors bot pushed a commit that referenced this issue Oct 14, 2019
5973: For #5898: Launch SUMO article properly for default browser r=colintheshots a=sblatz



Co-authored-by: Sawyer Blatz <sdblatz@gmail.com>
bors bot pushed a commit that referenced this issue Oct 14, 2019
5973: For #5898: Launch SUMO article properly for default browser r=colintheshots a=sblatz



Co-authored-by: Sawyer Blatz <sdblatz@gmail.com>
@sblatz sblatz added the eng:qa:needed QA Needed label Oct 14, 2019
@project-bot project-bot bot moved this from In Dev Review to Ready for QA in Fenix Sprint Kanban Oct 14, 2019
@AndiAJ AndiAJ added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Oct 15, 2019
@AndiAJ
Copy link
Collaborator

AndiAJ commented Oct 15, 2019

Hi, verified as fixed on the latest Nightly build #12880607 from 15/10 using the following devices:

• Samsung Galaxy S6 (Android 6.0.1)
• OnePlus A3 (Android 6.0.1)
• LG Nexus 4 (Android 5.1.1)
• Samsung Galaxy Tab Active (Android 5.1.1)

► Enable
20191015_104041

► Disable
20191015_104234

@AndiAJ AndiAJ closed this as completed Oct 15, 2019
Fenix Sprint Kanban automation moved this from Ready for QA to Sprint 10.2 Done Oct 15, 2019
boek pushed a commit to boek/fenix that referenced this issue Oct 16, 2019
5973: For mozilla-mobile#5898: Launch SUMO article properly for default browser r=colintheshots a=sblatz



Co-authored-by: Sawyer Blatz <sdblatz@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🐞 bug Crashes, Something isn't working, .. E2 Estimation Point: easy, half a day to 2 days eng:qa:verified QA Verified Feature:FennecTransition
Projects
None yet
Development

No branches or pull requests

2 participants