Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Ensure the Credit card screens cannot be screenshot #18507

Closed
gabrielluong opened this issue Mar 16, 2021 · 7 comments · Fixed by #19560
Closed

Ensure the Credit card screens cannot be screenshot #18507

gabrielluong opened this issue Mar 16, 2021 · 7 comments · Fixed by #19560
Assignees
@mcarare
Labels
cc-autofill Autofill credit card E1 Estimation Point: trivial, less than half day eng:qa:verified QA Verified Feature:Autofill Address and Credit Card autofill
Projects
Autofill Android Engineering Team Kanban board
Milestone
90

Comments

@gabrielluong
Copy link
Member

gabrielluong commented Mar 16, 2021 •
edited by data-sync-user

Note that there is an existing PR with feedback and take aways #18890. Please consider using it.

Secure secure flags so that the windows of the Credit cards screen cannot be screenshotted.

┆Issue is synchronized with this Jira Task
@gabrielluong gabrielluong added E2 Estimation Point: easy, half a day to 2 days Feature:Autofill Address and Credit Card autofill cc-autofill Autofill credit card labels Mar 16, 2021
@gabrielluong gabrielluong added this to Waiting on Dependencies in Autofill Mar 16, 2021
@github-actions github-actions bot added the needs:triage Issue needs triage label Mar 16, 2021
@clientenq
Copy link

Can you explain how you expect this suggestion to solve your issue? Credit card screens or forms are not standardised and are different per merchant.

@gabrielluong
Copy link
Member Author

Can you explain how you expect this suggestion to solve your issue? Credit card screens or forms are not standardised and are different per merchant.

This wouldn't be related to the 'webview'. This would be about securing the preference screens where we plan to provide autofill and management of stored credit card information.

@gabrielluong gabrielluong removed the needs:triage Issue needs triage label Mar 17, 2021
@gabrielluong gabrielluong moved this from Waiting on Dependencies to Backlog in Autofill Apr 6, 2021
@gabrielluong gabrielluong added E1 Estimation Point: trivial, less than half day and removed E2 Estimation Point: easy, half a day to 2 days labels Apr 7, 2021
@chrishernan
Copy link
Contributor

Hello. Could I work on this issue if possible?

@gabrielluong
Copy link
Member Author

Hello. Could I work on this issue if possible?

Sure, I would suggest pulling in #18808 in order to be fully complete. You need to enable the "Credit Card" feature by going into "About Firefox" in the Settings and tapping the logo 3 times to see the Secret Settings where we add toggles for our feature flags.

@chrishernan
Copy link
Contributor

chrishernan commented Apr 8, 2021 •
edited

Will do. Thanks for the tip. I just spent an hour trying to figure out where the credit card section was haha. I should've looked at this comment earlier.

chrishernan added a commit to chrishernan/fenix that referenced this issue Apr 9, 2021
@chrishernan
mozilla-mobile#18507 - Secured CreditCardsSettingFragment.kt from scr…
e800924 
…eenshots and video capture. I added a variable/flag to keep track of when we will navigate to CreditCardEditorFragment.kt. This maintains the ability to screenshot the "Turn on Sync" page, while keeping the Credit Card editor secure. The function removeFlagSecure takes care of this.
chrishernan added a commit to chrishernan/fenix that referenced this issue Apr 9, 2021
@chrishernan
mozilla-mobile#18507 - Added FLAG_SECURE to onResume of CreditCardEdi…
cb92406 
…torFragment.kt in case user travels to another app and comes back to the credit card editor. This will keep CreditCardEditorFragment.kt secure from screenshots.
chrishernan added a commit to chrishernan/fenix that referenced this issue Apr 9, 2021
@chrishernan
mozilla-mobile#18507 - Fixed some Detekt and klint formatting issues.
b9edffe
chrishernan added a commit to chrishernan/fenix that referenced this issue Apr 9, 2021
@chrishernan
mozilla-mobile#18507 - Followed same pattern to set flags as other pa…
a233d1f 
…rts of the project.
@gabrielluong gabrielluong moved this from Backlog to Review in progress in Autofill Apr 11, 2021
@gabrielluong gabrielluong linked a pull request Apr 11, 2021 that will close this issue
For #18507 - Ensure credit card screens cannot be screenshot #18890
Closed
3 tasks
@gabrielluong gabrielluong added this to the 89 milestone Apr 11, 2021
@gabrielluong gabrielluong modified the milestones: 89, 90 Apr 26, 2021
@gabrielluong gabrielluong moved this from Review in progress to Backlog in Autofill May 18, 2021
@gabrielluong gabrielluong added this to Ready for Engineering (min-5 ; max-22) in Android Engineering Team Kanban board via automation May 18, 2021
@mcarare mcarare self-assigned this May 19, 2021
@mcarare mcarare moved this from Ready for Engineering (min-5 ; max-22) to In Development (WIP limit - 15) in Android Engineering Team Kanban board May 19, 2021
@mcarare mcarare moved this from Backlog to In progress in Autofill May 19, 2021
mcarare added a commit to mcarare/fenix that referenced this issue May 19, 2021
@mcarare
For mozilla-mobile#18507: Prevent screenshots on credit card screens.
e02f476
mcarare added a commit to mcarare/fenix that referenced this issue May 19, 2021
@mcarare
For mozilla-mobile#18507: Prevent screenshots on credit card screens.
d9e48fa
@mcarare mcarare moved this from In Development (WIP limit - 15) to Dev Complete (WIP limit - 5) in Android Engineering Team Kanban board May 19, 2021
mcarare added a commit to mcarare/fenix that referenced this issue May 19, 2021
@mcarare
For mozilla-mobile#18507: Prevent screenshots on credit card screens.
19c5933
mcarare added a commit to mcarare/fenix that referenced this issue May 19, 2021
@mcarare
For mozilla-mobile#18507: Prevent screenshots on credit card screens.
5f81752
mcarare added a commit to mcarare/fenix that referenced this issue May 19, 2021
@mcarare
For mozilla-mobile#18507: Prevent screenshots on credit card screens.
425db04
@codrut-topliceanu codrut-topliceanu moved this from Dev Complete (WIP limit - 5) to Reviewer approved, ready for test (WIP limit - ?) in Android Engineering Team Kanban board May 19, 2021
@codrut-topliceanu codrut-topliceanu moved this from In progress to Reviewer approved in Autofill May 19, 2021
mcarare added a commit to mcarare/fenix that referenced this issue May 19, 2021
@mcarare
For mozilla-mobile#18507: Prevent screenshots on credit card screens.
fd4fb65
@gabrielluong gabrielluong removed a link to a pull request May 19, 2021
For #18507 - Ensure credit card screens cannot be screenshot #18890
Closed
3 tasks
@gabrielluong gabrielluong mentioned this issue May 19, 2021
Merged
3 tasks
Android Engineering Team Kanban board automation moved this from Reviewer approved, ready for test (WIP limit - ?) to Done May 19, 2021
Autofill automation moved this from Reviewer approved to Done May 19, 2021
gabrielluong pushed a commit that referenced this issue May 19, 2021
@mcarare
For #18507 - Prevent screenshots on credit card screens. (#19560)
11efbaa
@mcarare mcarare moved this from Done to Reviewer approved, ready for test (WIP limit - ?) in Android Engineering Team Kanban board May 20, 2021
@mcarare
Copy link
Contributor

mcarare commented May 20, 2021

Reopened for QA.

@mcarare mcarare reopened this May 20, 2021
Android Engineering Team Kanban board automation moved this from Reviewer approved, ready for test (WIP limit - ?) to In Development (WIP limit - 15) May 20, 2021
Autofill automation moved this from Done to In progress May 20, 2021
@mcarare mcarare added the eng:qa:needed QA Needed label May 20, 2021
@mcarare mcarare moved this from In Development (WIP limit - 15) to Reviewer approved, ready for test (WIP limit - ?) in Android Engineering Team Kanban board May 20, 2021
@gabrielluong gabrielluong moved this from In progress to QA in Autofill May 20, 2021
@gabrielluong gabrielluong moved this from Reviewer approved, ready for test (WIP limit - ?) to In Testing/QA in Android Engineering Team Kanban board May 24, 2021
@LaurentiuApahideanSV
Copy link

Verified as fixed on Firefox Preview Nightly 5/25.

Devices used:

  • OnePlus 6T (Android 9)
  • Pixel 3 XL (Android 9)

Android Engineering Team Kanban board automation moved this from In Testing/QA to Done May 25, 2021
Autofill automation moved this from QA to Done May 25, 2021
@LaurentiuApahideanSV LaurentiuApahideanSV added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels May 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mcarare mcarare

Labels
cc-autofill Autofill credit card E1 Estimation Point: trivial, less than half day eng:qa:verified QA Verified Feature:Autofill Address and Credit Card autofill
Projects
No open projects
Android Engineering Team Kanban board
Done
Autofill
Done
Milestone
90
Development

Successfully merging a pull request may close this issue.

For #18507: Prevent screenshots on credit card screens. mcarare/fenix
6 participants
@gabrielluong @chrishernan @mcarare @LaurentiuApahideanSV @clientenq and others