Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

For #18507: Prevent screenshots on credit card screens. #19560

Merged
merged 1 commit into from May 19, 2021

Conversation

mcarare
Copy link
Contributor

@mcarare mcarare commented May 19, 2021

Fixes #18507

Pull Request checklist

  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

Copy link
Contributor

@codrut-topliceanu codrut-topliceanu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Works + Looks good to me.

@gabrielluong
Copy link
Member

Can we file an issue about using the new SecureFragment in the logins? Thanks!

Comment on lines 95 to 111
fun Fragment.secure() {
this.activity?.window?.addFlags(
WindowManager.LayoutParams.FLAG_SECURE
)
}

fun Fragment.removeSecure() {
this.activity?.window?.clearFlags(
WindowManager.LayoutParams.FLAG_SECURE
)
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add kDocs for these 2 methods?

@mcarare
Copy link
Contributor Author

mcarare commented May 19, 2021

Can we file an issue about using the new SecureFragment in the logins? Thanks!

Filed #19567.

@gabrielluong gabrielluong merged commit 11efbaa into mozilla-mobile:master May 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ensure the Credit card screens cannot be screenshot
3 participants