Implement start up type telemetry #18836

mcomella · 2021-04-07T00:50:14Z

To choose the area of start up perf to focus on, we need to leverage frequency vs. impact, i.e. these variables:

(frequency) What are the most common types of start up?
Does this change for the users with the slowest start ups? (as we assume they are the most likely to change stop using FF)
(impact) Which types of start up are the least performant and by how much? (e.g. if it's real bad, it might outweigh frequency)
Does it change for users with slowest start ups?

To answer 1), we can implement telemetry to count the number of each type of start up. We have existing telemetry that answers this but we've discovered a flaw in its methodology (it doesn't take into account the process starting for Services in COLD start) and it's not easy to analyze (an event with extras doesn't work in GLAM). We can use labeled_counter to implement something we can read in GLAM.

Answering 2) is harder as we need to combine start up type and timing measurements. Let's save that for later.

┆Issue is synchronized with this Jira Task

The text was updated successfully, but these errors were encountered:

…initely. We do this is as a separate commit over the original implementation because it's simpler to implement the class without this optimization.

…tartupStateProvider. The StartupActivityStateProvider uses an imperative implementation, driven by callbacks, to set the state of the application. This is hard to follow as you need to understand which callbacks will be called in which order. For example, to make sense of an implementation like this, COLD, WARM, AND HOT would likely need to be implemented in separate ActivityLifecycleCallbacks. I feel the StartupStateProvider is an improvement because it leverages the StartupActivityLog to query a linear state for a more understandable implementation. Furthermore, it seems accessible to write COLD, WARM, and HOT in the same class because they can all be approached the same way.

…ActivityCreated and similar. It's too much work to squash "correctly".

We do this is as a separate commit over the original implementation because it's simpler to implement the class without this optimization.

…vider. The StartupActivityStateProvider uses an imperative implementation, driven by callbacks, to set the state of the application. This is hard to follow as you need to understand which callbacks will be called in which order. For example, to make sense of an implementation like this, COLD, WARM, AND HOT would likely need to be implemented in separate ActivityLifecycleCallbacks. I feel the StartupStateProvider is an improvement because it leverages the StartupActivityLog to query a linear state for a more understandable implementation. Furthermore, it seems accessible to write COLD, WARM, and HOT in the same class because they can all be approached the same way.

…d and similar. It's too much work to squash "correctly".

…test. The test failed with the rewrite of the code because it violates one of our assumptions that only one Activity will be started. However, since it doesn't rely on observed behavior and we made up the events, it's value is questionable so it seems okay to remove, especially for the gain of conciseness in the code.

The test failed with the rewrite of the code because it violates one of our assumptions that only one Activity will be started. However, since it doesn't rely on observed behavior and we made up the events, it's value is questionable so it seems okay to remove, especially for the gain of conciseness in the code.

mcomella · 2021-04-16T22:32:37Z

This could conceivably be QA'd but it'd be difficult to convey the nuances so I'm concerned it'd mean diminishing returns so I won't flag for it.

mcomella added the performance Possible performance wins label Apr 7, 2021

mcomella added this to Needs prioritization in Performance, front-end roadmap via automation Apr 7, 2021

mcomella moved this from Needs prioritization to In progress in Performance, front-end roadmap Apr 7, 2021

mcomella self-assigned this Apr 7, 2021

github-actions bot added the needs:triage Issue needs triage label Apr 7, 2021

mcomella added a commit to mcomella/fenix that referenced this issue Apr 8, 2021

For mozilla-mobile#18836: add StartupActivityLog, tests.

7ed32dc

mcomella added a commit to mcomella/fenix that referenced this issue Apr 8, 2021

For mozilla-mobile#18836: add StartupStateProvider.

a8b1906

mcomella added a commit to mcomella/fenix that referenced this issue Apr 8, 2021

For mozilla-mobile#18836: note refactor in metrics docs.

593fda2

mcomella added a commit to mcomella/fenix that referenced this issue Apr 8, 2021

For mozilla-mobile#18836: rename CreatedActivityLogEntry -> LogEntry.…

93ea136

…ActivityCreated and similar. It's too much work to squash "correctly".

mcomella added a commit that referenced this issue Apr 13, 2021

For #18836: add StartupActivityLog, tests.

cde954f

mcomella added a commit that referenced this issue Apr 13, 2021

For #18836: prevent StartupActivityLog from growing infinitely.

e864e74

We do this is as a separate commit over the original implementation because it's simpler to implement the class without this optimization.

mcomella added a commit that referenced this issue Apr 13, 2021

For #18836: add StartupStateProvider.

0cbedaa

mcomella added a commit that referenced this issue Apr 13, 2021

For #18836: note refactor in metrics docs.

3ae80cd

mcomella added a commit that referenced this issue Apr 13, 2021

For #18836: rename CreatedActivityLogEntry -> LogEntry.ActivityCreate…

5560d7d

…d and similar. It's too much work to squash "correctly".

mcomella added a commit to mcomella/fenix that referenced this issue Apr 14, 2021

For mozilla-mobile#18836: refactor tests into forEachColdStartEntries.

468be4e

mcomella added a commit to mcomella/fenix that referenced this issue Apr 14, 2021

For mozilla-mobile#18836: refactor test into forEachWarmStartEntries.

a8677c4

mcomella added a commit to mcomella/fenix that referenced this issue Apr 14, 2021

For mozilla-mobile#18836: refactor tests to forEachHotStartEntries.

0827d1c

mcomella added a commit to mcomella/fenix that referenced this issue Apr 14, 2021

For mozilla-mobile#18836: add VIEW to warm and hot entries.

a6a93c9

mcomella added a commit to mcomella/fenix that referenced this issue Apr 14, 2021

For mozilla-mobile#18836: add isWarmStartForStartedActivity, tests.

b098663

mcomella added a commit to mcomella/fenix that referenced this issue Apr 14, 2021

For mozilla-mobile#18836: add isHotStartForStartedActivity and tests.

0c271d3

mcomella added a commit to mcomella/fenix that referenced this issue Apr 14, 2021

For mozilla-mobile#18836: add getStartupStateForStartedActivity method.

9574d01

mcomella added a commit to mcomella/fenix that referenced this issue Apr 14, 2021

For mozilla-mobile#18836: address lint errors for StartupStateProvider*.

69bacd6

mcomella added a commit to mcomella/fenix that referenced this issue Apr 14, 2021

For mozilla-mobile#18836: add StartupPathProvider + tests.

6414187

mcomella added a commit to mcomella/fenix that referenced this issue Apr 14, 2021

For mozilla-mobile#18836: add metric perf.startup.startup_type.

0fa8343

mcomella added a commit to mcomella/fenix that referenced this issue Apr 14, 2021

For mozilla-mobile#18836: add & integrate StartupTypeTelemetry.

c2005f9

mcomella mentioned this issue Apr 14, 2021

For #18836: add telemetry for start up type #19028

Merged

3 tasks

mcomella added a commit to mcomella/fenix that referenced this issue Apr 14, 2021

For mozilla-mobile#18836: refactor tests to forEachHotStartEntries.

d816c48

mcomella added a commit to mcomella/fenix that referenced this issue Apr 14, 2021

For mozilla-mobile#18836: add VIEW to warm and hot entries.

d2fdca1

mcomella added a commit to mcomella/fenix that referenced this issue Apr 14, 2021

For mozilla-mobile#18836: add isWarmStartForStartedActivity, tests.

b92dfbe

mcomella added a commit to mcomella/fenix that referenced this issue Apr 14, 2021

For mozilla-mobile#18836: add isHotStartForStartedActivity and tests.

f39b2a9

mcomella added a commit to mcomella/fenix that referenced this issue Apr 14, 2021

For mozilla-mobile#18836: add getStartupStateForStartedActivity method.

57c3e07

mcomella added a commit to mcomella/fenix that referenced this issue Apr 14, 2021

For mozilla-mobile#18836: address lint errors for StartupStateProvider*.

8410932

mcomella added a commit to mcomella/fenix that referenced this issue Apr 14, 2021

For mozilla-mobile#18836: add StartupPathProvider + tests.

c99dc45

mcomella added a commit to mcomella/fenix that referenced this issue Apr 14, 2021

For mozilla-mobile#18836: add metric perf.startup.startup_type.

7e774b7

mcomella added a commit to mcomella/fenix that referenced this issue Apr 14, 2021

For mozilla-mobile#18836: add & integrate StartupTypeTelemetry.

f421600

mcomella added a commit to mcomella/fenix that referenced this issue Apr 14, 2021

For mozilla-mobile#18836: address onCreate method length detekt issue.

cb76841

mcomella added a commit that referenced this issue Apr 16, 2021

For #18836: refactor tests into forEachColdStartEntries.

a00fbbb

mcomella added a commit that referenced this issue Apr 16, 2021

For #18836: refactor test into forEachWarmStartEntries.

a7f4aac

mcomella added a commit that referenced this issue Apr 16, 2021

For #18836: refactor tests to forEachHotStartEntries.

fd11cc1

mcomella added a commit that referenced this issue Apr 16, 2021

For #18836: add VIEW to warm and hot entries.

4f26aae

mcomella added a commit that referenced this issue Apr 16, 2021

For #18836: add isWarmStartForStartedActivity, tests.

e803cc6

mcomella added a commit that referenced this issue Apr 16, 2021

For #18836: add isHotStartForStartedActivity and tests.

18507ec

mcomella added a commit that referenced this issue Apr 16, 2021

For #18836: add getStartupStateForStartedActivity method.

ea1d569

mcomella added a commit that referenced this issue Apr 16, 2021

For #18836: address lint errors for StartupStateProvider*.

ec65737

mcomella added a commit that referenced this issue Apr 16, 2021

For #18836: add StartupPathProvider + tests.

a64540b

mcomella added a commit that referenced this issue Apr 16, 2021

For #18836: add metric perf.startup.startup_type.

aa38462

mcomella added a commit that referenced this issue Apr 16, 2021

For #18836: add & integrate StartupTypeTelemetry.

d699923

mcomella added a commit that referenced this issue Apr 16, 2021

For #18836: address onCreate method length detekt issue.

cbc5df3

mcomella added the eng:qa:not-needed Added by QA to issues that cannot be tested label Apr 16, 2021

mcomella closed this as completed Apr 16, 2021

Performance, front-end roadmap automation moved this from In progress to Done Apr 16, 2021

mcomella mentioned this issue Apr 16, 2021

Analyze start up type telemetry #19085

Closed

pkirakosyan pushed a commit to gexsi/user-agent-android that referenced this issue Aug 9, 2021

For mozilla-mobile#18836: address onCreate method length detekt issue.

8b1155f

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement start up type telemetry #18836

Implement start up type telemetry #18836

mcomella commented Apr 7, 2021 •

edited by data-sync-user

mcomella commented Apr 16, 2021

Implement start up type telemetry #18836

Implement start up type telemetry #18836

Comments

mcomella commented Apr 7, 2021 • edited by data-sync-user

mcomella commented Apr 16, 2021

mcomella commented Apr 7, 2021 •

edited by data-sync-user