-
Notifications
You must be signed in to change notification settings - Fork 1.3k
For #18836: add telemetry for start up type #19028
For #18836: add telemetry for start up type #19028
Conversation
…test. The test failed with the rewrite of the code because it violates one of our assumptions that only one Activity will be started. However, since it doesn't rely on observed behavior and we made up the events, it's value is questionable so it seems okay to remove, especially for the gain of conciseness in the code.
This pull request has conflicts when rebasing. Could you fix it @mcomella? 🙏 |
c2005f9
to
cb76841
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me (Want to say again that I like this approach)
unit test timeout while the rest passed: let's try again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-
Is there or will there be documentation that describes the schema for the ultimate data set in a public, complete, and accurate way?
This will be documented in metrics.md -
Is there a control mechanism that allows the user to turn the data collection on and off?
Yes, users can opt out of telemetry collection. -
If the request is for permanent data collection, is there someone who will monitor the data over time?
Not permanent data collection. -
Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?
Category 2, Interaction Data. -
Is the data collection request for default-on or default-off?
Default on. -
Does the instrumentation include the addition of any new identifiers?
No new identifiers. -
Is the data collection covered by the existing Firefox privacy notice?
Yes. -
Does there need to be a check-in in the future to determine whether to renew the data?
Yes, check in in 6 months to renew if needed (October 2021). -
Does the data collection use a third-party collection tool?
No.
data-review +
Build failure was a network issue:
Let's rerun. |
This pull request has conflicts when rebasing. Could you fix it @mcomella? 🙏 |
@MarcLeclair For review
@mmccorks for data review
Request for data collection review form
All questions are mandatory. You must receive review from a data steward peer on your responses to these questions before shipping new data collection.
None: we need to understand user behavior in the wild
An existing probe
app_opened_all_startup
, tries to measure this but we found one thing wrong with it so I doubt its accuracy. So no.Note that the data steward reviewing your request will characterize your data collection based on the highest (and most sensitive) category.
https://github.com/mozilla-mobile/fenix/blob/master/docs/metrics.md
All
All
All
N/A
Telemetry opt out in app
Internally: GLAM, sql.tmo, gdocs
No
Pull Request checklist
To download an APK when reviewing a PR: