Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Telemetry] Send a Glean event when users change their default browser #18857

Closed
7 tasks
tdsmith opened this issue Apr 7, 2021 · 3 comments · Fixed by #18982
Closed
7 tasks

[Telemetry] Send a Glean event when users change their default browser #18857

tdsmith opened this issue Apr 7, 2021 · 3 comments · Fixed by #18982
Assignees
Labels
E2 Estimation Point: easy, half a day to 2 days Feature:Telemetry
Milestone

Comments

@tdsmith
Copy link
Contributor

tdsmith commented Apr 7, 2021

Description & Product Manager / Data Scientist User Story

In #12103/#13003 we started sending Leanplum events marking when users changed their default browser. For the purposes of the set-default experiment (#18796) and future experimentation, it would be convenient to emit these as Glean events as well so that we can observe changes to the default browser in the same ping as interactions with the UI elements we're instrumenting.

As a data scientist, I want to be able to observe a Glean event when users switch their default browser to Fenix.

@eliserichards, I think this relates to the comment thread in https://docs.google.com/document/d/1fcG8V54gdEywQcSRJTsBNgzOM3EQWnmPF7jqElxpzcs/edit -- I'm not sure if there's a more direct signal we can use versus checking "is the default browser state what we remembered it was," which is what I think the Leanplum event does—either option seems fine to me.

What questions will you answer with this data?

Acceptance Criteria

  • ENG files a DS JIRA request outlining their methodology. Let's discuss here instead as needed.
  • DS sign off on instrumentation methodology addressing product questions.
  • Event pings can be queried via re:dash
  • Event pings can be queried via amplitude
  • We are sending telemetry events for the actions listed in the requirements
  • We have documented the telemetry
  • We have asked a data steward to review the telemetry

┆Issue is synchronized with this Jira Task

@github-actions github-actions bot added the needs:triage Issue needs triage label Apr 7, 2021
@amedyne amedyne added this to Ready for Engineering (min-5 ; max-22) in Android Engineering Team Kanban board via automation Apr 8, 2021
@amedyne amedyne removed the needs:triage Issue needs triage label Apr 8, 2021
@Amejia481 Amejia481 added the E2 Estimation Point: easy, half a day to 2 days label Apr 13, 2021
@Amejia481 Amejia481 moved this from Ready for Engineering (min-5 ; max-22) to In Development (WIP limit - 15) in Android Engineering Team Kanban board Apr 13, 2021
@Amejia481 Amejia481 added this to the 89 milestone Apr 13, 2021
@Amejia481 Amejia481 linked a pull request Apr 13, 2021 that will close this issue
3 tasks
@Amejia481
Copy link
Contributor

Just for context we are also sending default_browser

@tdsmith
Copy link
Contributor Author

tdsmith commented Apr 13, 2021

Thanks for the callout. Having both the state and the transitions represented in telemetry for important lifecycle events helps us avoid having to synthesize one from the other, which can be annoying or expensive.

I see the events.set_default_browser_experiment event in #18982; I think an event that does not depend on this particular experiment will facilitate tracking set-default rates going forward, since I think we're probably going to return to this well for future experiments.

@tdsmith
Copy link
Contributor Author

tdsmith commented Apr 13, 2021

Oh: the other thing that we need is an event that we can observe in the control branch, which we don't get from #18982.

Amejia481 added a commit to Amejia481/fenix that referenced this issue Apr 14, 2021
Amejia481 added a commit to Amejia481/fenix that referenced this issue Apr 14, 2021
Amejia481 added a commit to Amejia481/fenix that referenced this issue Apr 14, 2021
Amejia481 added a commit to Amejia481/fenix that referenced this issue Apr 14, 2021
…ange their default browser

For mozilla-mobile#18855 [Telemetry] Send an event when users open the toolbar menu

For mozilla-mobile#18851 [Telemetry] Send an event when users click on the "set as default browser" entry in the toolbar menu
Amejia481 added a commit to Amejia481/fenix that referenced this issue Apr 14, 2021
…mobile#18857

For mozilla-mobile#18857 [Telemetry] Send a Glean event when users change their default browser

For mozilla-mobile#18855 [Telemetry] Send an event when users open the toolbar menu

For mozilla-mobile#18851 [Telemetry] Send an event when users click on the "set as default browser" entry in the toolbar menu
@Amejia481 Amejia481 moved this from In Development (WIP limit - 15) to Review in progress (WIP limit - 11) in Android Engineering Team Kanban board Apr 14, 2021
Amejia481 added a commit to Amejia481/fenix that referenced this issue Apr 14, 2021
…mobile#18857

For mozilla-mobile#18857 [Telemetry] Send a Glean event when users change their default browser

For mozilla-mobile#18855 [Telemetry] Send an event when users open the toolbar menu

For mozilla-mobile#18851 [Telemetry] Send an event when users click on the "set as default browser" entry in the toolbar menu
Amejia481 added a commit to Amejia481/fenix that referenced this issue Apr 14, 2021
…mobile#18857

For mozilla-mobile#18857 [Telemetry] Send a Glean event when users change their default browser

For mozilla-mobile#18855 [Telemetry] Send an event when users open the toolbar menu

For mozilla-mobile#18851 [Telemetry] Send an event when users click on the "set as default browser" entry in the toolbar menu
Android Engineering Team Kanban board automation moved this from Review in progress (WIP limit - 11) to Done Apr 15, 2021
mcarare pushed a commit that referenced this issue Apr 15, 2021
For #18857 [Telemetry] Send a Glean event when users change their default browser

For #18855 [Telemetry] Send an event when users open the toolbar menu

For #18851 [Telemetry] Send an event when users click on the "set as default browser" entry in the toolbar menu
@Amejia481 Amejia481 reopened this Apr 15, 2021
Android Engineering Team Kanban board automation moved this from Done to In Development (WIP limit - 15) Apr 15, 2021
@Amejia481 Amejia481 moved this from In Development (WIP limit - 15) to Dev Complete (WIP limit - 5) in Android Engineering Team Kanban board Apr 15, 2021
Android Engineering Team Kanban board automation moved this from Dev Complete (WIP limit - 5) to Done Apr 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
E2 Estimation Point: easy, half a day to 2 days Feature:Telemetry
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

3 participants